All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <a@unstable.cc>
To: Stephen Suryaputra <ssuryaextr@gmail.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next] gre/sit: Don't generate link-local addr if addr_gen_mode is IN6_ADDR_GEN_MODE_NONE
Date: Thu, 21 Oct 2021 15:41:42 +0200	[thread overview]
Message-ID: <f22b0813-6088-1fb1-b429-6a6596ffd877@unstable.cc> (raw)
In-Reply-To: <20211021132229.GA6483@ICIPI.localdomain>

Hi,

On 21/10/2021 15:22, Stephen Suryaputra wrote:
> On Thu, Oct 21, 2021 at 02:52:44PM +0200, Antonio Quartulli wrote:
>>
>> Maybe I am missing something, but why checking the mode only for
>> pointtopoint? If mode is NONE shouldn't this routine just abort
>> regardless of the interface setup?
>>
> If it isn't pointtopoint, the function sets up IPv4-compatible IPv6
> address, i.e. non link-local (FE80::). addr_gen_mode NONE (1) is only
> controlling the generation of link-local address. Quoting from the
> sysctl doc:
> 
> addr_gen_mode - INTEGER
> 	Defines how link-local and autoconf addresses are generated.
> 
> 	0: generate address based on EUI64 (default)
> 	1: do no generate a link-local address, use EUI64 for addresses generated
> 	   from autoconf
> 	2: generate stable privacy addresses, using the secret from
> 	   stable_secret (RFC7217)
> 	3: generate stable privacy addresses, using a random secret if unset
> 
> So, I thought the checking should be strictly when the link-local
> address is about to be generated.

Right.

IMHO it makes sense.

Acked-by: Antonio Quartulli <a@unstable.cc>

-- 
Antonio Quartulli

  reply	other threads:[~2021-10-21 13:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 20:06 [PATCH net-next] gre/sit: Don't generate link-local addr if addr_gen_mode is IN6_ADDR_GEN_MODE_NONE Stephen Suryaputra
2021-10-21 12:52 ` Antonio Quartulli
2021-10-21 13:22   ` Stephen Suryaputra
2021-10-21 13:41     ` Antonio Quartulli [this message]
2021-10-22 21:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f22b0813-6088-1fb1-b429-6a6596ffd877@unstable.cc \
    --to=a@unstable.cc \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ssuryaextr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.