From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B01C43461 for ; Sat, 5 Sep 2020 14:22:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27ECC206A5 for ; Sat, 5 Sep 2020 14:22:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RrfxzOFh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728264AbgIEOWm (ORCPT ); Sat, 5 Sep 2020 10:22:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727875AbgIEOWl (ORCPT ); Sat, 5 Sep 2020 10:22:41 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6BFCC061244 for ; Sat, 5 Sep 2020 07:22:40 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id b79so9290088wmb.4 for ; Sat, 05 Sep 2020 07:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=cc:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6uEKfLEocUbW2sA0QFr4mnO+v3niwDq3rSTsraC0Wn8=; b=RrfxzOFhe2pasaqqyeQxT2RATEIR1ag6fiCmK4bI/htnImMbvCyh3Vk83TK8blEid9 IR+4hUXq2yIKydJmOn40oln5qWfUKQVZJbTaEzwmipfVVLiXxRt3sHN0mDXPWkT046ox e5seninjITINubLWgKFQv/GEasnz+DvYCz1cWT8EP+udHspMNZMu7vU1BJ9UsnzELPBm cdJa5QqPIHzetw6NzDD4d/H/2Ss++ET9czXo/o48VEv5NrEmKj33Hh3a7UR/EEtkFzMZ 0UrUifc/hV6xtg3dhMoWfkyMaEVwSB9UNBPVxxNw2qwHpeQCcZsQ9oRLhSI+NmoD3MpM BdKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6uEKfLEocUbW2sA0QFr4mnO+v3niwDq3rSTsraC0Wn8=; b=m14YQNS+2YYmWgJDFoFeBhzl2GmVSP46vktDHgeFEbfTjYvU0rp72KpmIQVwXAgjMD 1KW43LV2P60W07U8nQS8/8aw+B2/Hy5sJWHIbyxzbk0cb0wOpH8GuUShLAMCzaOWDiVS onSStDpC2OBnU/hJ/+/yBZWZHISrnP6xUL+Kpx07nUu/VN66SsdiNvPViSyjsfg7zXcq A3zkapYbiJR5xAUUBDko7V29LYp91+gwJDInaDFGRBTr2kYXyy1E51XZxGiEVDWpIwaF twCBWGCZTxd0Oj3uZepyeuCEe4pSgZ9eJguh7F0CmfC5Elzde0kDUkjgUzs04GI5p1KQ ZtXw== X-Gm-Message-State: AOAM532t4ru5oTnCkGHxKvZ/Mc/t3QEfeIo5eHG9tz13mrp+bJHNw7ji yQkjFUeJc5aEa0BgZ9+duxQ= X-Google-Smtp-Source: ABdhPJyrOijFV5AT6SeQ9X/rWAPjUHS86KTU6T5cXJLxmlfTwtnp177Ba8Vsl+O3u0/XElBEPF5TAg== X-Received: by 2002:a7b:c015:: with SMTP id c21mr12368203wmb.87.1599315759380; Sat, 05 Sep 2020 07:22:39 -0700 (PDT) Received: from ?IPv6:2001:a61:3ab0:7001:e081:d401:3da8:e4bc? ([2001:a61:3ab0:7001:e081:d401:3da8:e4bc]) by smtp.gmail.com with ESMTPSA id 31sm17656867wrd.26.2020.09.05.07.22.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Sep 2020 07:22:38 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, Jakub Wilk Subject: Re: [PATCH (2) 29/34] tsearch.3: Use sizeof consistently To: Alejandro Colomar References: <8458b842-7d4b-f19b-c596-7f529dd48ba6@gmail.com> <497bc4f4-31f5-91a5-8bc4-469e22b26502@gmail.com> <8160510c-4d9e-7f30-e810-648b0b58a986@gmail.com> <87d5b09a-a3c8-622c-d731-5d42644a5f24@gmail.com> <61d2f2f9-08d0-9f1a-9642-ae56b3f4b61d@gmail.com> <4bb9e639-83ee-ede0-f6ad-dfc16787d358@gmail.com> <3c25bbda-bc90-1364-77cd-2c637f09d611@gmail.com> <4f0ff40c-2a63-736d-698f-0efc436c3678@gmail.com> <5343bbd1-b03f-29bf-2def-c27ba3a3616e@gmail.com> <4eba3ee9-bb6a-810f-55ae-7f0d76d446a7@gmail.com> <82aa16c3-60fe-68b3-103f-6d438563f3c2@gmail.com> <6e6d6796-32e0-9cc1-1e6c-4abb0b702499@gmail.com> <718db444-6679-224e-c649-6dd219b9db3c@gmail.com> <36a9ef8e-6fd9-e074-2a19-d8529f425501@gmail.com> <81f3377e-e758-12a1-8ad1-bc1988fa563f@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: Date: Sat, 5 Sep 2020 16:22:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <81f3377e-e758-12a1-8ad1-bc1988fa563f@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org Hello Alex, On 9/4/20 5:03 PM, Alejandro Colomar wrote: >>>From ff3fe9cdfd280fce97e9289e9a91fb6cc2c1c368 Mon Sep 17 00:00:00 2001 > From: Alejandro Colomar > Date: Thu, 3 Sep 2020 21:56:52 +0200 > Subject: [PATCH 29/34] tsearch.3: Use sizeof consistently > > Use ``sizeof`` consistently through all the examples in the following > way: > > - Use the name of the variable instead of its type as argument for > ``sizeof``. > > Rationale: > https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory > > Signed-off-by: Alejandro Colomar Patch applied. Cheers, Michael > --- > man3/tsearch.3 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man3/tsearch.3 b/man3/tsearch.3 > index 452395d6b..f0ff80e8c 100644 > --- a/man3/tsearch.3 > +++ b/man3/tsearch.3 > @@ -327,7 +327,7 @@ main(void) > > srand(time(NULL)); > for (i = 0; i < 12; i++) { > - ptr = xmalloc(sizeof(int)); > + ptr = xmalloc(sizeof(*ptr)); > *ptr = rand() & 0xff; > val = tsearch((void *) ptr, &root, compare); > if (val == NULL) > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/