From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F39C12002 for ; Fri, 16 Jul 2021 10:44:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F9BB6102A for ; Fri, 16 Jul 2021 10:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238809AbhGPKr2 (ORCPT ); Fri, 16 Jul 2021 06:47:28 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:14255 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238724AbhGPKrY (ORCPT ); Fri, 16 Jul 2021 06:47:24 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1626432270; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=fRfzqitEiF6pl1t4p+k88/o5RHLLygqMeNZ3f4gZTbw=; b=gCnlyxbgee29vYMVW50cE6prK1Siql+xHgXb9Ebv45iiFwTaIWSVDmf63ZxuRTNf8F3m251/ yspSSMY/bLuxZjObTlojRKA2KbD1i4x0pjWitweZ28wgDfsL/qBc1fDSA9nmyJKd79u3QZx3 5egUBsqZZ+fcsEGtxL2bWVajbZI= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 60f162fc4815712f3ac18cfb (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 16 Jul 2021 10:44:12 GMT Sender: charante=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CBDEBC4323A; Fri, 16 Jul 2021 10:44:11 +0000 (UTC) Received: from [192.168.29.110] (unknown [49.37.159.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: charante) by smtp.codeaurora.org (Postfix) with ESMTPSA id D607FC433D3; Fri, 16 Jul 2021 10:44:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D607FC433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=charante@codeaurora.org Subject: Re: [PATCH V4,0/3] mm: compaction: proactive compaction trigger by user To: Andrew Morton Cc: vbabka@suse.cz, corbet@lwn.net, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, osalvador@suse.de, rientjes@google.com, mchehab+huawei@kernel.org, lokeshgidra@google.com, andrew.a.klychkov@gmail.com, xi.fengfei@h3c.com, nigupta@nvidia.com, dave.hansen@linux.intel.com, famzheng@amazon.com, mateusznosek0@gmail.com, oleksandr@redhat.com, sh_def@163.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, "vinmenon@codeaurora.org" References: <20210715212744.1a43012c21711bafd25e5b68@linux-foundation.org> From: Charan Teja Kalla Message-ID: Date: Fri, 16 Jul 2021 16:14:01 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210715212744.1a43012c21711bafd25e5b68@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Andrew for the reply!! On 7/16/2021 9:57 AM, Andrew Morton wrote: > On Sat, 3 Jul 2021 15:52:10 +0530 Charan Teja Kalla wrote: > >> A gentle ping to have your valuable comments. > > Can we please have a resend? > > The series has two fixes against the current code. Please separate > that work out from the new feature. So a 2-patch series to fix the bugs > followed by a single patch to add your new feature. https://lore.kernel.org/patchwork/patch/1448789/ -- Can go as a separate bug fix. https://lore.kernel.org/patchwork/patch/1448793/ -- is the second bug fix which is tightly coupled with the feature of explicitly waking of kcompactd on the event of change in compaction proactiveness, when it is sleeping with MAX_SCHEDULE_TIMEOUT. So, will make the changes with 1 patch bug fix and 2nd patch feature where the second bug fix also clubbed. I hope this is fine. > > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project