All of lore.kernel.org
 help / color / mirror / Atom feed
From: sbhanu@codeaurora.org
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org,
	robh+dt@kernel.org, asutoshd@codeaurora.org,
	stummala@codeaurora.org, vbadigan@codeaurora.org,
	rampraka@codeaurora.org, sayalil@codeaurora.org,
	sartgarg@codeaurora.org, rnayak@codeaurora.org,
	saiprakash.ranjan@codeaurora.org, sibis@codeaurora.org,
	okukatla@codeaurora.org, djakov@kernel.org, cang@codeaurora.org,
	pragalla@codeaurora.org, nitirawa@codeaurora.org,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	agross@kernel.org
Subject: Re: [PATCH V1] arm64: dts: qcom: sc7180: Added xo clock for eMMC and Sd card
Date: Tue, 15 Jun 2021 15:30:07 +0530	[thread overview]
Message-ID: <f24b5538fb28595ab1d9353a6a8e429d@codeaurora.org> (raw)
In-Reply-To: <YMeEPg7EPC5E/MfW@builder.lan>

On 2021-06-14 22:00, Bjorn Andersson wrote:
> On Mon 14 Jun 06:55 CDT 2021, sbhanu@codeaurora.org wrote:
> 
>> On 2021-06-11 10:00, Bjorn Andersson wrote:
>> > On Thu 10 Jun 02:11 CDT 2021, Shaik Sajida Bhanu wrote:
>> >
>> > > Added xo clock for eMMC and Sd card.
>> >
>> > Was about to push out my branch of patches, but before I do. Can you
>> > please describe WHY this is needed?
>> >
>> > Regards,
>> > Bjorn
>> 
>> We are making use of this clock in dll register value calculation,
>> The default PoR value is also same as calculated value for
>> HS200/HS400/SDR104 modes.
>> But just not to rely on default register values we need this entry.
>> 
> 
> That is the perfect thing to include in a commit message!
> 
> I rewrote yours and applied the change, but please next time do 
> describe
> the "why" of your change.
> 
> Regards,
> Bjorn
Sure
> 
>> >
>> > >
>> > > Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
>> > > ---
>> > >  arch/arm64/boot/dts/qcom/sc7180.dtsi | 10 ++++++----
>> > >  1 file changed, 6 insertions(+), 4 deletions(-)
>> > >
>> > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> > > b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> > > index 295844e..5bb6bd4 100644
>> > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> > > @@ -701,8 +701,9 @@
>> > >  			interrupt-names = "hc_irq", "pwr_irq";
>> > >
>> > >  			clocks = <&gcc GCC_SDCC1_APPS_CLK>,
>> > > -					<&gcc GCC_SDCC1_AHB_CLK>;
>> > > -			clock-names = "core", "iface";
>> > > +					<&gcc GCC_SDCC1_AHB_CLK>,
>> > > +					<&rpmhcc RPMH_CXO_CLK>;
>> > > +			clock-names = "core", "iface","xo";
>> > >  			interconnects = <&aggre1_noc MASTER_EMMC 0 &mc_virt SLAVE_EBI1 0>,
>> > >  					<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_EMMC_CFG 0>;
>> > >  			interconnect-names = "sdhc-ddr","cpu-sdhc";
>> > > @@ -2666,8 +2667,9 @@
>> > >  			interrupt-names = "hc_irq", "pwr_irq";
>> > >
>> > >  			clocks = <&gcc GCC_SDCC2_APPS_CLK>,
>> > > -					<&gcc GCC_SDCC2_AHB_CLK>;
>> > > -			clock-names = "core", "iface";
>> > > +					<&gcc GCC_SDCC2_AHB_CLK>,
>> > > +					<&rpmhcc RPMH_CXO_CLK>;
>> > > +			clock-names = "core", "iface", "xo";
>> > >
>> > >  			interconnects = <&aggre1_noc MASTER_SDCC_2 0 &mc_virt SLAVE_EBI1
>> > > 0>,
>> > >  					<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_SDCC_2 0>;
>> > > --
>> > > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
>> > > member
>> > > of Code Aurora Forum, hosted by The Linux Foundation
>> > >

      reply	other threads:[~2021-06-15 10:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10  7:11 [PATCH V1] arm64: dts: qcom: sc7180: Added xo clock for eMMC and Sd card Shaik Sajida Bhanu
2021-06-10  7:54 ` Konrad Dybcio
2021-06-11  3:29   ` Bjorn Andersson
2021-06-14 11:44   ` sbhanu
2021-06-14 11:49     ` Konrad Dybcio
2021-06-11  4:30 ` Bjorn Andersson
2021-06-14 11:55   ` sbhanu
2021-06-14 16:30     ` Bjorn Andersson
2021-06-15 10:00       ` sbhanu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f24b5538fb28595ab1d9353a6a8e429d@codeaurora.org \
    --to=sbhanu@codeaurora.org \
    --cc=adrian.hunter@intel.com \
    --cc=agross@kernel.org \
    --cc=asutoshd@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=cang@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=nitirawa@codeaurora.org \
    --cc=okukatla@codeaurora.org \
    --cc=pragalla@codeaurora.org \
    --cc=rampraka@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=sartgarg@codeaurora.org \
    --cc=sayalil@codeaurora.org \
    --cc=sibis@codeaurora.org \
    --cc=stummala@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vbadigan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.