From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH V3] xen/altp2m: set access_required properly for all altp2ms Date: Mon, 23 Jul 2018 12:35:35 +0100 Message-ID: References: <1530172441-2553-1-git-send-email-rcojocaru@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1530172441-2553-1-git-send-email-rcojocaru@bitdefender.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Razvan Cojocaru , xen-devel@lists.xen.org Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Tamas K Lengyel , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gMDYvMjgvMjAxOCAwODo1NCBBTSwgUmF6dmFuIENvam9jYXJ1IHdyb3RlOgo+IEZvciB0aGUg aG9zdHAybSwgYWNjZXNzX3JlcXVpcmVkIHN0YXJ0cyBvZmYgYXMgMCwgdGhlbiBpdCBjYW4gYmUK PiBzZXQgd2l0aCB4Y19kb21haW5fc2V0X2FjY2Vzc19yZXF1aXJlZCgpLiBIb3dldmVyLCBhbGwg dGhlIGFsdHAybXMKPiBzZXQgaXQgdG8gMSBvbiBpbml0LCBhbmQgaWdub3JlIGJvdGggdGhlIGhv c3RwMm0gYW5kIHRoZSBoeXBlcmNhbGwuCj4gVGhpcyBwYXRjaCBzZXRzIGFjY2Vzc19yZXF1aXJl ZCB0byB0aGUgdmFsdWUgZnJvbSB0aGUgaG9zdHAybQo+IG9uIGFsdHAybSBpbml0LCBhbmQgcHJv cGFnYXRlcyB0aGUgdmFsdWVzIHJlY2VpdmVkIHZpYSBoeXBlcmNhbGwKPiB0byBhbGwgdGhlIGFj dGl2ZSBhbHRwMm1zLCB3aGVuIGFwcGxpY2FibGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogUmF6dmFu IENvam9jYXJ1IDxyY29qb2NhcnVAYml0ZGVmZW5kZXIuY29tPgoKUmV2aWV3ZWQtYnk6IEdlb3Jn ZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT4KCj4gCj4gLS0tCj4gQ2M6IFN0ZWZh bm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4KPiBDYzogSnVsaWVuIEdyYWxs IDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPiBDYzogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3Bl cjNAY2l0cml4LmNvbT4KPiBDYzogR2VvcmdlIER1bmxhcCA8R2VvcmdlLkR1bmxhcEBldS5jaXRy aXguY29tPgo+IENjOiBJYW4gSmFja3NvbiA8aWFuLmphY2tzb25AZXUuY2l0cml4LmNvbT4KPiBD YzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+IENjOiBLb25yYWQgUnplc3p1dGVr IFdpbGsgPGtvbnJhZC53aWxrQG9yYWNsZS5jb20+Cj4gQ2M6IFRpbSBEZWVnYW4gPHRpbUB4ZW4u b3JnPgo+IENjOiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPgo+IENjOiBHZW9yZ2UgRHVu bGFwIDxnZW9yZ2UuZHVubGFwQGV1LmNpdHJpeC5jb20+Cj4gQ2M6IFRhbWFzIEsgTGVuZ3llbCA8 dGFtYXNAdGtsZW5neWVsLmNvbT4KPiAtLS0KPiBDaGFuZ2VzIHNpbmNlIFYyOgo+ICAtIFJlbmFt ZWQgYXJjaF9kb21haW5fc2V0X2FjY2Vzc19yZXF1aXJlZCgpIHRvCj4gICAgYXJjaF9wMm1fc2V0 X2FjY2Vzc19yZXF1aXJlZCgpIChyZXF1ZXN0ZWQgYnkgV2VpIExpdSkuCj4gIC0gQWRkZWQgQVNT RVJUKGF0b21pY19yZWFkKCZkLT5wYXVzZV9jb3VudCkpIHRvCj4gICAgYXJjaF9wMm1fc2V0X2Fj Y2Vzc19yZXF1aXJlZCgpIChyZXF1ZXN0ZWQgYnkgV2VpIExpdSkuCj4gLS0tCj4gIHhlbi9hcmNo L2FybS9tZW1fYWNjZXNzLmMgICAgfCAgNiArKysrKysKPiAgeGVuL2FyY2gveDg2L21tL21lbV9h Y2Nlc3MuYyB8IDIwICsrKysrKysrKysrKysrKysrKysrCj4gIHhlbi9hcmNoL3g4Ni9tbS9wMm0u YyAgICAgICAgfCAgMyArKy0KPiAgeGVuL2NvbW1vbi9kb21jdGwuYyAgICAgICAgICB8ICA0ICsr LS0KPiAgeGVuL2luY2x1ZGUveGVuL2RvbWFpbi5oICAgICB8ICAyICsrCj4gIDUgZmlsZXMgY2hh bmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv eGVuL2FyY2gvYXJtL21lbV9hY2Nlc3MuYyBiL3hlbi9hcmNoL2FybS9tZW1fYWNjZXNzLmMKPiBp bmRleCBhZTI2ODZmLi5iYTRlYzc4IDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL2FybS9tZW1fYWNj ZXNzLmMKPiArKysgYi94ZW4vYXJjaC9hcm0vbWVtX2FjY2Vzcy5jCj4gQEAgLTQ1Myw2ICs0NTMs MTIgQEAgaW50IHAybV9nZXRfbWVtX2FjY2VzcyhzdHJ1Y3QgZG9tYWluICpkLCBnZm5fdCBnZm4s Cj4gICAgICByZXR1cm4gcmV0Owo+ICB9Cj4gIAo+ICt2b2lkIGFyY2hfcDJtX3NldF9hY2Nlc3Nf cmVxdWlyZWQoc3RydWN0IGRvbWFpbiAqZCwgYm9vbCBhY2Nlc3NfcmVxdWlyZWQpCj4gK3sKPiAr ICAgIEFTU0VSVChhdG9taWNfcmVhZCgmZC0+cGF1c2VfY291bnQpKTsKPiArICAgIHAybV9nZXRf aG9zdHAybShkKS0+YWNjZXNzX3JlcXVpcmVkID0gYWNjZXNzX3JlcXVpcmVkOwo+ICt9Cj4gKwo+ ICAvKgo+ICAgKiBMb2NhbCB2YXJpYWJsZXM6Cj4gICAqIG1vZGU6IEMKPiBkaWZmIC0tZ2l0IGEv eGVuL2FyY2gveDg2L21tL21lbV9hY2Nlc3MuYyBiL3hlbi9hcmNoL3g4Ni9tbS9tZW1fYWNjZXNz LmMKPiBpbmRleCBjMGNkMDE3Li40NjRiZTQ5IDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9t bS9tZW1fYWNjZXNzLmMKPiArKysgYi94ZW4vYXJjaC94ODYvbW0vbWVtX2FjY2Vzcy5jCj4gQEAg LTQ2NSw2ICs0NjUsMjYgQEAgaW50IHAybV9nZXRfbWVtX2FjY2VzcyhzdHJ1Y3QgZG9tYWluICpk LCBnZm5fdCBnZm4sIHhlbm1lbV9hY2Nlc3NfdCAqYWNjZXNzKQo+ICAgICAgcmV0dXJuIF9wMm1f Z2V0X21lbV9hY2Nlc3MocDJtLCBnZm4sIGFjY2Vzcyk7Cj4gIH0KPiAgCj4gK3ZvaWQgYXJjaF9w Mm1fc2V0X2FjY2Vzc19yZXF1aXJlZChzdHJ1Y3QgZG9tYWluICpkLCBib29sIGFjY2Vzc19yZXF1 aXJlZCkKPiArewo+ICsgICAgdW5zaWduZWQgaW50IGk7Cj4gKwo+ICsgICAgQVNTRVJUKGF0b21p Y19yZWFkKCZkLT5wYXVzZV9jb3VudCkpOwo+ICsKPiArICAgIHAybV9nZXRfaG9zdHAybShkKS0+ YWNjZXNzX3JlcXVpcmVkID0gYWNjZXNzX3JlcXVpcmVkOwo+ICsKPiArICAgIGlmICggIWFsdHAy bV9hY3RpdmUoZCkgKQo+ICsgICAgICAgIHJldHVybjsKPiArCj4gKyAgICBmb3IgKCBpID0gMDsg aSA8IE1BWF9BTFRQMk07IGkrKyApCj4gKyAgICB7Cj4gKyAgICAgICAgc3RydWN0IHAybV9kb21h aW4gKnAybSA9IGQtPmFyY2guYWx0cDJtX3AybVtpXTsKPiArCj4gKyAgICAgICAgaWYgKCBwMm0g KQo+ICsgICAgICAgICAgICBwMm0tPmFjY2Vzc19yZXF1aXJlZCA9IGFjY2Vzc19yZXF1aXJlZDsK PiArICAgIH0KPiArfQo+ICsKPiAgLyoKPiAgICogTG9jYWwgdmFyaWFibGVzOgo+ICAgKiBtb2Rl OiBDCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYyBiL3hlbi9hcmNoL3g4Ni9t bS9wMm0uYwo+IGluZGV4IGM1M2NhYjQuLjhlOWZiYjUgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gv eDg2L21tL3AybS5jCj4gKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCj4gQEAgLTE5OSw2ICsx OTksNyBAQCBzdGF0aWMgaW50IHAybV9pbml0X2FsdHAybShzdHJ1Y3QgZG9tYWluICpkKQo+ICB7 Cj4gICAgICB1bnNpZ25lZCBpbnQgaTsKPiAgICAgIHN0cnVjdCBwMm1fZG9tYWluICpwMm07Cj4g KyAgICBzdHJ1Y3QgcDJtX2RvbWFpbiAqaG9zdHAybSA9IHAybV9nZXRfaG9zdHAybShkKTsKPiAg Cj4gICAgICBtbV9sb2NrX2luaXQoJmQtPmFyY2guYWx0cDJtX2xpc3RfbG9jayk7Cj4gICAgICBm b3IgKCBpID0gMDsgaSA8IE1BWF9BTFRQMk07IGkrKyApCj4gQEAgLTIxMCw3ICsyMTEsNyBAQCBz dGF0aWMgaW50IHAybV9pbml0X2FsdHAybShzdHJ1Y3QgZG9tYWluICpkKQo+ICAgICAgICAgICAg ICByZXR1cm4gLUVOT01FTTsKPiAgICAgICAgICB9Cj4gICAgICAgICAgcDJtLT5wMm1fY2xhc3Mg PSBwMm1fYWx0ZXJuYXRlOwo+IC0gICAgICAgIHAybS0+YWNjZXNzX3JlcXVpcmVkID0gMTsKPiAr ICAgICAgICBwMm0tPmFjY2Vzc19yZXF1aXJlZCA9IGhvc3RwMm0tPmFjY2Vzc19yZXF1aXJlZDsK PiAgICAgICAgICBfYXRvbWljX3NldCgmcDJtLT5hY3RpdmVfdmNwdXMsIDApOwo+ICAgICAgfQo+ ICAKPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9kb21jdGwuYyBiL3hlbi9jb21tb24vZG9tY3Rs LmMKPiBpbmRleCA5YjdiYzA4Li43ODliMzBkIDEwMDY0NAo+IC0tLSBhL3hlbi9jb21tb24vZG9t Y3RsLmMKPiArKysgYi94ZW4vY29tbW9uL2RvbWN0bC5jCj4gQEAgLTEwOTIsOCArMTA5Miw4IEBA IGxvbmcgZG9fZG9tY3RsKFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0oeGVuX2RvbWN0bF90KSB1X2Rv bWN0bCkKPiAgICAgICAgICBlbHNlCj4gICAgICAgICAgewo+ICAgICAgICAgICAgICBkb21haW5f cGF1c2UoZCk7Cj4gLSAgICAgICAgICAgIHAybV9nZXRfaG9zdHAybShkKS0+YWNjZXNzX3JlcXVp cmVkID0KPiAtICAgICAgICAgICAgICAgIG9wLT51LmFjY2Vzc19yZXF1aXJlZC5hY2Nlc3NfcmVx dWlyZWQ7Cj4gKyAgICAgICAgICAgIGFyY2hfcDJtX3NldF9hY2Nlc3NfcmVxdWlyZWQoZCwKPiAr ICAgICAgICAgICAgICAgIG9wLT51LmFjY2Vzc19yZXF1aXJlZC5hY2Nlc3NfcmVxdWlyZWQpOwo+ ICAgICAgICAgICAgICBkb21haW5fdW5wYXVzZShkKTsKPiAgICAgICAgICB9Cj4gICAgICAgICAg YnJlYWs7Cj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3hlbi9kb21haW4uaCBiL3hlbi9pbmNs dWRlL3hlbi9kb21haW4uaAo+IGluZGV4IDE3N2NiMzUuLmYzNWUzNjAgMTAwNjQ0Cj4gLS0tIGEv eGVuL2luY2x1ZGUveGVuL2RvbWFpbi5oCj4gKysrIGIveGVuL2luY2x1ZGUveGVuL2RvbWFpbi5o Cj4gQEAgLTY2LDYgKzY2LDggQEAgdm9pZCBhcmNoX2RvbWFpbl91bnBhdXNlKHN0cnVjdCBkb21h aW4gKmQpOwo+ICAKPiAgaW50IGFyY2hfZG9tYWluX3NvZnRfcmVzZXQoc3RydWN0IGRvbWFpbiAq ZCk7Cj4gIAo+ICt2b2lkIGFyY2hfcDJtX3NldF9hY2Nlc3NfcmVxdWlyZWQoc3RydWN0IGRvbWFp biAqZCwgYm9vbCBhY2Nlc3NfcmVxdWlyZWQpOwo+ICsKPiAgaW50IGFyY2hfc2V0X2luZm9fZ3Vl c3Qoc3RydWN0IHZjcHUgKiwgdmNwdV9ndWVzdF9jb250ZXh0X3UpOwo+ICB2b2lkIGFyY2hfZ2V0 X2luZm9fZ3Vlc3Qoc3RydWN0IHZjcHUgKiwgdmNwdV9ndWVzdF9jb250ZXh0X3UpOwo+ICAKPiAK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2 ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xp c3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs