From: <Bjarni.Jonasson@microchip.com>
To: <andrew@lunn.ch>
Cc: <linux-kernel@vger.kernel.org>, <UNGLinuxDriver@microchip.com>,
<Steen.Hegelund@microchip.com>, <linux@armlinux.org.uk>,
<f.fainelli@gmail.com>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <vladimir.oltean@nxp.com>,
<davem@davemloft.net>, <hkallweit1@gmail.com>,
<atenart@kernel.org>, <ioana.ciornei@nxp.com>
Subject: Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514
Date: Mon, 15 Feb 2021 09:27:11 +0000 [thread overview]
Message-ID: <f25d05b2470f66ddf174e4b64545ecc486a98d81.camel@microchip.com> (raw)
In-Reply-To: <YCakxN3iYvsW8afy@lunn.ch>
On Fri, 2021-02-12 at 16:54 +0100, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote:
> > At Power-On Reset, transients may cause the LCPLL to lock onto a
> > clock that is momentarily unstable. This is normally seen in QSGMII
> > setups where the higher speed 6G SerDes is being used.
> > This patch adds an initial LCPLL Reset to the PHY (first instance)
> > to avoid this issue.
>
> Hi Bjarni
>
>
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>
> These patches are rather large for stable, and not obviously correct.
>
> There these problems hitting real users running stable kernels? Or is
> it so broken it never really worked?
>
> Andrew
Correct, the current linux driver is unstable and has never really
worked properly. Our in-house SDK driver already have these fixes and
the upstreamed version has been lagging behind. And yes the patches
are big, we had to pull out the calibration from the 8051 into the
driver.
next prev parent reply other threads:[~2021-02-15 9:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 14:06 [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514 Bjarni Jonasson
2021-02-12 14:06 ` [PATCH net v1 2/3] net: phy: mscc: improved serdes calibration applied " Bjarni Jonasson
2021-02-12 16:24 ` Vladimir Oltean
2021-02-12 14:06 ` [PATCH net v1 3/3] net: phy: mscc: coma mode disabled for VSC8514 Bjarni Jonasson
2021-02-12 16:32 ` Vladimir Oltean
2021-02-15 9:36 ` Bjarni.Jonasson
2021-02-12 15:20 ` [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514 Andrew Lunn
2021-02-15 9:15 ` Bjarni.Jonasson
2021-02-12 15:54 ` Andrew Lunn
2021-02-15 9:27 ` Bjarni.Jonasson [this message]
2021-02-12 16:23 ` Vladimir Oltean
2021-02-12 18:53 ` Jakub Kicinski
2021-02-15 9:38 ` Bjarni.Jonasson
2021-02-12 22:38 ` kernel test robot
2021-02-12 22:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f25d05b2470f66ddf174e4b64545ecc486a98d81.camel@microchip.com \
--to=bjarni.jonasson@microchip.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.