All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: TIAN Yuanhao <tianyuanhao3@163.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/network-manager: remove invalid dependencies
Date: Tue, 19 Apr 2022 22:39:57 +0200	[thread overview]
Message-ID: <f25e4d35-a685-f482-44a4-acae8b301af5@mind.be> (raw)
In-Reply-To: <20220415025224.1876125-1-tianyuanhao3@163.com>



On 15/04/2022 04:52, TIAN Yuanhao wrote:
> Dependency on libiw has been removed since 0.9.3.990 [1].
> Dependency on libgcrypt has been removed since 1.2-beta1 [2].
> Dependency on libuuid has been removed since 1.31.4-dev [3].
> 
> [1]: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/7d0761588c2dde8816c109c38c1c94233fd74afe
> [2]: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b6f5f030331cc680edbe19ae322e894494d63687
> [3]: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/73b9883c6f30320b727a664ff2c84cc772aac94b
> 
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>

  Applied to master, thanks. Thank you for the detailed research on when/why 
they were removed.

  Regards,
  Arnout

> ---
>   package/network-manager/Config.in          | 6 ------
>   package/network-manager/network-manager.mk | 2 +-
>   2 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in
> index a48cb37b15..1370c81c9c 100644
> --- a/package/network-manager/Config.in
> +++ b/package/network-manager/Config.in
> @@ -1,6 +1,5 @@
>   config BR2_PACKAGE_NETWORK_MANAGER
>   	bool "network-manager"
> -	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt
>   	depends on !BR2_STATIC_LIBS # gnutls
>   	depends on BR2_USE_MMU # dbus
>   	depends on BR2_PACKAGE_HAS_UDEV
> @@ -13,11 +12,6 @@ config BR2_PACKAGE_NETWORK_MANAGER
>   	select BR2_PACKAGE_DBUS
>   	select BR2_PACKAGE_GNUTLS
>   	select BR2_PACKAGE_LIBGLIB2
> -	select BR2_PACKAGE_LIBGCRYPT
> -	select BR2_PACKAGE_UTIL_LINUX
> -	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
> -	select BR2_PACKAGE_WIRELESS_TOOLS
> -	select BR2_PACKAGE_WIRELESS_TOOLS_LIB
>   	select BR2_PACKAGE_LIBNDP
>   	help
>   	  NetworkManager is a set of co-operative tools that make
> diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
> index a90228992c..d979cfc0d7 100644
> --- a/package/network-manager/network-manager.mk
> +++ b/package/network-manager/network-manager.mk
> @@ -10,7 +10,7 @@ NETWORK_MANAGER_SOURCE = NetworkManager-$(NETWORK_MANAGER_VERSION).tar.xz
>   NETWORK_MANAGER_SITE = https://download.gnome.org/sources/NetworkManager/$(NETWORK_MANAGER_VERSION_MAJOR)
>   NETWORK_MANAGER_INSTALL_STAGING = YES
>   NETWORK_MANAGER_DEPENDENCIES = host-pkgconf udev gnutls libglib2 \
> -	libgcrypt wireless_tools util-linux host-intltool libndp
> +	host-intltool libndp
>   NETWORK_MANAGER_LICENSE = GPL-2.0+ (app), LGPL-2.1+ (libnm)
>   NETWORK_MANAGER_LICENSE_FILES = COPYING COPYING.LGPL CONTRIBUTING.md
>   NETWORK_MANAGER_CPE_ID_VENDOR = gnome
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-04-19 20:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15  2:52 [Buildroot] [PATCH] package/network-manager: remove invalid dependencies TIAN Yuanhao
2022-04-19 10:32 ` Marcus Hoffmann
2022-04-19 20:39 ` Arnout Vandecappelle [this message]
2022-05-22 20:19 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f25e4d35-a685-f482-44a4-acae8b301af5@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=tianyuanhao3@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.