From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 60A7AC433EF
	for <dpdk-dev@archiver.kernel.org>; Tue, 24 May 2022 06:35:26 +0000 (UTC)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4F8FC4067C;
	Tue, 24 May 2022 08:35:25 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 04B3B4014F
 for <dev@dpdk.org>; Tue, 24 May 2022 08:35:23 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 47CDB92;
 Tue, 24 May 2022 09:35:23 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 47CDB92
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1653374123;
 bh=s4n05tPY4OHHn/2o+GVhtXc8YAkRwxYe3avcrfrrax8=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=ljxzqlMuw5h1QktxfaFe7mvOlUmr4i8sGqycNr6+sVRTFxAWCHPUmchO9EVEivhdQ
 sIHIgctyFYvDDa5jLbszy59htFTrtZtqeDGAZdJHAoVg8u/LcSYX3m7Hl7Na234Kml
 HlSoZkmT82KeofJIOyPkxNfpXoMrs18zE1KoDG3Y=
Message-ID: <f2645cd1-a364-c305-7f17-73b0c4d59820@oktetlabs.ru>
Date: Tue, 24 May 2022 09:35:22 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark
Content-Language: en-US
To: Thomas Monjalon <thomas@monjalon.net>,
 =?UTF-8?Q?Morten_Br=c3=b8rup?= <mb@smartsharesystems.com>,
 Spike Du <spiked@nvidia.com>
Cc: dev@dpdk.org, Matan Azrad <matan@nvidia.com>,
 Slava Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>,
 Raslan Darawsheh <rasland@nvidia.com>, ferruh.yigit@xilinx.com
References: <20220506035645.4101714-1-spiked@nvidia.com>
 <3249537.9LS3J3VOpE@thomas>
 <MN2PR12MB36479421376CEC2276BCFEEBA8D49@MN2PR12MB3647.namprd12.prod.outlook.com>
 <5970049.YiXZdWvhHV@thomas>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <5970049.YiXZdWvhHV@thomas>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 5/23/22 17:39, Thomas Monjalon wrote:
> 23/05/2022 16:10, Spike Du:
>>> From: Thomas Monjalon <thomas@monjalon.net>
>>>> If you stick with percentage, it only needs 7 bits, and you can make the
>>> remaining one bit reserved.
>>
>> Agree, will change to use 7 bits.
> 
> I'm not sure it's worth introducing a bit field here.

+1