From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ED43C47409 for ; Fri, 7 Feb 2020 06:10:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 421B4214AF for ; Fri, 7 Feb 2020 06:10:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="FIhapa/P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726451AbgBGGK4 (ORCPT ); Fri, 7 Feb 2020 01:10:56 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:40409 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726587AbgBGGKz (ORCPT ); Fri, 7 Feb 2020 01:10:55 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581055855; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=9dWo6uK9jKsDwewb71Iojt0lLBywexIt8UvMHWOd8gc=; b=FIhapa/PnmiAkkjHq4G/8ziMmeYhJkEvaWhBwyny2AhURKQ6mLr22gMF+PAMp7J/0IqxExqu EVYvaD3URjup2djeHt2IQP3vV7b9EdEN15q7Uzh/6ApnCVFQgcIGMq3bngy6nJ/luc7n6YCm TesmAiagWPhsLGyvb9YCDiYAEHI= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e3cff6a.7f53327aeb58-smtp-out-n03; Fri, 07 Feb 2020 06:10:50 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 24B6BC4479C; Fri, 7 Feb 2020 06:10:50 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id A6F35C43383; Fri, 7 Feb 2020 06:10:49 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 07 Feb 2020 11:40:49 +0530 From: Sai Prakash Ranjan To: Rob Herring Cc: Andy Gross , Bjorn Andersson , Guenter Roeck , devicetree@vger.kernel.org, Douglas Anderson , Stephen Boyd , Matthias Kaehlcke , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree-owner@vger.kernel.org Subject: Re: [PATCHv2 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 In-Reply-To: <20200206183808.GA5019@bogus> References: <20200206183808.GA5019@bogus> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Rob, On 2020-02-07 00:08, Rob Herring wrote: > On Sat, Feb 01, 2020 at 08:59:49PM +0530, Sai Prakash Ranjan wrote: >> Add missing compatible for watchdog timer on QCS404, >> SC7180, SDM845 and SM8150 SoCs. > > That's not what the commit does. You are changing what's valid. > > One string was valid, now 2 are required. > Does this look good? diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml index 46d6aad5786a..3378244b67cd 100644 --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml @@ -14,19 +14,22 @@ allOf: properties: compatible: - items: + oneOf: - enum: - qcom,apss-wdt-qcs404 - qcom,apss-wdt-sc7180 - qcom,apss-wdt-sdm845 - qcom,apss-wdt-sm8150 - - qcom,kpss-timer - - qcom,kpss-wdt - qcom,kpss-wdt-apq8064 - qcom,kpss-wdt-ipq4019 - qcom,kpss-wdt-ipq8064 - qcom,kpss-wdt-msm8960 + - qcom,kpss-timer + - qcom,kpss-wdt - qcom,scss-timer + - const: qcom,kpss-timer + - const: qcom,kpss-wdt + - const: qcom,scss-timer reg: maxItems: 1 Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07FB1C2D0B1 for ; Fri, 7 Feb 2020 06:11:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D04DB20726 for ; Fri, 7 Feb 2020 06:11:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m2TN8tJu"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="UvqNzFIc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D04DB20726 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7MImNfMHwhQMTTjkMwZRLA4yeH5LYxvw8wsapFG8yeI=; b=m2TN8tJuaBnCi2dcDEIKJO48Y i2eIPXX9ZL1YgacACLMPgpEsdn7NFJQWv47HwtW7nbbRa+Qo1fMk0ULSE+z2+6XTJyf+y46yMXf/U LTuqD7zonyx7xMKKn9gCWekob0ti+DNsm+Ze56nkIvGlVIjdRUIwKxAYAyOyPKYyQqdJyX5h5Wzek HEQ1UX/bh8eghb86Od70eOJtiyBJJjq4KUum55rPHMnUuMdI0a2hocd8UKMVAEM53ikzYTTSD/30i ImrOA0DtaMXrE5pSIxyHhU1+voFHzHkngLMQ8pfir/4Q8RUuMUGi+R7HiZskEND6ZDGSULLLxGyNT rKrDGPVgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izwr1-0006ci-Nb; Fri, 07 Feb 2020 06:11:03 +0000 Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izwqv-0006bk-Lh for linux-arm-kernel@lists.infradead.org; Fri, 07 Feb 2020 06:11:00 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581055853; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=9dWo6uK9jKsDwewb71Iojt0lLBywexIt8UvMHWOd8gc=; b=UvqNzFIcs5mkEdBK61didkE3NJ3uQ1KnzyvHSp8bIDfJDNduiAkR0CLid6XP2XA+QbiGAIJK ENCVbNuEyrqoRJ8yrY6B/LrcPjz/rvYbXYPKb/tnQIwZ5sHsNtmEIL9BLupq3W9SMKkqemra VI9dfhQFjdSfFzyhgcyJp1AmSLQ= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e3cff6a.7f7f2539e340-smtp-out-n01; Fri, 07 Feb 2020 06:10:50 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 200DFC433CB; Fri, 7 Feb 2020 06:10:50 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id A6F35C43383; Fri, 7 Feb 2020 06:10:49 +0000 (UTC) MIME-Version: 1.0 Date: Fri, 07 Feb 2020 11:40:49 +0530 From: Sai Prakash Ranjan To: Rob Herring Subject: Re: [PATCHv2 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 In-Reply-To: <20200206183808.GA5019@bogus> References: <20200206183808.GA5019@bogus> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200206_221057_770323_33EA7414 X-CRM114-Status: GOOD ( 11.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, devicetree-owner@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson , Stephen Boyd , Andy Gross , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Bjorn Andersson , Matthias Kaehlcke , Guenter Roeck Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On 2020-02-07 00:08, Rob Herring wrote: > On Sat, Feb 01, 2020 at 08:59:49PM +0530, Sai Prakash Ranjan wrote: >> Add missing compatible for watchdog timer on QCS404, >> SC7180, SDM845 and SM8150 SoCs. > > That's not what the commit does. You are changing what's valid. > > One string was valid, now 2 are required. > Does this look good? diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml index 46d6aad5786a..3378244b67cd 100644 --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml @@ -14,19 +14,22 @@ allOf: properties: compatible: - items: + oneOf: - enum: - qcom,apss-wdt-qcs404 - qcom,apss-wdt-sc7180 - qcom,apss-wdt-sdm845 - qcom,apss-wdt-sm8150 - - qcom,kpss-timer - - qcom,kpss-wdt - qcom,kpss-wdt-apq8064 - qcom,kpss-wdt-ipq4019 - qcom,kpss-wdt-ipq8064 - qcom,kpss-wdt-msm8960 + - qcom,kpss-timer + - qcom,kpss-wdt - qcom,scss-timer + - const: qcom,kpss-timer + - const: qcom,kpss-wdt + - const: qcom,scss-timer reg: maxItems: 1 Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel