From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F23DBC433EF for ; Mon, 2 May 2022 18:54:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 392AC83E3A; Mon, 2 May 2022 20:54:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="D+QNI+fx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C436E8186D; Mon, 2 May 2022 20:54:14 +0200 (CEST) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 562B883E3A for ; Mon, 2 May 2022 20:54:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=daniel.schwierzeck@gmail.com Received: by mail-ej1-x62a.google.com with SMTP id i19so29371628eja.11 for ; Mon, 02 May 2022 11:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=DF/WRrB+HV9GJmc3HzYkTatqkk1XfJJic61KVAewdhI=; b=D+QNI+fxN2PH1aO+mytIkpQm68e333PPob4mpIuWX7Pg8gzXYAJOpSnxuA8comhgKZ c2dgDIlPqnqYKzM2hRT3HxwRX9slyDPkQwaKQYVEWCCNHvvZP8I976rI3hLvsEeGPw3q 341UCAmhDb/rSPcvl2U1ZHB/Miffq4sN8keKdCqNInMlXGr34iqYAkYCknKcI4md6aKB HY7gv9THwHJqmWCRf9dknfCfSgLDk3q63qlmxMfLQ/u0BsxiHgJrt9VzifNXJ47+0u2p h/BPGxr2V/ivGKo0tPCErW/jrZJEZBKUDoM/VRhNxN77UIxpqrtMP0GuXgpBMu3G5k66 E+Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=DF/WRrB+HV9GJmc3HzYkTatqkk1XfJJic61KVAewdhI=; b=KH8cTfxuaHlldSox6wZktyLD48e8OtBsuFXJYy6VbYrgUFr1MxMfrnjucnp9Hf7+yO yU/EiIhXzpIbggOyEs45TmGQF/e0Idu2GyyScTJT+KKuVLVOUCs5t9LqbjYFRWT7kO6W zHjb57oSG2FUETeL8uRivkizDJtkWD6Vj709nWEnLMXQlGrWVsaYM/1FGyntg/nRKJRb 7rZFoCcZowmJ3c9dl1GJYX42DL8tWyqrYjsasi74ytWverUELTD4kkUK33qIBZoA+upy RNWKm3geys2V/W+7D4VyXLbdd9O6JbZGyDfZavDYCfd73iv3sOkVCQ8rQua2Net951j9 7G/A== X-Gm-Message-State: AOAM5332LJrRurbySl4xwYMCGIb5cReGK9I3mY8SGgP7Y1/Y0xhQAsL1 zJeA/B/gT9XTMTnezUjQOlQ= X-Google-Smtp-Source: ABdhPJyCYTQEU/9xkaMW22q+2dxRoueTZTuVC4M9d6sbbqHyN6h109P2V4HQwsyLpz6m1eB0RX/PQQ== X-Received: by 2002:a17:907:72ce:b0:6f4:5a57:320c with SMTP id du14-20020a17090772ce00b006f45a57320cmr4743503ejc.75.1651517650790; Mon, 02 May 2022 11:54:10 -0700 (PDT) Received: from [192.168.10.30] (i5E860415.versanet.de. [94.134.4.21]) by smtp.gmail.com with ESMTPSA id de9-20020a1709069bc900b006f3ef214db3sm3829826ejc.25.2022.05.02.11.54.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 11:54:09 -0700 (PDT) Message-ID: Date: Mon, 2 May 2022 20:54:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 00/52] mips: octeon: Add ethernet support Content-Language: en-US To: Stefan Roese , u-boot@lists.denx.de Cc: awilliams@marvell.com, cchavva@marvell.com References: <20220407071154.51997-1-sr@denx.de> From: Daniel Schwierzeck In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Stefan, Am 02.05.22 um 18:00 schrieb Stefan Roese: > Hi Daniel, > > On 07.04.22 09:11, Stefan Roese wrote: >> This patchset adds the networking files and drivers including device >> helper headers and C files. Please excuse the massive amount of files >> in this patch series. Also the sometimes huge files (mostly headers >> with register definitions) that I needed to include. >> >> The infrastructure code with all the headers is ported mistly without >> any intended functional changes from the 2013 Cavium / Marvell U-Boot >> version. It has undergone many hours of extensive code cleanup and >> reformatting. Some of it done by using tools (checkpatch, Lindent, clang >> format etc) and also some of it done manually, as I couldn't find some >> tools that could do the needed work in a reliable and functional way. >> The result is that checkpatch now only throws a "few" warnings that are >> left. Some of those can't be removed without an even more extensive >> cleanup / rewrite of the code, like the addition of typedefs. >> >> The added header, helper and infrastructure files in the first part of >> the patch-series (patches 1-43) are the foundation, that is used by the >> main Octeon U-Boot ethernet driver (patch 50/52). Patches 47-49 add the >> DT nodes and properties to the corresponding dtsi / dts files. Patches >> 51 & 52 finally enable the ethernet support both MIPS Octeon boards, >> EBB7304 & NIC23. >> >> All this is tested on the 2 Cavium / Marvell MIPS Octeon boards: >> EBB7304 & NIC23 >> >> This patchset including the small Marvell PHY patches is available in >> this gitlab branch: >> >> https://source.denx.de/u-boot/custodians/u-boot-marvell/-/tree/mips-octeon-ethernet-v2-2022-04-07 >> >> >> Changes in v2: >> - As suggested by Daniel, remove all unreferenced functions from the >> source >>    code by manually inspecting u-boot.map [1] >> - Rebased on latest TOT >> >> [1] Here the diffstat comarison between v1 and v2: >> v1:  77 files changed, 42315 insertions(+), 586 deletions(-) >> v2:  78 files changed, 33672 insertions(+), 2524 deletions(-) >> >> Thanks, >> Stefan > > Daniel, do you have any comments on this patchset? Tom has assigned it > to me in patchwork and I would really like to get it merged into > mainline, if possible. So if you don't have any obejctions, then I > would pull it via the Marvell tree soon. > for the parts that I can reasonably review, I don't have any objections. I'd be happy if you pull it yourself as I'm currently really busy ;) -- - Daniel