On 04/26/2017 07:53 AM, Zihan Yang wrote: > Currently, the console_exit function in sclpconsole-lm.c and sclpconsole.c > does nothing, so remove them and convert the callback in SCLPEventClass to > void. Since there is a NULL check on the DeviceClass exit callback as > suggested by Frederic Konrad, it should be safe to remove them. When sending a patch series, please be sure to include a 0/5 cover letter, to make it easier on automated tooling that processes the list. You can use 'git config format.coverletter auto' to make it easier to remember this for patches created by 'git format-patch'/'git send-email'. More submission hints at: http://wiki.qemu.org/Contribute/SubmitAPatch -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org