From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] xen/tasklet: Fix return value truncation on arm64
Date: Sun, 14 Apr 2019 17:16:34 +0100 [thread overview]
Message-ID: <f27e5cf1-3928-808b-dda4-ae8acaa23c2b@arm.com> (raw)
In-Reply-To: <5CB073940200007800226D98@prv1-mh.provo.novell.com>
Hi,
On 4/12/19 12:16 PM, Jan Beulich wrote:
>>>> On 11.04.19 at 15:25, <andrew.cooper3@citrix.com> wrote:
>> The use of return_reg() assumes ARM's 32bit ABI. Therefore, a failure such as
>> -EINVAL will appear as a large positive number near 4 billion to a 64bit ARM
>> guest which happens to use continue_hypercall_on_cpu().
>>
>> Introduce a new arch_hypercall_tasklet_result() hook which is implemented by
>> both architectures, and drop the return_reg() macros. This logic will be
>> extended in a later change to make continuations out of the tasklet work.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> On the assumption that simply fixing Arm's return_reg() would
> not suffice with your further plans
I would definitely prefer to keep a static inline function unless there
are plan to make arch_hypercall_tasklet_result more complex.
Andrew, could you enlighten us on your plans?
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-04-14 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 13:25 [PATCH] xen/tasklet: Fix return value truncation on arm64 Andrew Cooper
2019-04-12 11:16 ` Jan Beulich
2019-04-14 16:16 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f27e5cf1-3928-808b-dda4-ae8acaa23c2b@arm.com \
--to=julien.grall@arm.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.