All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: damenly.su@gmail.com, linux-btrfs@vger.kernel.org
Cc: Su Yue <Damenly_Su@gmx.com>
Subject: Re: [PATCH 0/6] btrfs: metadata uuid fixes and enhancements
Date: Fri, 13 Dec 2019 10:03:50 +0200	[thread overview]
Message-ID: <f2a44405-9f5a-cf39-7f5b-149f160b65a6@suse.com> (raw)
In-Reply-To: <20191212110132.11063-1-Damenly_Su@gmx.com>



On 12.12.19 г. 13:01 ч., damenly.su@gmail.com wrote:
> From: Su Yue <Damenly_Su@gmx.com>
> 
> This patchset fixes one reproducible bug and add two split-brain
> cases ignored.
> 
> The origin code thinks the final state of successful synced device is
> always has INCOMPAT_METADATA_UUID feature. However, a device without
> the feature flag can be the one pull into disk. This is what handled
> in the patchset. Test images are added in btrfs-progs part.
> 
> Patch[1] fixes a bug about wrong fsid copy.
> Patch[2] is for the later patches.
> Patch[3-5] add the forgotten cases.
> Patch[6] just does simple code movement for grace.
> 
> The set passes xfstests-dev without regressions.
> 
> Su Yue (6):
>   btrfs: metadata_uuid: fix failed assertion due to unsuccessful device
>     scan
>   btrfs: metadata_uuid: move split-brain handling from fs_id() to new
>     function
>   btrfs: split-brain case for scanned changing device with
>     INCOMPAT_METADATA_UUID
>   btrfs: split-brain case for scanned changed device without
>     INCOMPAT_METADATA_UUID
>   btrfs: copy fsid and metadata_uuid for pulled disk without
>     INCOMPAT_METADATA_UUID
>   btrfs: metadata_uuid: move partly logic into find_fsid_inprogress()
> 
>  fs/btrfs/volumes.c | 193 +++++++++++++++++++++++++++++----------------
>  1 file changed, 125 insertions(+), 68 deletions(-)
> 


I'm currently on holiday but the fsid change feature has a design
document here:
https://github.com/btrfs/btrfs-dev-docs/blob/master/fsid-change.txt

it lists all the cases I have handled. If you think there are other
please first describe them in prose following the parlance set out in
the document to ease reasoning.

  parent reply	other threads:[~2019-12-13  8:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 11:01 [PATCH 0/6] btrfs: metadata uuid fixes and enhancements damenly.su
2019-12-12 11:01 ` [PATCH 1/6] btrfs: metadata_uuid: fix failed assertion due to unsuccessful device scan damenly.su
2019-12-12 14:15   ` Nikolay Borisov
2019-12-13  2:30     ` Su Yue
2019-12-13  2:46     ` [PATCH 1/6] btrfs: metadata_uuid: fix failed assertion due to unsuccessful device scan (reformatted) Su Yue
2019-12-13  5:36       ` Anand Jain
2019-12-13  7:15         ` Su Yue
2019-12-13  8:51           ` Anand Jain
2019-12-13 10:10             ` Su Yue
2019-12-12 11:01 ` [PATCH 2/6] btrfs: metadata_uuid: move split-brain handling from fs_id() to new function damenly.su
2019-12-12 13:05   ` Nikolay Borisov
2019-12-12 13:32     ` Su Yue
2019-12-12 11:01 ` [PATCH 3/6] btrfs: split-brain case for scanned changing device with INCOMPAT_METADATA_UUID damenly.su
2019-12-12 13:24   ` Su Yue
2019-12-12 13:34   ` Nikolay Borisov
2019-12-12 14:19     ` Su Yue
2019-12-12 11:01 ` [PATCH 4/6] btrfs: split-brain case for scanned changed device without INCOMPAT_METADATA_UUID damenly.su
2019-12-12 11:01 ` [PATCH 5/6] btrfs: copy fsid and metadata_uuid for pulled disk " damenly.su
2020-01-06 15:12   ` Nikolay Borisov
2020-01-07  1:31     ` Su Yue
2020-01-07  7:18       ` Nikolay Borisov
2020-01-07  7:34         ` Su Yue
2019-12-12 11:01 ` [PATCH 6/6] btrfs: metadata_uuid: move partly logic into find_fsid_inprogress() damenly.su
2019-12-12 13:37   ` Nikolay Borisov
2019-12-13  8:03 ` Nikolay Borisov [this message]
2019-12-16  0:49   ` [PATCH 0/6] btrfs: metadata uuid fixes and enhancements Su Yue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2a44405-9f5a-cf39-7f5b-149f160b65a6@suse.com \
    --to=nborisov@suse.com \
    --cc=Damenly_Su@gmx.com \
    --cc=damenly.su@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.