All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Heiko Thiery <heiko.thiery@gmail.com>, buildroot@buildroot.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Michael Walle <michael@walle.cc>,
	Fabio Estevam <festevam@gmail.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	Frieder Schrempf <frieder.schrempf@kontron.de>
Subject: Re: [Buildroot] [PATCH v4] configs/kontron_bl_imx8mm_defconfig: new defconfig
Date: Thu, 20 Jan 2022 11:26:54 +0100	[thread overview]
Message-ID: <f2abb014-c4b0-f57a-f78e-fe6f86b4452d@benettiengineering.com> (raw)
In-Reply-To: <20220120091935.15035-1-heiko.thiery@gmail.com>

Hi Heiko, Frieder,

On 20/01/22 10:19, Heiko Thiery wrote:
> The BL i.MX8M Mini is a baseboard that includes the SoM SL i.MX8M Mini.
> 
> https://www.kontron.com/produkte/baseboard-bl-i.mx8m-mini/p158549
> 
> Cc: Frieder Schrempf <frieder.schrempf@kontron.de>
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> v4:
>   - remove BR2_ARM_FPU_VFPV3 since this option is not used for aarch64.
>     The FPU options are set implicit.
> 
> v3:
>   - change offset value to use capitol 'K' value (thanks Guilio)
>   - add info to uboot patches about submitting to upstream
> 
> v2:
>   - switch to extlinux
>   - directly call genimage.sh
>    - remove post-image.sh
>   - remove BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT
>   - add BR2_LINUX_KERNEL_DTB_KEEP_DIRNAME
> 
> 
>   DEVELOPERS                                    |   2 +
>   board/kontron/bl-imx8mm/extlinux.conf         |   4 +
>   board/kontron/bl-imx8mm/genimage.cfg          |  18 ++
>   ...m-kontron-n801x-s-convert-options-to.patch |  31 ++
>   ...m-kontron-n801x-s-add-common-board-u.patch | 305 ++++++++++++++++++
>   board/kontron/bl-imx8mm/post-build.sh         |   7 +
>   board/kontron/bl-imx8mm/readme.txt            |  85 +++++
>   configs/kontron_bl_imx8mm_defconfig           |  58 ++++
>   8 files changed, 510 insertions(+)
>   create mode 100644 board/kontron/bl-imx8mm/extlinux.conf
>   create mode 100644 board/kontron/bl-imx8mm/genimage.cfg
>   create mode 100644 board/kontron/bl-imx8mm/patches/uboot/0001-imx-imx8mm-imx8mm-kontron-n801x-s-convert-options-to.patch
>   create mode 100644 board/kontron/bl-imx8mm/patches/uboot/0002-imx-imx8mm-imx8mm-kontron-n801x-s-add-common-board-u.patch
>   create mode 100755 board/kontron/bl-imx8mm/post-build.sh
>   create mode 100644 board/kontron/bl-imx8mm/readme.txt
>   create mode 100644 configs/kontron_bl_imx8mm_defconfig
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index c0bfde69da..93c5760489 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1179,7 +1179,9 @@ F:	package/python-sip/
>   F:	package/uhd/
>   
>   N:	Heiko Thiery <heiko.thiery@gmail.com>
> +F:	board/kontron/bl-imx8mm/
>   F:	board/kontron/pitx-imx8m/
> +F:	configs/kontron_bl_imx8mm_defconfig
>   F:	configs/kontron_pitx_imx8m_defconfig
>   F:	package/altera-stapl/
>   F:	package/ipmitool/
> diff --git a/board/kontron/bl-imx8mm/extlinux.conf b/board/kontron/bl-imx8mm/extlinux.conf
> new file mode 100644
> index 0000000000..d38f7f81b7
> --- /dev/null
> +++ b/board/kontron/bl-imx8mm/extlinux.conf
> @@ -0,0 +1,4 @@
> +label buildroot
> +  kernel /boot/Image
> +  devicetree /boot/freescale/imx8mm-kontron-n801x-s.dtb
> +  append root=PARTUUID=%PARTUUID% rootwait rw
> diff --git a/board/kontron/bl-imx8mm/genimage.cfg b/board/kontron/bl-imx8mm/genimage.cfg
> new file mode 100644
> index 0000000000..c98bc4f150
> --- /dev/null
> +++ b/board/kontron/bl-imx8mm/genimage.cfg
> @@ -0,0 +1,18 @@
> +image sdcard.img {
> +	hdimage {
> +		partition-table-type = "gpt"
> +		gpt-location = 16K
> +	}
> +
> +	partition imx-boot {
> +		in-partition-table = "no"
> +		image = "flash.bin"
> +		offset = 33K
> +	}
> +
> +	partition rootfs {
> +		image = "rootfs.ext4"
> +		offset = 8M
> +		partition-uuid = %PARTUUID%
> +	}
> +}
> diff --git a/board/kontron/bl-imx8mm/patches/uboot/0001-imx-imx8mm-imx8mm-kontron-n801x-s-convert-options-to.patch b/board/kontron/bl-imx8mm/patches/uboot/0001-imx-imx8mm-imx8mm-kontron-n801x-s-convert-options-to.patch
> new file mode 100644
> index 0000000000..6d76282def
> --- /dev/null
> +++ b/board/kontron/bl-imx8mm/patches/uboot/0001-imx-imx8mm-imx8mm-kontron-n801x-s-convert-options-to.patch
> @@ -0,0 +1,31 @@
> +From 95a311af81cd47c44d3d6e3f717f06a06d8f3dfd Mon Sep 17 00:00:00 2001
> +From: Heiko Thiery <heiko.thiery@gmail.com>
> +Date: Mon, 10 Jan 2022 14:13:02 +0100
> +Subject: [PATCH 1/2] imx: imx8mm: imx8mm-kontron-n801x-s: convert options to Kconfig
> +
> +CONFIG_SPL_MMC and CONFIG_SPL_SERIAL
> +
> +Patch submitted upstream:
> +https://patchwork.ozlabs.org/project/uboot/patch/20220112085755.7396-1-heiko.thiery@gmail.com/
> +
> +Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> +---
> + configs/kontron-sl-mx8mm_defconfig | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/configs/kontron-sl-mx8mm_defconfig b/configs/kontron-sl-mx8mm_defconfig
> +index 35d12fca32..940bf07a92 100644
> +--- a/configs/kontron-sl-mx8mm_defconfig
> ++++ b/configs/kontron-sl-mx8mm_defconfig
> +@@ -15,6 +15,8 @@ CONFIG_SPL_DM_SPI=y
> + CONFIG_DEFAULT_DEVICE_TREE="imx8mm-kontron-n801x-s"
> + CONFIG_SPL_TEXT_BASE=0x7E1000
> + CONFIG_TARGET_KONTRON_MX8MM=y
> ++CONFIG_SPL_MMC=y
> ++CONFIG_SPL_SERIAL=y
> + CONFIG_BOOTCOUNT_BOOTLIMIT=3
> + CONFIG_SPL=y
> + CONFIG_DISTRO_DEFAULTS=y
> +--
> +2.30.2
> +
> diff --git a/board/kontron/bl-imx8mm/patches/uboot/0002-imx-imx8mm-imx8mm-kontron-n801x-s-add-common-board-u.patch b/board/kontron/bl-imx8mm/patches/uboot/0002-imx-imx8mm-imx8mm-kontron-n801x-s-add-common-board-u.patch
> new file mode 100644
> index 0000000000..a88d7aba87
> --- /dev/null
> +++ b/board/kontron/bl-imx8mm/patches/uboot/0002-imx-imx8mm-imx8mm-kontron-n801x-s-add-common-board-u.patch
> @@ -0,0 +1,305 @@
> +From ef694c19c074333fd16589ec6ffef3e7ca895186 Mon Sep 17 00:00:00 2001
> +From: Heiko Thiery <heiko.thiery@gmail.com>
> +Date: Wed, 12 Jan 2022 08:44:36 +0100
> +Subject: [PATCH 2/2] imx: imx8mm: imx8mm-kontron-n801x-s: add common board
> + u-boot.dtsi
> +
> +When using a board variant that selects the lvds specific dtb the
> +*.u-boot.dtsi file will not be included. To have a lvds dtb specific
> +u-boot.dtsi file move this part to a common board u-boot.dtsi file and
> +include this in the board base u-boot.dtsi and create an additional one
> +for the lvds variant.
> +
> +Patch submitted upstream:
> +https://patchwork.ozlabs.org/project/uboot/patch/20220112085755.7396-2-heiko.thiery@gmail.com/
> +
> +Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> +---
> + .../imx8mm-kontron-n801x-s-lvds-u-boot.dtsi   |   6 +
> + .../dts/imx8mm-kontron-n801x-s-u-boot.dtsi    | 124 +----------------
> + arch/arm/dts/imx8mm-kontron-n801x-u-boot.dtsi | 128 ++++++++++++++++++
> + 3 files changed, 135 insertions(+), 123 deletions(-)
> + create mode 100644 arch/arm/dts/imx8mm-kontron-n801x-s-lvds-u-boot.dtsi
> + create mode 100644 arch/arm/dts/imx8mm-kontron-n801x-u-boot.dtsi
> +
> +diff --git a/arch/arm/dts/imx8mm-kontron-n801x-s-lvds-u-boot.dtsi b/arch/arm/dts/imx8mm-kontron-n801x-s-lvds-u-boot.dtsi
> +new file mode 100644
> +index 0000000000..4bf75722bf
> +--- /dev/null
> ++++ b/arch/arm/dts/imx8mm-kontron-n801x-s-lvds-u-boot.dtsi
> +@@ -0,0 +1,6 @@
> ++// SPDX-License-Identifier: GPL-2.0+
> ++/*
> ++ * Copyright (C) 2019 Kontron Electronics GmbH
> ++ */
> ++
> ++#include "imx8mm-kontron-n801x-u-boot.dtsi"
> +diff --git a/arch/arm/dts/imx8mm-kontron-n801x-s-u-boot.dtsi b/arch/arm/dts/imx8mm-kontron-n801x-s-u-boot.dtsi
> +index 22d18e6f1c..4bf75722bf 100644
> +--- a/arch/arm/dts/imx8mm-kontron-n801x-s-u-boot.dtsi
> ++++ b/arch/arm/dts/imx8mm-kontron-n801x-s-u-boot.dtsi
> +@@ -3,126 +3,4 @@
> +  * Copyright (C) 2019 Kontron Electronics GmbH
> +  */
> +
> +-#include "imx8mm-u-boot.dtsi"
> +-
> +-/ {
> +-	aliases {
> +-		usb0 = &usbotg1;
> +-		usb1 = &usbotg2;
> +-	};
> +-
> +-	wdt-reboot {
> +-		compatible = "wdt-reboot";
> +-		wdt = <&wdog1>;
> +-		u-boot,dm-spl;
> +-	};
> +-
> +-	firmware {
> +-		optee {
> +-			compatible = "linaro,optee-tz";
> +-			method = "smc";
> +-		};
> +-	};
> +-};
> +-
> +-&fec1 {
> +-	phy-mode = "rgmii-rxid";
> +-};
> +-
> +-&i2c1 {
> +-	u-boot,dm-spl;
> +-	u-boot,dm-pre-reloc;
> +-};
> +-
> +-&i2c2 {
> +-	status = "okay";
> +-	u-boot,dm-spl;
> +-	u-boot,dm-pre-reloc;
> +-};
> +-
> +-&pinctrl_ecspi1 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&pinctrl_i2c1 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&pinctrl_pmic {
> +-	u-boot,dm-spl;
> +-	fsl,pins = <
> +-		MX8MM_IOMUXC_GPIO1_IO00_GPIO1_IO0		0x141
> +-		/* Disable Pullup for SD_VSEL */
> +-		MX8MM_IOMUXC_GPIO1_IO04_GPIO1_IO4		0x41
> +-	>;
> +-};
> +-
> +-&pinctrl_uart3 {
> +-	u-boot,dm-spl;
> +-	u-boot,dm-pre-reloc;
> +-};
> +-
> +-&pinctrl_usdhc1 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&pinctrl_usdhc1_100mhz {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&pinctrl_usdhc1_200mhz {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&pinctrl_usdhc2 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&pca9450 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&{/soc@0/bus@30800000/i2c@30a20000/pmic@25/regulators} {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&ecspi1 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&gpio1 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&gpio2 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&gpio3 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&gpio4 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&gpio5 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&uart3 {
> +-	u-boot,dm-spl;
> +-	u-boot,dm-pre-reloc;
> +-};
> +-
> +-&usdhc1 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&usdhc2 {
> +-	u-boot,dm-spl;
> +-};
> +-
> +-&wdog1 {
> +-	u-boot,dm-spl;
> +-};
> ++#include "imx8mm-kontron-n801x-u-boot.dtsi"
> +diff --git a/arch/arm/dts/imx8mm-kontron-n801x-u-boot.dtsi b/arch/arm/dts/imx8mm-kontron-n801x-u-boot.dtsi
> +new file mode 100644
> +index 0000000000..22d18e6f1c
> +--- /dev/null
> ++++ b/arch/arm/dts/imx8mm-kontron-n801x-u-boot.dtsi
> +@@ -0,0 +1,128 @@
> ++// SPDX-License-Identifier: GPL-2.0+
> ++/*
> ++ * Copyright (C) 2019 Kontron Electronics GmbH
> ++ */
> ++
> ++#include "imx8mm-u-boot.dtsi"
> ++
> ++/ {
> ++	aliases {
> ++		usb0 = &usbotg1;
> ++		usb1 = &usbotg2;
> ++	};
> ++
> ++	wdt-reboot {
> ++		compatible = "wdt-reboot";
> ++		wdt = <&wdog1>;
> ++		u-boot,dm-spl;
> ++	};
> ++
> ++	firmware {
> ++		optee {
> ++			compatible = "linaro,optee-tz";
> ++			method = "smc";
> ++		};
> ++	};
> ++};
> ++
> ++&fec1 {
> ++	phy-mode = "rgmii-rxid";
> ++};
> ++
> ++&i2c1 {
> ++	u-boot,dm-spl;
> ++	u-boot,dm-pre-reloc;
> ++};
> ++
> ++&i2c2 {
> ++	status = "okay";
> ++	u-boot,dm-spl;
> ++	u-boot,dm-pre-reloc;
> ++};

any findings for i2c1 and i2c2 nodes?
This is not mandatory to be accepted anyway.
I've successfully built it so:

Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-01-20 10:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-20  9:19 [Buildroot] [PATCH v4] configs/kontron_bl_imx8mm_defconfig: new defconfig Heiko Thiery
2022-01-20 10:26 ` Giulio Benetti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2abb014-c4b0-f57a-f78e-fe6f86b4452d@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=buildroot@buildroot.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=heiko.thiery@gmail.com \
    --cc=michael@walle.cc \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.