All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: [PATCH v4 33/33] media: Kconfig: don't use visible for device type select
Date: Tue, 31 Mar 2020 13:12:09 +0200	[thread overview]
Message-ID: <f2b8fb37e20e9d0a7f39f1709db9bf3c24348ea9.1585651678.git.mchehab+huawei@kernel.org> (raw)
In-Reply-To: <cover.1585651678.git.mchehab+huawei@kernel.org>

While making the menu invisible seemed a good idea, there's
a drawback: when the menu is not visible, it is not parsing
the "default" dependency.

So, instead, let's just avoid the items at the menu to be
prompted, by using the "prompt ... if" construction.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 drivers/media/Kconfig | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index 382366b8ab46..0972a42e7e0c 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -57,13 +57,13 @@ config MEDIA_SUBDRV_AUTOSELECT
 	  If unsure say Y.
 
 menu "Media device types"
-	visible if MEDIA_SUPPORT_FILTER
 
 #
 # Multimedia support - automatically enable V4L2 and DVB core
 #
 config MEDIA_CAMERA_SUPPORT
-	bool "Cameras and video grabbers"
+	bool
+	prompt "Cameras and video grabbers" if MEDIA_SUPPORT_FILTER
 	default y if !MEDIA_SUPPORT_FILTER
 	help
 	  Enable support for webcams and video grabbers.
@@ -71,7 +71,8 @@ config MEDIA_CAMERA_SUPPORT
 	  Say Y when you have a webcam or a video capture grabber board.
 
 config MEDIA_ANALOG_TV_SUPPORT
-	bool "Analog TV"
+	bool
+	prompt "Analog TV" if MEDIA_SUPPORT_FILTER
 	default y if !MEDIA_SUPPORT_FILTER
 	help
 	  Enable analog TV support.
@@ -79,7 +80,8 @@ config MEDIA_ANALOG_TV_SUPPORT
 	  Say Y when you have a board with analog TV support.
 
 config MEDIA_DIGITAL_TV_SUPPORT
-	bool "Digital TV"
+	bool
+	prompt "Digital TV" if MEDIA_SUPPORT_FILTER
 	default y if !MEDIA_SUPPORT_FILTER
 	help
 	  Enable digital TV support.
@@ -87,7 +89,8 @@ config MEDIA_DIGITAL_TV_SUPPORT
 	  Say Y when you have a board with digital TV support.
 
 config MEDIA_RADIO_SUPPORT
-	bool "AM/FM radio receivers/transmitters"
+	bool
+	prompt "AM/FM radio receivers/transmitters" if MEDIA_SUPPORT_FILTER
 	default y if !MEDIA_SUPPORT_FILTER
 	help
 	  Enable AM/FM radio support.
@@ -98,7 +101,8 @@ config MEDIA_RADIO_SUPPORT
 	  Say Y when you have a board with radio support.
 
 config MEDIA_SDR_SUPPORT
-	bool "Software defined radio"
+	bool
+	prompt "Software defined radio" if MEDIA_SUPPORT_FILTER
 	default y if !MEDIA_SUPPORT_FILTER
 	help
 	  Enable software defined radio support.
@@ -106,7 +110,8 @@ config MEDIA_SDR_SUPPORT
 	  Say Y when you have a software defined radio device.
 
 config MEDIA_CEC_SUPPORT
-	bool "HDMI CEC"
+	bool
+	prompt "HDMI CEC support" if MEDIA_SUPPORT_FILTER
 	default y if !MEDIA_SUPPORT_FILTER
 	help
 	  Enable support for HDMI CEC (Consumer Electronics Control),
@@ -116,7 +121,8 @@ config MEDIA_CEC_SUPPORT
 	  adapter that supports HDMI CEC.
 
 config MEDIA_PLATFORM_SUPPORT
-	bool "Platform-specific devices"
+	bool
+	prompt "Platform-specific devices" if MEDIA_SUPPORT_FILTER
 	default y if !MEDIA_SUPPORT_FILTER
 	help
 	  Enable support for complex cameras, codecs, and other hardware
@@ -129,7 +135,8 @@ config MEDIA_PLATFORM_SUPPORT
 	  Say Y when you want to be able so see such devices.
 
 config MEDIA_TEST_SUPPORT
-	bool "Test drivers"
+	bool
+	prompt "Test drivers" if MEDIA_SUPPORT_FILTER
 	default y if !MEDIA_SUPPORT_FILTER
 	help
 	  Those drivers should not be used on production Kernels, but
-- 
2.25.1


      parent reply	other threads:[~2020-03-31 11:12 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31 11:11 [PATCH v4 00/33] Media Kconfig menu reorg and improvements Mauro Carvalho Chehab
2020-03-31 11:11 ` Mauro Carvalho Chehab
2020-03-31 11:11 ` Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 01/33] media: dvb-usb: auto-select CYPRESS_FIRMWARE Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 02/33] media: Kconfig: add an option to filter in/out platform drivers Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 03/33] media: Kconfig: not all V4L2 platform drivers are for camera Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 04/33] media: pci: move VIDEO_PCI_SKELETON to a different Kconfig Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 05/33] media: Kconfig: update the MEDIA_SUPPORT help message Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 06/33] media: split test drivers from platform directory Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 07/33] media: Kconfig: move comment to siano include Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 08/33] media: Kconfig: move drivers-specific TTPCI_EEPROM Kconfig var Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 09/33] media: Kconfig: mode firewire comment to firewire/Kconfig Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 10/33] media: ddbridge: copy the dvb_dummy_fe driver to ddbridge Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 11/33] media: ddbridge-dummy_fe: do some vars and function renames Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 12/33] media: ddbridge: use the ddbridge's own dummy fe driver Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 13/33] media: Kconfig: mark other drivers as test drivers Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 14/33] media: Kconfig: simplify some dependencies Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 15/33] media: Kconfig: better support hybrid TV devices Mauro Carvalho Chehab
2020-04-01  3:20   ` kbuild test robot
2020-04-01  3:20     ` kbuild test robot
2020-03-31 11:11 ` [PATCH v4 16/33] media: Kconfig: fix selection for test drivers Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 17/33] media: add SPDX headers on Kconfig and Makefile files Mauro Carvalho Chehab
2020-03-31 11:11   ` Mauro Carvalho Chehab
2020-03-31 11:11   ` Mauro Carvalho Chehab
2020-03-31 11:11   ` Mauro Carvalho Chehab
2020-03-31 12:06   ` Laurent Pinchart
2020-03-31 12:06     ` Laurent Pinchart
2020-03-31 12:06     ` Laurent Pinchart
2020-03-31 12:22     ` Greg Kroah-Hartman
2020-03-31 12:22       ` Greg Kroah-Hartman
2020-03-31 12:22       ` Greg Kroah-Hartman
2020-03-31 12:39       ` Laurent Pinchart
2020-03-31 12:39         ` Laurent Pinchart
2020-03-31 12:39         ` Laurent Pinchart
2020-03-31 12:47         ` Greg Kroah-Hartman
2020-03-31 12:47           ` Greg Kroah-Hartman
2020-03-31 12:47           ` Greg Kroah-Hartman
2020-03-31 12:52           ` Laurent Pinchart
2020-03-31 12:52             ` Laurent Pinchart
2020-03-31 12:52             ` Laurent Pinchart
2020-03-31 15:49     ` SPDX headers - Was: " Mauro Carvalho Chehab
2020-03-31 15:49       ` Mauro Carvalho Chehab
2020-03-31 15:49       ` Mauro Carvalho Chehab
2020-03-31 15:49       ` Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 18/33] media: dvb-core: Kconfig: default to use dynamic minors Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 19/33] media: Kconfig files: use select for V4L2 subdevs and MC Mauro Carvalho Chehab
2020-03-31 11:11   ` Mauro Carvalho Chehab
2020-03-31 11:11   ` Mauro Carvalho Chehab
2020-03-31 11:11   ` Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 20/33] media: Kconfig: reorganize the drivers menu options Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 21/33] media: Kconfig: use a sub-menu to select supported devices Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 22/33] media: Kconfig: make filtering devices optional Mauro Carvalho Chehab
2020-03-31 11:11 ` [PATCH v4 23/33] media: Kconfig: warn if drivers are filtered Mauro Carvalho Chehab
2020-03-31 11:12 ` [PATCH v4 24/33] media: Kconfig: move CEC-specific options to cec/Kconfig Mauro Carvalho Chehab
2020-03-31 11:12 ` [PATCH v4 25/33] media: Kconfig: move DVB-specific options to dvb-core/Kconfig Mauro Carvalho Chehab
2020-03-31 11:12 ` [PATCH v4 26/33] media: Kconfig: move V4L2 subdev API to v4l2-core/Kconfig Mauro Carvalho Chehab
2020-03-31 11:12 ` [PATCH v4 27/33] media: Kconfig: move media controller core select to main Kconfig Mauro Carvalho Chehab
2020-03-31 11:12 ` [PATCH v4 28/33] media: Kconfig: place all options under a sub-menu Mauro Carvalho Chehab
2020-03-31 11:12 ` [PATCH v4 29/33] media: Kconfig: move the position of sub-driver autoselection Mauro Carvalho Chehab
2020-03-31 11:12 ` [PATCH v4 30/33] media: Kconfig: on !EMBEDDED && !EXPERT, enable driver filtering Mauro Carvalho Chehab
2020-03-31 11:12 ` [PATCH v4 31/33] media: Kconfig: Better organize the per-API options Mauro Carvalho Chehab
2020-03-31 11:12 ` [PATCH v4 32/33] media: i2c/Kconfig: reorganize items there Mauro Carvalho Chehab
2020-03-31 11:12 ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2b8fb37e20e9d0a7f39f1709db9bf3c24348ea9.1585651678.git.mchehab+huawei@kernel.org \
    --to=mchehab+huawei@kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.