All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Simon Horman <simon.horman@netronome.com>
Cc: David Miller <davem@davemloft.net>,
	eric.dumazet@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org,
	xiyou.wangcong@gmail.com
Subject: Re: [PATCH net-next v4 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch
Date: Mon, 24 Apr 2017 08:54:19 -0400	[thread overview]
Message-ID: <f2ca8953-ba18-3593-aaf2-13b474574147@mojatatu.com> (raw)
In-Reply-To: <20170424092754.GB25218@vergenet.net>

On 17-04-24 05:27 AM, Simon Horman wrote:
> On Fri, Apr 21, 2017 at 02:11:00PM -0400, Jamal Hadi Salim wrote:
>> On 17-04-21 12:12 PM, David Miller wrote:

>
> From my PoV, for #d user-space has to either get smart or fail.
>
> Creating new tc involved work in order to support the new feature.
> Part of that work would be a decision weather or not to provide
> compatibility for old kernel or to bail out gracefully.
>

But not that much work as is being ascribed now.
This is a big change to user space code. Are we planning to
change all netlink apps (everything in iproute2) to now discover
by testing whether their flags are accepted or not? One extra
crossing to the kernel just to test the waters.

I think there's a middle ground and see which idea takes off.
Refer to the last patch I sent which implements the idea below.

cheers,
jamal

>> There is a simpler approach that would work going forward.
>> How about letting the user choose their fate? Set something maybe
>> in the netlink header to tell the kernel "if you dont understand
>> something I am asking for - please ignore it and do what you can".
>> This would maintain current behavior but would force the user to
>> explicitly state so.
>>
>> cheers,
>> jamal
>>

  reply	other threads:[~2017-04-24 12:54 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 11:57 [PATCH net-next v4 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch Jamal Hadi Salim
2017-04-19 11:57 ` [PATCH net-next v4 2/2] net sched actions: add time filter for action dumping Jamal Hadi Salim
2017-04-19 12:53   ` Jiri Pirko
2017-04-19 13:11     ` Jamal Hadi Salim
2017-04-19 14:14       ` Jiri Pirko
2017-04-19 15:47         ` Jamal Hadi Salim
2017-04-19 15:55           ` Jiri Pirko
2017-04-19 12:36 ` [PATCH net-next v4 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch Jiri Pirko
2017-04-19 12:55   ` Roman Mashak
2017-04-19 13:05     ` Jiri Pirko
2017-04-19 13:03   ` Jamal Hadi Salim
2017-04-19 13:13     ` Jiri Pirko
2017-04-19 15:37       ` Jamal Hadi Salim
2017-04-19 15:54         ` Jiri Pirko
2017-04-19 16:07           ` Jamal Hadi Salim
2017-04-19 16:17             ` Jiri Pirko
2017-04-20 10:42               ` Jamal Hadi Salim
2017-04-20 11:35                 ` Jiri Pirko
2017-04-20 14:03                   ` Jamal Hadi Salim
2017-04-20 12:18                 ` Eric Dumazet
2017-04-20 13:27                   ` Jamal Hadi Salim
2017-04-20 15:50                     ` David Miller
2017-04-20 17:38                       ` Jamal Hadi Salim
2017-04-20 17:58                         ` David Miller
2017-04-21 10:36                           ` Jamal Hadi Salim
2017-04-21 14:51                             ` David Miller
2017-04-21 15:29                               ` Jamal Hadi Salim
2017-04-21 15:38                                 ` David Miller
2017-04-21 15:55                                   ` Jamal Hadi Salim
2017-04-21 16:01                                     ` Jamal Hadi Salim
2017-04-21 16:12                                       ` David Miller
2017-04-21 18:11                                         ` Jamal Hadi Salim
2017-04-22 11:30                                           ` Jamal Hadi Salim
2017-04-24  9:27                                           ` Simon Horman
2017-04-24 12:54                                             ` Jamal Hadi Salim [this message]
2017-04-21 16:11                                     ` David Miller
2017-04-20 15:23                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2ca8953-ba18-3593-aaf2-13b474574147@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=simon.horman@netronome.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.