All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de,
	Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>,
	Tien Fong Chee <tien.fong.chee@intel.com>
Subject: Re: [PATCH 1/1] arm: socfpga: Migrate CONFIG_HPS namespace to HPS
Date: Tue, 10 Aug 2021 22:53:02 +0200	[thread overview]
Message-ID: <f2cb6fb2-08b4-90e4-cd58-6b5f9916e143@denx.de> (raw)
In-Reply-To: <20210810204739.GN858@bill-the-cat>

On 8/10/21 10:47 PM, Tom Rini wrote:
> On Tue, Aug 10, 2021 at 10:11:08PM +0200, Marek Vasut wrote:
>> On 8/10/21 10:05 PM, Tom Rini wrote:
>>> None of the CONFIG_HPS namespace options are changed via the board
>>> config.h file, nor does it make sense to move them to Kconfig.  Rename
>>> these options to the HPS namespace instead.
>>>
>>> Cc: Marek Vasut <marex@denx.de>
>>> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>>> Cc: Tien Fong Chee <tien.fong.chee@intel.com>
>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>> ---
>>> Note, this patch is complete as the changes to the regex qts-filter.sh
>>> are such a long line that git send-email fails.  This patch was
>>> generated by:
>>> $ git grep -l CONFIG_HPS_ | xargs sed -i -e 's/CONFIG_HPS_/HPS_/g'
>>> and I will re-run that before applying.
>>
>> The problem is, it is the altera tools which generate all those CONFIG_*
>> symbols which are processed by the qts-filter.sh and placed into those qts/
>> board directories, so this patch breaks all that. You'd have to fix the
>> qts-filter to scrub the CONFIG_ prefixes first.
> 
> Or rather, ugh, are there out of tree tools we need to deal with here?
> Perhaps someone with the tools could pick up and v2 something tested if
> so as it'll probably be a bit tricky getting it all right.

See doc/README.socfpga . The out of tree tools generate board/bitstream 
specific input header files which you plug into the qts-filter.sh script 
, those files contain the CONFIG_* macros and those files get converted 
by the qts-filter.sh script into the output header files in 
board/*/qts/*.h . The output header files are what is used by U-Boot then.

  reply	other threads:[~2021-08-10 20:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 20:05 [PATCH 1/1] arm: socfpga: Migrate CONFIG_HPS namespace to HPS Tom Rini
2021-08-10 20:11 ` Marek Vasut
2021-08-10 20:28   ` Tom Rini
2021-08-10 20:47   ` Tom Rini
2021-08-10 20:53     ` Marek Vasut [this message]
2021-08-10 20:57       ` Tom Rini
2021-08-12  6:56         ` Chee, Tien Fong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2cb6fb2-08b4-90e4-cd58-6b5f9916e143@denx.de \
    --to=marex@denx.de \
    --cc=simon.k.r.goldschmidt@gmail.com \
    --cc=tien.fong.chee@intel.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.