From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5846FC19F2D for ; Tue, 9 Aug 2022 10:05:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241131AbiHIKFv (ORCPT ); Tue, 9 Aug 2022 06:05:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241412AbiHIKFq (ORCPT ); Tue, 9 Aug 2022 06:05:46 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8266B1EACC for ; Tue, 9 Aug 2022 03:05:45 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D63523A; Tue, 9 Aug 2022 03:05:46 -0700 (PDT) Received: from [10.57.74.141] (unknown [10.57.74.141]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 164653F67D; Tue, 9 Aug 2022 03:05:43 -0700 (PDT) Message-ID: Date: Tue, 9 Aug 2022 11:05:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/1] perf/arm-cmn: Add more bits to child node address offset field Content-Language: en-GB To: Ilkka Koskinen , Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@amperecomputing.com References: <20220808195455.79277-1-ilkka@os.amperecomputing.com> From: Robin Murphy In-Reply-To: <20220808195455.79277-1-ilkka@os.amperecomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-08-08 20:54, Ilkka Koskinen wrote: > CMN-600 uses bits [27:0] for child node address offset while bits [30:28] > are required to be zero. > > For CMN-650, the child node address offset field has been increased > to include bits [29:0] while leaving only bit 30 set to zero. > > Let's include the missing two bits and assume older implementations > comply with the spec and set bits [29:28] to 0. Ah, I don't think it ever even crossed my mind to look for changes here, but of course if the node regions have grown from 16KB to 64KB then it's only natural that offsets grow to match. I expect the CMN-700 config that we tested on internally would have been small enough for this not to make a difference. Thanks for the catch! Reviewed-by: Robin Murphy > Signed-off-by: Ilkka Koskinen > --- > > I have tested this patch on CMN-600 and CMN-650. > > drivers/perf/arm-cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > index 80d8309652a4..b80a9b74662b 100644 > --- a/drivers/perf/arm-cmn.c > +++ b/drivers/perf/arm-cmn.c > @@ -36,7 +36,7 @@ > #define CMN_CI_CHILD_COUNT GENMASK_ULL(15, 0) > #define CMN_CI_CHILD_PTR_OFFSET GENMASK_ULL(31, 16) > > -#define CMN_CHILD_NODE_ADDR GENMASK(27, 0) > +#define CMN_CHILD_NODE_ADDR GENMASK(29, 0) > #define CMN_CHILD_NODE_EXTERNAL BIT(31) > > #define CMN_MAX_DIMENSION 12 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C43EC19F2D for ; Tue, 9 Aug 2022 10:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eiFz+TTJKWa4PrnzACaKTsC9Db7Lx3oOYGr/AZtGnTE=; b=Cl+D/QAzgr0J45 TRLS46nrZ+khXWOLwRZLKqlOAuAcOpmFML6u1kvgpkEDG1Spfi+JuxMjjIg8pDIPMqfpIkBxhqQy5 QPImGWyP+7Vxp61anDwgj+vnDX3PT/WSAjJuJC6QQf7+gY7UOcZ3rVDEhTwyQyR1VhuOuKYyMZNaf Gb4xGR7WqMIzNv0/PjBO+Wd0a0hOTf0A41P1Cy9CZ6I/X3oWwtwEayy/JawF3rdrIWDyOBmJzWklz 2x19eGPlyH78SM8EM8Lyv2Yc0gjapM8tilZ89Jz9kLh72vpSQsGQ+ecBwH9CGkqxiJrd2nZJEdbsC /LcHVp4JQhn7JDSRtgwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLM7U-003Bwj-6o; Tue, 09 Aug 2022 10:05:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLM7Q-003Bv7-Qa for linux-arm-kernel@lists.infradead.org; Tue, 09 Aug 2022 10:05:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D63523A; Tue, 9 Aug 2022 03:05:46 -0700 (PDT) Received: from [10.57.74.141] (unknown [10.57.74.141]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 164653F67D; Tue, 9 Aug 2022 03:05:43 -0700 (PDT) Message-ID: Date: Tue, 9 Aug 2022 11:05:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/1] perf/arm-cmn: Add more bits to child node address offset field Content-Language: en-GB To: Ilkka Koskinen , Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@amperecomputing.com References: <20220808195455.79277-1-ilkka@os.amperecomputing.com> From: Robin Murphy In-Reply-To: <20220808195455.79277-1-ilkka@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220809_030548_939088_7908DE91 X-CRM114-Status: GOOD ( 17.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-08-08 20:54, Ilkka Koskinen wrote: > CMN-600 uses bits [27:0] for child node address offset while bits [30:28] > are required to be zero. > > For CMN-650, the child node address offset field has been increased > to include bits [29:0] while leaving only bit 30 set to zero. > > Let's include the missing two bits and assume older implementations > comply with the spec and set bits [29:28] to 0. Ah, I don't think it ever even crossed my mind to look for changes here, but of course if the node regions have grown from 16KB to 64KB then it's only natural that offsets grow to match. I expect the CMN-700 config that we tested on internally would have been small enough for this not to make a difference. Thanks for the catch! Reviewed-by: Robin Murphy > Signed-off-by: Ilkka Koskinen > --- > > I have tested this patch on CMN-600 and CMN-650. > > drivers/perf/arm-cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > index 80d8309652a4..b80a9b74662b 100644 > --- a/drivers/perf/arm-cmn.c > +++ b/drivers/perf/arm-cmn.c > @@ -36,7 +36,7 @@ > #define CMN_CI_CHILD_COUNT GENMASK_ULL(15, 0) > #define CMN_CI_CHILD_PTR_OFFSET GENMASK_ULL(31, 16) > > -#define CMN_CHILD_NODE_ADDR GENMASK(27, 0) > +#define CMN_CHILD_NODE_ADDR GENMASK(29, 0) > #define CMN_CHILD_NODE_EXTERNAL BIT(31) > > #define CMN_MAX_DIMENSION 12 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel