From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43939C4320A for ; Wed, 4 Aug 2021 15:39:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CC4160BD3 for ; Wed, 4 Aug 2021 15:39:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239128AbhHDPjs (ORCPT ); Wed, 4 Aug 2021 11:39:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239064AbhHDPjq (ORCPT ); Wed, 4 Aug 2021 11:39:46 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AEF7C061798 for ; Wed, 4 Aug 2021 08:39:33 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id q17-20020a17090a2e11b02901757deaf2c8so4202463pjd.0 for ; Wed, 04 Aug 2021 08:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9HvhKBIAckU62s2Uuatx7EBu63Q7v4yQnE6VGQx/1B8=; b=RXFWQwB0uXR3QN0OYi9F3PH/TF24Ek/4S5Hl5GykHL0A/xQCZgMrXoLhz/Eldmkl56 Kq//r6LQZnNPvm+lqNljCdysmpVjqoSCxBaxFgPEY6j9Ulym7/fgyd1V6N6AxkcZris7 2oRbJHWuwrqoMAazMJZnlr57T/i9GpDUDkdST+SviEoj47u7AOVgFDd/nJpa6y8dBwMN uu9hxu4eqUCuPlZjswQXcxFIS6WgjKMaI8bikSUxieMiKXJ6wTFkDEouGTsbCIhLmeCS Sq5okn2S44fBX1q0fnAAoTsnS/TqmGuB+KuYzhRIDoXum9/rEx+uUeD9GdRi1eIebURt Q9Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9HvhKBIAckU62s2Uuatx7EBu63Q7v4yQnE6VGQx/1B8=; b=VjlCJ7h01XgUVa7yXAk77qAgwUYuzDi/nb9oMHblaXlDcQRP5sNX58UamyfU8GwaSt Flr8ky8qF7DwXAPWMg2Ty179pWlwo0Y/xMFpj3m2bo//T48HU7uzefYApCKZrIXfUl4e dSnxf2NCs8dGYJFsS7z1l+MvohzQfnuQKPr8Ik3ismLzthcvaH5Ntze12e7xnlndo5F2 fqo5YYhcRYQuxQ5pIIG5SNjX0mN+69Sl+sVsYLdEvvSfQt1svjefzRi8aSrPM5CIJT7R aDE9TlwrpGwZP/seuunwMlKO6yxFyoFRu6KrXFRGKMuFmGYpD2RcJOVbzSWLTFVlvL49 fjHg== X-Gm-Message-State: AOAM532UxKYcW0Crx/qVJBvzSs50h2Z0Rd8uHuZZni6A6HjOFtnDb0sf oxSqMiNHQv4d35Ua/ujQFIMmbDVRLGLG5zyJ X-Google-Smtp-Source: ABdhPJwhyUlyEkVnqX8yuM7QqcstA/PNNT2jsrCxqQR3DMv0RG7ftFCD6gMMj42hfWrbvwwNCN+8vQ== X-Received: by 2002:a17:902:8544:b029:12c:5752:b0ef with SMTP id d4-20020a1709028544b029012c5752b0efmr23388086plo.18.1628091572841; Wed, 04 Aug 2021 08:39:32 -0700 (PDT) Received: from [192.168.1.116] ([198.8.77.61]) by smtp.gmail.com with ESMTPSA id y2sm3310366pfe.146.2021.08.04.08.39.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Aug 2021 08:39:32 -0700 (PDT) Subject: Re: [ANNOUNCE] v5.14-rc4-rt4 To: Sebastian Andrzej Siewior Cc: Peter Zijlstra , Daniel Wagner , Thomas Gleixner , LKML , linux-rt-users@vger.kernel.org, Steven Rostedt References: <20210802162750.santic4y6lzcet5c@linutronix.de> <20210804082418.fbibprcwtzyt5qax@beryllium.lan> <20210804104340.fhdjwn3hruymu3ml@linutronix.de> <20210804104803.4nwxi74sa2vwiujd@linutronix.de> <20210804110057.chsvt7l5xpw7bo5r@linutronix.de> <20210804131731.GG8057@worktop.programming.kicks-ass.net> <4f549344-1040-c677-6a6a-53e243c5f364@kernel.dk> <20210804153308.oasahcxjmcw7vivo@linutronix.de> From: Jens Axboe Message-ID: Date: Wed, 4 Aug 2021 09:39:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210804153308.oasahcxjmcw7vivo@linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/4/21 9:33 AM, Sebastian Andrzej Siewior wrote: > On 2021-08-04 08:23:55 [-0600], Jens Axboe wrote: >> Totally untested, but I think the principle is sound. I'll run it through >> some testing. > > This is needed: > > diff --git a/fs/io-wq.c b/fs/io-wq.c > index 1192ee2abd982..77ec6896edaa5 100644 > --- a/fs/io-wq.c > +++ b/fs/io-wq.c > @@ -428,9 +428,9 @@ static struct io_wq_work *io_get_next_work(struct io_wqe *wqe) > } > > if (stall_hash != -1U) { > - raw_spin_unlock(&wqe->lock); > + raw_spin_unlock_irq(&wqe->lock); > io_wait_on_hash(wqe, stall_hash); > - raw_spin_lock(&wqe->lock); > + raw_spin_lock_irq(&wqe->lock); > } > > return NULL; > > > otherwise the spinlock_t lock in io_wait_on_hash() is acquired with > disabled interrupts which is a no-no on -RT. > With that it all looks good as far as I can tell. > Thank you. I'm confused, the waitqueue locks are always IRQ disabling. -- Jens Axboe