Re: [Very RFC 03/46] powernv/pci: Remove dma_dev_setup() for NPU PHBs

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 20/11/2019 12:28, Oliver O'Halloran wrote:
> The pnv_pci_dma_dev_setup() only does something when:
> 
> 1) There PHB contains VFs, or
> 2) The PHB defines a dma_dev_setup() callback in the pnv_phb structure.
> 
> Neither is true for NPU PHBs, so don't set the callback in the pci_controller_ops.

True.


Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>




> 
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> ---
>  arch/powerpc/platforms/powernv/pci-ioda.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> index 65b5b121ebad..099c0bb1a9b9 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -3652,7 +3652,6 @@ static const struct pci_controller_ops pnv_pci_ioda_controller_ops = {
>  };
>  
>  static const struct pci_controller_ops pnv_npu_ioda_controller_ops = {
> -	.dma_dev_setup		= pnv_pci_dma_dev_setup,
>  	.setup_msi_irqs		= pnv_setup_msi_irqs,
>  	.teardown_msi_irqs	= pnv_teardown_msi_irqs,
>  	.enable_device_hook	= pnv_pci_enable_device_hook,
> 

-- 
Alexey