From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Reply-To: mimu@linux.ibm.com Subject: Re: [PATCH 01/10] virtio/s390: use vring_create_virtqueue References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-2-pasic@linux.ibm.com> <20190503111724.70c6ec37.cohuck@redhat.com> <20190503160421-mutt-send-email-mst@kernel.org> <20190504160340.29f17b98.pasic@linux.ibm.com> <20190505131523.159bec7c.cohuck@redhat.com> <20190510160744.00285367.cohuck@redhat.com> <20190512124730-mutt-send-email-mst@kernel.org> <20190513115227.1d316ec8.cohuck@redhat.com> From: Michael Mueller Date: Mon, 13 May 2019 14:27:35 +0200 MIME-Version: 1.0 In-Reply-To: <20190513115227.1d316ec8.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Cornelia Huck , "Michael S. Tsirkin" Cc: Christian Borntraeger , Halil Pasic , kvm@vger.kernel.org, linux-s390@vger.kernel.org, Martin Schwidefsky , Sebastian Ott , virtualization@lists.linux-foundation.org, Christoph Hellwig , Thomas Huth , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman List-ID: On 13.05.19 11:52, Cornelia Huck wrote: > On Sun, 12 May 2019 12:47:39 -0400 > "Michael S. Tsirkin" wrote: > >> On Fri, May 10, 2019 at 04:07:44PM +0200, Cornelia Huck wrote: >>> On Tue, 7 May 2019 15:58:12 +0200 >>> Christian Borntraeger wrote: >>> >>>> On 05.05.19 13:15, Cornelia Huck wrote: >>>>> On Sat, 4 May 2019 16:03:40 +0200 >>>>> Halil Pasic wrote: >>>>> >>>>>> On Fri, 3 May 2019 16:04:48 -0400 >>>>>> "Michael S. Tsirkin" wrote: >>>>>> >>>>>>> On Fri, May 03, 2019 at 11:17:24AM +0200, Cornelia Huck wrote: >>>>>>>> On Fri, 26 Apr 2019 20:32:36 +0200 >>>>>>>> Halil Pasic wrote: >>>>>>>> >>>>>>>>> The commit 2a2d1382fe9d ("virtio: Add improved queue allocation API") >>>>>>>>> establishes a new way of allocating virtqueues (as a part of the effort >>>>>>>>> that taught DMA to virtio rings). >>>>>>>>> >>>>>>>>> In the future we will want virtio-ccw to use the DMA API as well. >>>>>>>>> >>>>>>>>> Let us switch from the legacy method of allocating virtqueues to >>>>>>>>> vring_create_virtqueue() as the first step into that direction. >>>>>>>>> >>>>>>>>> Signed-off-by: Halil Pasic >>>>>>>>> --- >>>>>>>>> drivers/s390/virtio/virtio_ccw.c | 30 +++++++++++------------------- >>>>>>>>> 1 file changed, 11 insertions(+), 19 deletions(-) >>>>>>>> >>>>>>>> Reviewed-by: Cornelia Huck >>>>>>>> >>>>>>>> I'd vote for merging this patch right away for 5.2. >>>>>>> >>>>>>> So which tree is this going through? mine? >>>>>>> >>>>>> >>>>>> Christian, what do you think? If the whole series is supposed to go in >>>>>> in one go (which I hope it is), via Martin's tree could be the simplest >>>>>> route IMHO. >>>>> >>>>> >>>>> The first three patches are virtio(-ccw) only and the those are the ones >>>>> that I think are ready to go. >>>>> >>>>> I'm not feeling comfortable going forward with the remainder as it >>>>> stands now; waiting for some other folks to give feedback. (They are >>>>> touching/interacting with code parts I'm not so familiar with, and lack >>>>> of documentation, while not the developers' fault, does not make it >>>>> easier.) >>>>> >>>>> Michael, would you like to pick up 1-3 for your tree directly? That >>>>> looks like the easiest way. >>>> >>>> Agreed. Michael please pick 1-3. >>>> We will continue to review 4- first and then see which tree is best. >>> >>> Michael, please let me know if you'll pick directly or whether I should >>> post a series. >>> >>> [Given that the patches are from one virtio-ccw maintainer and reviewed >>> by the other, picking directly would eliminate an unnecessary >>> indirection :)] >> >> picked them > > Thanks! > Connie, if I get you right here, you don't need a v2 for the patches 1 through 3? Thanks, Michael From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Mueller Subject: Re: [PATCH 01/10] virtio/s390: use vring_create_virtqueue Date: Mon, 13 May 2019 14:27:35 +0200 Message-ID: References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-2-pasic@linux.ibm.com> <20190503111724.70c6ec37.cohuck@redhat.com> <20190503160421-mutt-send-email-mst@kernel.org> <20190504160340.29f17b98.pasic@linux.ibm.com> <20190505131523.159bec7c.cohuck@redhat.com> <20190510160744.00285367.cohuck@redhat.com> <20190512124730-mutt-send-email-mst@kernel.org> <20190513115227.1d316ec8.cohuck@redhat.com> Reply-To: mimu@linux.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190513115227.1d316ec8.cohuck@redhat.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Cornelia Huck , "Michael S. Tsirkin" Cc: Vasily Gorbik , linux-s390@vger.kernel.org, Thomas Huth , Claudio Imbrenda , kvm@vger.kernel.org, Sebastian Ott , Christoph Hellwig , Farhan Ali , Eric Farman , virtualization@lists.linux-foundation.org, Halil Pasic , Martin Schwidefsky , Viktor Mihajlovski , Janosch Frank List-Id: virtualization@lists.linuxfoundation.org On 13.05.19 11:52, Cornelia Huck wrote: > On Sun, 12 May 2019 12:47:39 -0400 > "Michael S. Tsirkin" wrote: > >> On Fri, May 10, 2019 at 04:07:44PM +0200, Cornelia Huck wrote: >>> On Tue, 7 May 2019 15:58:12 +0200 >>> Christian Borntraeger wrote: >>> >>>> On 05.05.19 13:15, Cornelia Huck wrote: >>>>> On Sat, 4 May 2019 16:03:40 +0200 >>>>> Halil Pasic wrote: >>>>> >>>>>> On Fri, 3 May 2019 16:04:48 -0400 >>>>>> "Michael S. Tsirkin" wrote: >>>>>> >>>>>>> On Fri, May 03, 2019 at 11:17:24AM +0200, Cornelia Huck wrote: >>>>>>>> On Fri, 26 Apr 2019 20:32:36 +0200 >>>>>>>> Halil Pasic wrote: >>>>>>>> >>>>>>>>> The commit 2a2d1382fe9d ("virtio: Add improved queue allocation API") >>>>>>>>> establishes a new way of allocating virtqueues (as a part of the effort >>>>>>>>> that taught DMA to virtio rings). >>>>>>>>> >>>>>>>>> In the future we will want virtio-ccw to use the DMA API as well. >>>>>>>>> >>>>>>>>> Let us switch from the legacy method of allocating virtqueues to >>>>>>>>> vring_create_virtqueue() as the first step into that direction. >>>>>>>>> >>>>>>>>> Signed-off-by: Halil Pasic >>>>>>>>> --- >>>>>>>>> drivers/s390/virtio/virtio_ccw.c | 30 +++++++++++------------------- >>>>>>>>> 1 file changed, 11 insertions(+), 19 deletions(-) >>>>>>>> >>>>>>>> Reviewed-by: Cornelia Huck >>>>>>>> >>>>>>>> I'd vote for merging this patch right away for 5.2. >>>>>>> >>>>>>> So which tree is this going through? mine? >>>>>>> >>>>>> >>>>>> Christian, what do you think? If the whole series is supposed to go in >>>>>> in one go (which I hope it is), via Martin's tree could be the simplest >>>>>> route IMHO. >>>>> >>>>> >>>>> The first three patches are virtio(-ccw) only and the those are the ones >>>>> that I think are ready to go. >>>>> >>>>> I'm not feeling comfortable going forward with the remainder as it >>>>> stands now; waiting for some other folks to give feedback. (They are >>>>> touching/interacting with code parts I'm not so familiar with, and lack >>>>> of documentation, while not the developers' fault, does not make it >>>>> easier.) >>>>> >>>>> Michael, would you like to pick up 1-3 for your tree directly? That >>>>> looks like the easiest way. >>>> >>>> Agreed. Michael please pick 1-3. >>>> We will continue to review 4- first and then see which tree is best. >>> >>> Michael, please let me know if you'll pick directly or whether I should >>> post a series. >>> >>> [Given that the patches are from one virtio-ccw maintainer and reviewed >>> by the other, picking directly would eliminate an unnecessary >>> indirection :)] >> >> picked them > > Thanks! > Connie, if I get you right here, you don't need a v2 for the patches 1 through 3? Thanks, Michael