From: Kathiravan T <quic_kathirav@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: <agross@kernel.org>, <konrad.dybcio@linaro.org>, <lee@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] arm64: dts: qcom: ipq5332: enable the download mode support
Date: Thu, 9 Feb 2023 20:34:41 +0530 [thread overview]
Message-ID: <f2ed9599-7d3a-600c-99f7-04f9962673f7@quicinc.com> (raw)
In-Reply-To: <20230208233650.fcgsfyz6aegjsing@ripper>
On 2/9/2023 5:06 AM, Bjorn Andersson wrote:
> On Mon, Jan 30, 2023 at 10:31:54PM +0530, Kathiravan T wrote:
>> Enable the support for download mode to collect the RAM dumps if
>> system crashes, to perform the post mortem analysis.
>>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> index 7f0ba2ec339c..6a1d0cc927ef 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> @@ -70,6 +70,7 @@
>> firmware {
>> scm {
>> compatible = "qcom,scm-ipq5332", "qcom,scm";
>> + qcom,dload-mode = <&tcsr 0x0>;
>> };
>> };
>>
>> @@ -142,6 +143,11 @@
>> <0>;
>> };
>>
>> + tcsr: syscon@193d100 {
>> + compatible = "qcom,tcsr-ipq5332", "syscon";
>> + reg = <0x0193d100 0x4>;
> Please map the entire TCSR_REGS here, and use qcom,dload-mode to encode
> the offset within this.
Sure, will fix it in V2.
>
> Thanks,
> Bjorn
>
>> + };
>> +
>> sdhc: mmc@7804000 {
>> compatible = "qcom,ipq5332-sdhci", "qcom,sdhci-msm-v5";
>> reg = <0x07804000 0x1000>, <0x07805000 0x1000>;
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2023-02-09 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 17:01 [PATCH 0/3] Add the download mode support for IPQ5332 Kathiravan T
2023-01-30 17:01 ` [PATCH 1/3] dt-bindings: mfd: qcom,tcsr: add compatible " Kathiravan T
2023-01-31 9:24 ` Lee Jones
2023-01-30 17:01 ` [PATCH 2/3] arm64: dts: qcom: ipq5332: enable the download mode support Kathiravan T
2023-02-08 23:36 ` Bjorn Andersson
2023-02-09 15:04 ` Kathiravan T [this message]
2023-01-30 17:01 ` [PATCH 3/3] arm64: dts: qcom: ipq5332: add SMEM support Kathiravan T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2ed9599-7d3a-600c-99f7-04f9962673f7@quicinc.com \
--to=quic_kathirav@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.