From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FFD9C43461 for ; Mon, 7 Sep 2020 17:18:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F659208C7 for ; Mon, 7 Sep 2020 17:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aHFvksQu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729705AbgIGRSb (ORCPT ); Mon, 7 Sep 2020 13:18:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729742AbgIGOBf (ORCPT ); Mon, 7 Sep 2020 10:01:35 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 527CAC061575 for ; Mon, 7 Sep 2020 07:01:21 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id j2so15928600wrx.7 for ; Mon, 07 Sep 2020 07:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3yqLenHCPoqZrIKpooufqqBwsVq0mXq7ilOpODhrUnI=; b=aHFvksQujTdggw97cyEMBUIDWbyNKKzTFEMugO4p2ZKgWzaTydXy9Awhl6X0DXWY58 oEaTk44UP3RMo+8METMNE9LRM/yLK270f/davU3IOuIDZkzDztCORSDiT/3B1o3z63mM GNuSQjSCgcizqtwaFxReW7iCTQ4i9cnK0M6akHPU2rDG/J/CDb9OoX85Pb0WxcH1L7Vc CG5ja5OFH/qo8deTEk7l8sE3n35cNYfdpyCzOi4bIXaYZ+vn4rcJxAg9j6pkvIQUBvES EXzE/0YJ69GWzrIjY5/s0sfLJE4iUWP1FrsNsQlb64hsqBKqrSnK9MIYMe7rE8RV2S33 3z2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3yqLenHCPoqZrIKpooufqqBwsVq0mXq7ilOpODhrUnI=; b=LQ7WL2kSiKpjFpshsNMOaAkrNr6j6fIyyLAQgqA2B4BWc288wkrKd3Ev//lmE15dAC UR1Con0yjX8+XXJ1NhGlvae7TGtrX/H4tdXtZ4bEZZ2p8flF03kaZwspMMgW/463WfYO Cfa7R5G2IwckOqzqCYI8cDrQotCF6HSjDPWVAd1wAPRcKCc7AaYmxk+zJpLIepo3OhE0 +AHpIdNedb+lRYA4L8/szePGf5+AYWMLYNXJP8jG8jiQaziPrLcW1SEjbqZlyrYzGxLR Ky6jZFyJXerKn0v6HjB9V3gdsQs4xpEVyH5gEwifH7wNzWc/Lyz4EU0ioW99C3FeE5Nl qqSA== X-Gm-Message-State: AOAM532mJfL0Fqlm+sqrYpkCzec/zRQwwiGYTmvTNpHqquPVVg5RGqBQ TrIsZ2W/nHHpNTqs+Vzxejj5Ng== X-Google-Smtp-Source: ABdhPJzoJcfLaxWjMwyLqCvhxjDEuDUMEwVpfFLq6Lmj6kj5U1a+91N5u3NhIyKL2eHHQzQcMpAthQ== X-Received: by 2002:adf:8405:: with SMTP id 5mr9299149wrf.143.1599487279925; Mon, 07 Sep 2020 07:01:19 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id s2sm18343294wrw.96.2020.09.07.07.01.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Sep 2020 07:01:19 -0700 (PDT) Subject: Re: [PATCH] misc: fastrpc: add ioctl for attaching to sensors pd To: Jonathan Marek , linux-arm-msm@vger.kernel.org Cc: Arnd Bergmann , Greg Kroah-Hartman , open list References: <20200901003300.11985-1-jonathan@marek.ca> <3f1f8ff1-cf23-ae2c-4cff-cdcce0b11e2e@marek.ca> From: Srinivas Kandagatla Message-ID: Date: Mon, 7 Sep 2020 15:01:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <3f1f8ff1-cf23-ae2c-4cff-cdcce0b11e2e@marek.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 07/09/2020 14:47, Jonathan Marek wrote: > On 9/7/20 8:36 AM, Srinivas Kandagatla wrote: >> >> >> On 01/09/2020 01:32, Jonathan Marek wrote: >>> -#define FASTRPC_IOCTL_MMAP              _IOWR('R', 6, struct >>> fastrpc_req_mmap) >>> -#define FASTRPC_IOCTL_MUNMAP            _IOWR('R', 7, struct >>> fastrpc_req_munmap) >>> +#define FASTRPC_IOCTL_MMAP        _IOWR('R', 6, struct >>> fastrpc_req_mmap) >>> +#define FASTRPC_IOCTL_MUNMAP        _IOWR('R', 7, struct >>> fastrpc_req_munmap) >> >> Looks like changes that do not belong to this patch! >> >> I wanted to try this patch on SM8250. >> How do you test attaching fastrpc to sensor core?, I mean which >> userspace lib/tool do you use? >> >> --srini >> > > I pushed my sdsprpcd implementation to github, which is responsible for > initializing the sensors, and uses this ioctl: > > https://github.com/flto/fastrpc Thanks!, I can take a look and see if I can try it out with linaro fastrpc library! > > Note: it uses my own WIP fastrpc "library" instead of the one from > linaro, I also have other related code, like a sensor client, and > cDSP/aDSP compute examples, but need to confirm that I can share them > > Also, the corresponding dts patch I sent has a problem, the label = > "dsps"; should be label = "sdsp"; (copied the "dsps" from downstream, > but upstream expects "sdsp"), will send a v2 later today. Also the dts patch will fail to apply as it is, as it seems me that you have based the patch after adding audio dts patch! --srini > >>> +#define FASTRPC_IOCTL_INIT_ATTACH_SNS    _IO('R', 8)