Re: [OE-core] [meta-oe][RFC PATCH 1/2] libdecor: initial add recipe

From: richard.purdie@linuxfoundation.org
To: Markus Volk <f_l_k@t-online.de>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [meta-oe][RFC PATCH 1/2] libdecor: initial add recipe
Date: Sun, 22 May 2022 10:24:45 +0100	[thread overview]
Message-ID: <f304f84a8bb4bd353898d54cf1378b5c0084498e.camel@linuxfoundation.org> (raw)
In-Reply-To: <1286dfdb-a0ac-67a7-a026-f95da89c35da@t-online.de>

On Sun, 2022-05-22 at 10:48 +0200, Markus Volk wrote:
> Those are valid objections and I wasn't happy with how invasive the 
> necessary changes were either. The reason I'm still working on it is 
> that I'd really like to have an alignment for native/target for libsdl2. 
> As it is, libsdl2-native unconditionally adds x11. From the perspective 
> that we eventually want to reach the point where wayland/x11 becomes an 
> either/or decision, I think that should be changed.

The background helps thanks. Keep in mind that:

a) users can change the default PACKAGECONFIG, even for the native
version only.

b) we have a general policy of trying to support most user's configs
with the default native configuration. This isn't always possible and
libsdl/mesa are particularly tricky as they reach further into the host
than almost any other component we have.

x11 on the host should be separately controlled to the target x11 since
I can imagine developers with it on the desktop but not their target
and the other way around too. As such I'm not sure the goal of making
them match is compatible with the other things OE-Core tries to do.

> I did some cleanup and it is much less invasive now. To align 
> native/target PACKAGECONFIG, only patches 1-3 are needed. 4-5 add 
> pipewire and libdecor and I added them just for completeness.

We should add the PACKAGECONFIG entries, that is straight forward. What
the defaults should be is a different question and trickier. If the
config is there, that should be easier for you though.

I'm actually personally roughly in favour of adding libdecor, I know
others are less inclined.

> 
> The patches are made for kirkstone because I have too many problems with 
> the poky master branch distracting me at the moment.

What kind of issues? :/ 

I did merge one of your simpler patches to master FWIW but that does
mean this series doesn't apply now which makes testing harder.

Cheers,

Richard