All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC
@ 2016-12-26  6:45 Prabhakar Kushwaha
  2016-12-26  7:29 ` Igor Grinberg
  2017-01-19 17:31 ` york sun
  0 siblings, 2 replies; 9+ messages in thread
From: Prabhakar Kushwaha @ 2016-12-26  6:45 UTC (permalink / raw)
  To: u-boot

Enable UUID and GPT partition support for NXP's ARM based SoCs
i.e. LS1012A, LS1021A, LS1043A, LS1046A and LS2080A.

Also enable DOS partition for LS1012AFRDM boards.

Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
 include/configs/ls1012afrdm.h | 5 +++++
 include/configs/ls1012aqds.h  | 4 ++++
 include/configs/ls1012ardb.h  | 4 ++++
 include/configs/ls1021aiot.h  | 3 +++
 include/configs/ls1021aqds.h  | 3 +++
 include/configs/ls1021atwr.h  | 3 +++
 include/configs/ls1043aqds.h  | 4 ++++
 include/configs/ls1043ardb.h  | 4 ++++
 include/configs/ls1046aqds.h  | 4 ++++
 include/configs/ls1046ardb.h  | 4 ++++
 include/configs/ls2080aqds.h  | 3 +++
 include/configs/ls2080ardb.h  | 3 +++
 12 files changed, 44 insertions(+)

diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
index f6f88e8..94f7460 100644
--- a/include/configs/ls1012afrdm.h
+++ b/include/configs/ls1012afrdm.h
@@ -42,6 +42,11 @@
 #define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS      2
 #endif
 
+#define CONFIG_DOS_PARTITION
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
+
 #define CONFIG_CMD_MEMINFO
 #define CONFIG_CMD_MEMTEST
 #define CONFIG_SYS_MEMTEST_START	0x80000000
diff --git a/include/configs/ls1012aqds.h b/include/configs/ls1012aqds.h
index 0cc1791..ec4b825 100644
--- a/include/configs/ls1012aqds.h
+++ b/include/configs/ls1012aqds.h
@@ -154,6 +154,10 @@
 #define CONFIG_SYS_SCSI_MAX_LUN			1
 #define CONFIG_SYS_SCSI_MAX_DEVICE		(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
 						CONFIG_SYS_SCSI_MAX_LUN)
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
+
 #define CONFIG_PCIE1		/* PCIE controller 1 */
 #define CONFIG_PCIE_LAYERSCAPE	/* Use common FSL Layerscape PCIe code */
 #define FSL_PCIE_COMPAT "fsl,ls1043a-pcie"
diff --git a/include/configs/ls1012ardb.h b/include/configs/ls1012ardb.h
index 15410dd..1e8cc45 100644
--- a/include/configs/ls1012ardb.h
+++ b/include/configs/ls1012ardb.h
@@ -67,6 +67,10 @@
 #define CONFIG_SYS_SCSI_MAX_LUN			1
 #define CONFIG_SYS_SCSI_MAX_DEVICE		(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
 						CONFIG_SYS_SCSI_MAX_LUN)
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
+
 #define CONFIG_PCIE1		/* PCIE controller 1 */
 #define CONFIG_PCIE_LAYERSCAPE	/* Use common FSL Layerscape PCIe code */
 #define FSL_PCIE_COMPAT "fsl,ls1043a-pcie"
diff --git a/include/configs/ls1021aiot.h b/include/configs/ls1021aiot.h
index 7af4bc4..a441022 100644
--- a/include/configs/ls1021aiot.h
+++ b/include/configs/ls1021aiot.h
@@ -180,6 +180,9 @@
 
 #define CONFIG_CMD_FAT
 #define CONFIG_DOS_PARTITION
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
 
 /* SPI */
 #if defined(CONFIG_QSPI_BOOT) || defined(CONFIG_SD_BOOT_QSPI)
diff --git a/include/configs/ls1021aqds.h b/include/configs/ls1021aqds.h
index 128da8a..86b42dd 100644
--- a/include/configs/ls1021aqds.h
+++ b/include/configs/ls1021aqds.h
@@ -398,6 +398,9 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_GENERIC_MMC
 
 #define CONFIG_DOS_PARTITION
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
 
 /* SPI */
 #if defined(CONFIG_QSPI_BOOT) || defined(CONFIG_SD_BOOT_QSPI)
diff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h
index 1458332..25bebc0 100644
--- a/include/configs/ls1021atwr.h
+++ b/include/configs/ls1021atwr.h
@@ -299,6 +299,9 @@
 #define CONFIG_GENERIC_MMC
 
 #define CONFIG_DOS_PARTITION
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
 
 /* SPI */
 #if defined(CONFIG_QSPI_BOOT) || defined(CONFIG_SD_BOOT_QSPI)
diff --git a/include/configs/ls1043aqds.h b/include/configs/ls1043aqds.h
index 561a05a..431c8f8 100644
--- a/include/configs/ls1043aqds.h
+++ b/include/configs/ls1043aqds.h
@@ -100,6 +100,10 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_DOS_PARTITION
 #define CONFIG_BOARD_LATE_INIT
 
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
+
 /* EEPROM */
 #define CONFIG_ID_EEPROM
 #define CONFIG_SYS_I2C_EEPROM_NXID
diff --git a/include/configs/ls1043ardb.h b/include/configs/ls1043ardb.h
index 71c26bd..36df331 100644
--- a/include/configs/ls1043ardb.h
+++ b/include/configs/ls1043ardb.h
@@ -310,6 +310,10 @@
 #define SCSI_DEV_ID  0x9170
 #define CONFIG_SCSI_DEV_LIST {SCSI_VEND_ID, SCSI_DEV_ID}
 
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
+
 #include <asm/fsl_secure_boot.h>
 
 #endif /* __LS1043ARDB_H__ */
diff --git a/include/configs/ls1046aqds.h b/include/configs/ls1046aqds.h
index 29e0aa5..3618a06 100644
--- a/include/configs/ls1046aqds.h
+++ b/include/configs/ls1046aqds.h
@@ -143,6 +143,10 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_DOS_PARTITION
 #define CONFIG_BOARD_LATE_INIT
 
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
+
 /* EEPROM */
 #define CONFIG_ID_EEPROM
 #define CONFIG_SYS_I2C_EEPROM_NXID
diff --git a/include/configs/ls1046ardb.h b/include/configs/ls1046ardb.h
index 2fe8fc1..42597ac 100644
--- a/include/configs/ls1046ardb.h
+++ b/include/configs/ls1046ardb.h
@@ -225,6 +225,10 @@
 #define CONFIG_SYS_SCSI_MAX_LUN			1
 #define CONFIG_SYS_SCSI_MAX_DEVICE		(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
 						CONFIG_SYS_SCSI_MAX_LUN)
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
+
 #define CONFIG_BOOTCOMMAND		"sf probe 0:0;sf read $kernel_load" \
 					"$kernel_start $kernel_size;" \
 					"bootm $kernel_load"
diff --git a/include/configs/ls2080aqds.h b/include/configs/ls2080aqds.h
index 838568f..b3872b5 100644
--- a/include/configs/ls2080aqds.h
+++ b/include/configs/ls2080aqds.h
@@ -63,6 +63,9 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_SYS_SCSI_MAX_LUN			1
 #define CONFIG_SYS_SCSI_MAX_DEVICE		(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
 						CONFIG_SYS_SCSI_MAX_LUN)
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
 
 /* undefined CONFIG_FSL_DDR_SYNC_REFRESH for simulator */
 
diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h
index 31df781..9ffb48c 100644
--- a/include/configs/ls2080ardb.h
+++ b/include/configs/ls2080ardb.h
@@ -71,6 +71,9 @@ unsigned long get_board_sys_clk(void);
 #define CONFIG_SYS_SCSI_MAX_LUN			1
 #define CONFIG_SYS_SCSI_MAX_DEVICE		(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
 						CONFIG_SYS_SCSI_MAX_LUN)
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_GPT
 
 /* undefined CONFIG_FSL_DDR_SYNC_REFRESH for simulator */
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC
  2016-12-26  6:45 [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC Prabhakar Kushwaha
@ 2016-12-26  7:29 ` Igor Grinberg
  2017-01-04 21:41   ` york sun
  2017-01-19 17:31 ` york sun
  1 sibling, 1 reply; 9+ messages in thread
From: Igor Grinberg @ 2016-12-26  7:29 UTC (permalink / raw)
  To: u-boot

Hi Prabhakar Kushwaha,

On 12/26/16 08:45, Prabhakar Kushwaha wrote:
> Enable UUID and GPT partition support for NXP's ARM based SoCs
> i.e. LS1012A, LS1021A, LS1043A, LS1046A and LS2080A.
> 
> Also enable DOS partition for LS1012AFRDM boards.
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
>  include/configs/ls1012afrdm.h | 5 +++++
>  include/configs/ls1012aqds.h  | 4 ++++
>  include/configs/ls1012ardb.h  | 4 ++++
>  include/configs/ls1021aiot.h  | 3 +++
>  include/configs/ls1021aqds.h  | 3 +++
>  include/configs/ls1021atwr.h  | 3 +++
>  include/configs/ls1043aqds.h  | 4 ++++
>  include/configs/ls1043ardb.h  | 4 ++++
>  include/configs/ls1046aqds.h  | 4 ++++
>  include/configs/ls1046ardb.h  | 4 ++++
>  include/configs/ls2080aqds.h  | 3 +++
>  include/configs/ls2080ardb.h  | 3 +++

I'm not sure this is the expected way today...

>  12 files changed, 44 insertions(+)
> 
> diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
> index f6f88e8..94f7460 100644
> --- a/include/configs/ls1012afrdm.h
> +++ b/include/configs/ls1012afrdm.h
> @@ -42,6 +42,11 @@
>  #define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS      2
>  #endif
>  
> +#define CONFIG_DOS_PARTITION
> +#define CONFIG_PARTITION_UUIDS
> +#define CONFIG_EFI_PARTITION
> +#define CONFIG_CMD_GPT
> +

These are the common (not board specific) things and I think today we expect
it to come through the Kconfig instead of the old config files.

[...]

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC
  2016-12-26  7:29 ` Igor Grinberg
@ 2017-01-04 21:41   ` york sun
  2017-01-05  9:51     ` Igor Grinberg
  0 siblings, 1 reply; 9+ messages in thread
From: york sun @ 2017-01-04 21:41 UTC (permalink / raw)
  To: u-boot

On 12/25/2016 11:29 PM, Igor Grinberg wrote:
> Hi Prabhakar Kushwaha,
>
> On 12/26/16 08:45, Prabhakar Kushwaha wrote:
>> Enable UUID and GPT partition support for NXP's ARM based SoCs
>> i.e. LS1012A, LS1021A, LS1043A, LS1046A and LS2080A.
>>
>> Also enable DOS partition for LS1012AFRDM boards.
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>> ---
>>  include/configs/ls1012afrdm.h | 5 +++++
>>  include/configs/ls1012aqds.h  | 4 ++++
>>  include/configs/ls1012ardb.h  | 4 ++++
>>  include/configs/ls1021aiot.h  | 3 +++
>>  include/configs/ls1021aqds.h  | 3 +++
>>  include/configs/ls1021atwr.h  | 3 +++
>>  include/configs/ls1043aqds.h  | 4 ++++
>>  include/configs/ls1043ardb.h  | 4 ++++
>>  include/configs/ls1046aqds.h  | 4 ++++
>>  include/configs/ls1046ardb.h  | 4 ++++
>>  include/configs/ls2080aqds.h  | 3 +++
>>  include/configs/ls2080ardb.h  | 3 +++
>
> I'm not sure this is the expected way today...
>
>>  12 files changed, 44 insertions(+)
>>
>> diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
>> index f6f88e8..94f7460 100644
>> --- a/include/configs/ls1012afrdm.h
>> +++ b/include/configs/ls1012afrdm.h
>> @@ -42,6 +42,11 @@
>>  #define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS      2
>>  #endif
>>
>> +#define CONFIG_DOS_PARTITION
>> +#define CONFIG_PARTITION_UUIDS
>> +#define CONFIG_EFI_PARTITION
>> +#define CONFIG_CMD_GPT
>> +
>
> These are the common (not board specific) things and I think today we expect
> it to come through the Kconfig instead of the old config files.

Igor,

They are not totally common. The board has to support the device. I 
would recommend to use Kconfig as well if such config is in Kconfig. 
However it is not the case here.

York

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC
  2017-01-04 21:41   ` york sun
@ 2017-01-05  9:51     ` Igor Grinberg
  2017-01-05 16:25       ` york sun
  0 siblings, 1 reply; 9+ messages in thread
From: Igor Grinberg @ 2017-01-05  9:51 UTC (permalink / raw)
  To: u-boot

On 01/04/17 23:41, york sun wrote:
> On 12/25/2016 11:29 PM, Igor Grinberg wrote:
>> Hi Prabhakar Kushwaha,
>>
>> On 12/26/16 08:45, Prabhakar Kushwaha wrote:
>>> Enable UUID and GPT partition support for NXP's ARM based SoCs
>>> i.e. LS1012A, LS1021A, LS1043A, LS1046A and LS2080A.
>>>
>>> Also enable DOS partition for LS1012AFRDM boards.
>>>
>>> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>>> ---
>>>  include/configs/ls1012afrdm.h | 5 +++++
>>>  include/configs/ls1012aqds.h  | 4 ++++
>>>  include/configs/ls1012ardb.h  | 4 ++++
>>>  include/configs/ls1021aiot.h  | 3 +++
>>>  include/configs/ls1021aqds.h  | 3 +++
>>>  include/configs/ls1021atwr.h  | 3 +++
>>>  include/configs/ls1043aqds.h  | 4 ++++
>>>  include/configs/ls1043ardb.h  | 4 ++++
>>>  include/configs/ls1046aqds.h  | 4 ++++
>>>  include/configs/ls1046ardb.h  | 4 ++++
>>>  include/configs/ls2080aqds.h  | 3 +++
>>>  include/configs/ls2080ardb.h  | 3 +++
>>
>> I'm not sure this is the expected way today...
>>
>>>  12 files changed, 44 insertions(+)
>>>
>>> diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
>>> index f6f88e8..94f7460 100644
>>> --- a/include/configs/ls1012afrdm.h
>>> +++ b/include/configs/ls1012afrdm.h
>>> @@ -42,6 +42,11 @@
>>>  #define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS      2
>>>  #endif
>>>
>>> +#define CONFIG_DOS_PARTITION
>>> +#define CONFIG_PARTITION_UUIDS
>>> +#define CONFIG_EFI_PARTITION
>>> +#define CONFIG_CMD_GPT
>>> +
>>
>> These are the common (not board specific) things and I think today we expect
>> it to come through the Kconfig instead of the old config files.
> 
> Igor,
> 
> They are not totally common. The board has to support the device. I 
> would recommend to use Kconfig as well if such config is in Kconfig. 
> However it is not the case here.

Right. They are not in Kconfig yet...
We are making efforts to move stuff to Kconfig.
Care to land a hand and move these ones to Kconfig?

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC
  2017-01-05  9:51     ` Igor Grinberg
@ 2017-01-05 16:25       ` york sun
  2017-01-05 18:08         ` Igor Grinberg
  0 siblings, 1 reply; 9+ messages in thread
From: york sun @ 2017-01-05 16:25 UTC (permalink / raw)
  To: u-boot

On 01/05/2017 01:51 AM, Igor Grinberg wrote:
> On 01/04/17 23:41, york sun wrote:
>> On 12/25/2016 11:29 PM, Igor Grinberg wrote:
>>> Hi Prabhakar Kushwaha,
>>>
>>> On 12/26/16 08:45, Prabhakar Kushwaha wrote:
>>>> Enable UUID and GPT partition support for NXP's ARM based SoCs
>>>> i.e. LS1012A, LS1021A, LS1043A, LS1046A and LS2080A.
>>>>
>>>> Also enable DOS partition for LS1012AFRDM boards.
>>>>
>>>> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>>>> ---
>>>>  include/configs/ls1012afrdm.h | 5 +++++
>>>>  include/configs/ls1012aqds.h  | 4 ++++
>>>>  include/configs/ls1012ardb.h  | 4 ++++
>>>>  include/configs/ls1021aiot.h  | 3 +++
>>>>  include/configs/ls1021aqds.h  | 3 +++
>>>>  include/configs/ls1021atwr.h  | 3 +++
>>>>  include/configs/ls1043aqds.h  | 4 ++++
>>>>  include/configs/ls1043ardb.h  | 4 ++++
>>>>  include/configs/ls1046aqds.h  | 4 ++++
>>>>  include/configs/ls1046ardb.h  | 4 ++++
>>>>  include/configs/ls2080aqds.h  | 3 +++
>>>>  include/configs/ls2080ardb.h  | 3 +++
>>>
>>> I'm not sure this is the expected way today...
>>>
>>>>  12 files changed, 44 insertions(+)
>>>>
>>>> diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
>>>> index f6f88e8..94f7460 100644
>>>> --- a/include/configs/ls1012afrdm.h
>>>> +++ b/include/configs/ls1012afrdm.h
>>>> @@ -42,6 +42,11 @@
>>>>  #define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS      2
>>>>  #endif
>>>>
>>>> +#define CONFIG_DOS_PARTITION
>>>> +#define CONFIG_PARTITION_UUIDS
>>>> +#define CONFIG_EFI_PARTITION
>>>> +#define CONFIG_CMD_GPT
>>>> +
>>>
>>> These are the common (not board specific) things and I think today we expect
>>> it to come through the Kconfig instead of the old config files.
>>
>> Igor,
>>
>> They are not totally common. The board has to support the device. I
>> would recommend to use Kconfig as well if such config is in Kconfig.
>> However it is not the case here.
>
> Right. They are not in Kconfig yet...
> We are making efforts to move stuff to Kconfig.
> Care to land a hand and move these ones to Kconfig?
>

Can't promise. I have been doing just that for powerpc. Still have many 
left.

York

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC
  2017-01-05 16:25       ` york sun
@ 2017-01-05 18:08         ` Igor Grinberg
  0 siblings, 0 replies; 9+ messages in thread
From: Igor Grinberg @ 2017-01-05 18:08 UTC (permalink / raw)
  To: u-boot

On 01/05/17 18:25, york sun wrote:
> On 01/05/2017 01:51 AM, Igor Grinberg wrote:
>> On 01/04/17 23:41, york sun wrote:
>>> On 12/25/2016 11:29 PM, Igor Grinberg wrote:
>>>> Hi Prabhakar Kushwaha,
>>>>
>>>> On 12/26/16 08:45, Prabhakar Kushwaha wrote:
>>>>> Enable UUID and GPT partition support for NXP's ARM based SoCs
>>>>> i.e. LS1012A, LS1021A, LS1043A, LS1046A and LS2080A.
>>>>>
>>>>> Also enable DOS partition for LS1012AFRDM boards.
>>>>>
>>>>> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>>>>> ---
>>>>>  include/configs/ls1012afrdm.h | 5 +++++
>>>>>  include/configs/ls1012aqds.h  | 4 ++++
>>>>>  include/configs/ls1012ardb.h  | 4 ++++
>>>>>  include/configs/ls1021aiot.h  | 3 +++
>>>>>  include/configs/ls1021aqds.h  | 3 +++
>>>>>  include/configs/ls1021atwr.h  | 3 +++
>>>>>  include/configs/ls1043aqds.h  | 4 ++++
>>>>>  include/configs/ls1043ardb.h  | 4 ++++
>>>>>  include/configs/ls1046aqds.h  | 4 ++++
>>>>>  include/configs/ls1046ardb.h  | 4 ++++
>>>>>  include/configs/ls2080aqds.h  | 3 +++
>>>>>  include/configs/ls2080ardb.h  | 3 +++
>>>>
>>>> I'm not sure this is the expected way today...
>>>>
>>>>>  12 files changed, 44 insertions(+)
>>>>>
>>>>> diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
>>>>> index f6f88e8..94f7460 100644
>>>>> --- a/include/configs/ls1012afrdm.h
>>>>> +++ b/include/configs/ls1012afrdm.h
>>>>> @@ -42,6 +42,11 @@
>>>>>  #define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS      2
>>>>>  #endif
>>>>>
>>>>> +#define CONFIG_DOS_PARTITION
>>>>> +#define CONFIG_PARTITION_UUIDS
>>>>> +#define CONFIG_EFI_PARTITION
>>>>> +#define CONFIG_CMD_GPT
>>>>> +
>>>>
>>>> These are the common (not board specific) things and I think today we expect
>>>> it to come through the Kconfig instead of the old config files.
>>>
>>> Igor,
>>>
>>> They are not totally common. The board has to support the device. I
>>> would recommend to use Kconfig as well if such config is in Kconfig.
>>> However it is not the case here.
>>
>> Right. They are not in Kconfig yet...
>> We are making efforts to move stuff to Kconfig.
>> Care to land a hand and move these ones to Kconfig?
>>
> 
> Can't promise. I have been doing just that for powerpc. Still have many 
> left.

Yeah, great job on those patches! Thanks!
I think it is still worth waiting instead of applying and moving afterwards...

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC
  2016-12-26  6:45 [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC Prabhakar Kushwaha
  2016-12-26  7:29 ` Igor Grinberg
@ 2017-01-19 17:31 ` york sun
  2017-01-23  9:40   ` Igor Grinberg
  1 sibling, 1 reply; 9+ messages in thread
From: york sun @ 2017-01-19 17:31 UTC (permalink / raw)
  To: u-boot

On 12/25/2016 10:45 PM, Prabhakar Kushwaha wrote:
> Enable UUID and GPT partition support for NXP's ARM based SoCs
> i.e. LS1012A, LS1021A, LS1043A, LS1046A and LS2080A.
>
> Also enable DOS partition for LS1012AFRDM boards.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---

Applied to fsl-qoriq master, awaiting upstream. Thanks.

York

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC
  2017-01-19 17:31 ` york sun
@ 2017-01-23  9:40   ` Igor Grinberg
  2017-01-23 14:28     ` Tom Rini
  0 siblings, 1 reply; 9+ messages in thread
From: Igor Grinberg @ 2017-01-23  9:40 UTC (permalink / raw)
  To: u-boot

On 01/19/17 19:31, york sun wrote:
> On 12/25/2016 10:45 PM, Prabhakar Kushwaha wrote:
>> Enable UUID and GPT partition support for NXP's ARM based SoCs
>> i.e. LS1012A, LS1021A, LS1043A, LS1046A and LS2080A.
>>
>> Also enable DOS partition for LS1012AFRDM boards.
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>> ---
> 
> Applied to fsl-qoriq master, awaiting upstream. Thanks.

Well, of course it is your call, but that's sad.
Why not request people to move things to Kconfig?

I would suggest removing these from scripts/config_whitelist.txt...


-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC
  2017-01-23  9:40   ` Igor Grinberg
@ 2017-01-23 14:28     ` Tom Rini
  0 siblings, 0 replies; 9+ messages in thread
From: Tom Rini @ 2017-01-23 14:28 UTC (permalink / raw)
  To: u-boot

On Mon, Jan 23, 2017 at 11:40:22AM +0200, Igor Grinberg wrote:
> On 01/19/17 19:31, york sun wrote:
> > On 12/25/2016 10:45 PM, Prabhakar Kushwaha wrote:
> >> Enable UUID and GPT partition support for NXP's ARM based SoCs
> >> i.e. LS1012A, LS1021A, LS1043A, LS1046A and LS2080A.
> >>
> >> Also enable DOS partition for LS1012AFRDM boards.
> >>
> >> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> >> ---
> > 
> > Applied to fsl-qoriq master, awaiting upstream. Thanks.
> 
> Well, of course it is your call, but that's sad.
> Why not request people to move things to Kconfig?
> 
> I would suggest removing these from scripts/config_whitelist.txt...

The problem with the partition table and related options is that it ends
up being a non-trivial conversion to do and remain size neutral.
Patrick, have you had a chance to look at your patch again?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170123/d7f4d096/attachment.sig>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-01-23 14:28 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-26  6:45 [U-Boot] [PATCH] arm: layerscape: Enable UUID & GPT partition for NXP's ARM SoC Prabhakar Kushwaha
2016-12-26  7:29 ` Igor Grinberg
2017-01-04 21:41   ` york sun
2017-01-05  9:51     ` Igor Grinberg
2017-01-05 16:25       ` york sun
2017-01-05 18:08         ` Igor Grinberg
2017-01-19 17:31 ` york sun
2017-01-23  9:40   ` Igor Grinberg
2017-01-23 14:28     ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.