From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next 6/7] net: systemport: Add support for WAKE_FILTER Date: Fri, 20 Jul 2018 02:34:51 -0700 Message-ID: References: <20180717153645.7500-1-f.fainelli@gmail.com> <20180717153645.7500-8-f.fainelli@gmail.com> <20180717161459.GG968@lunn.ch> <87910e9c-0783-98e9-eb44-ce85656912d8@gmail.com> <20180717164908.GI968@lunn.ch> <20180717170653.GK968@lunn.ch> <1eec25bd-2cc1-3fa7-08b5-fa4ab7c5e777@gmail.com> <20180719222510.GG12150@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linville@tuxdriver.com, davem@davemloft.net, vivien.didelot@savoirfairelinux.com To: Andrew Lunn Return-path: Received: from mail-wr1-f66.google.com ([209.85.221.66]:45258 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727243AbeGTKWS (ORCPT ); Fri, 20 Jul 2018 06:22:18 -0400 Received: by mail-wr1-f66.google.com with SMTP id t13-v6so1238145wrv.12 for ; Fri, 20 Jul 2018 02:34:54 -0700 (PDT) In-Reply-To: <20180719222510.GG12150@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/19/2018 03:25 PM, Andrew Lunn wrote: >> In both of your examples, only one bit is set, what will change is the >> value being programmed to RXHCK_BRCM_TAG(i), which will be either 0, or >> 1, but the value programmed to RXCHK_CONTROL as far as which filter is >> enabled will be the same because we can use filter position 0. >> >> What the code basically does is look at how many bits are set in the >> filters bitmap, and then it starts populating the filters from filter 0 >> up to filter 7 with the value of the bit. > > O.K. Now it get it. Sorry for being so slow. No worries, thanks for reviewing these changes. I have made the requested ethtool changes and will post them when I return from vacation on July 29th. Thanks Andrew! -- Florian