From: Joerg Vehlow <lkml@jv-coder.de>
To: ltp@lists.linux.it
Subject: [LTP] LTP testcase(sysctl02) failed
Date: Fri, 15 Jan 2021 07:14:17 +0100 [thread overview]
Message-ID: <f3136f18-edd5-08b7-a720-72baeeed7fbc@jv-coder.de> (raw)
In-Reply-To: <0efaa481ffd24bc48fd41385159be66c@exch01.asrmicro.com>
Hi Gao,
On 12/24/2020 6:56 AM, Gao Meitao????? wrote:
>
> after investigated it, this testcase is for bufffer overflow, I
> checked source code (kernel 4.19),
>
> all of required patched had been applied, I dig into it and found new
> patch applied as flow , that might make testcase failed
>
> so is this testcase out of date or something wrong wih my kernel ?
>
> who can help me figure this out? Thanks in advance.
>
I also saw this on 4.19. From the mailing list of the kernel, it looks
like there was some confusion when they ported the patches back to 4.19.
I do not find the mails on the mailing list anymore. But the commit
7f2923c from master is missing IIRC.
Christian Brauner made two changes:
1. Prevent over and underflow by just keeping the old value (7f2923c
together with 32a5ad9c). This introduced a kasan bug fixed in 9002b21
2. Return EINVAL, if an overflow or underflow of the new value is
detected (e260ad01f)
From what I remember Christian wanted the first change completely
backported to 4.19 (7f2923c, 32a5ad9c and 9002b21) and he wanted to omit
the change done in e260ad01f, because that changed the behavior of the
interface towards the user.
But when the changed were backported to 4.19, the commit 32a5ad9c,
9002b21 and e260ad01f were backported. Since 7f2923c is the commit, that
really enables over- and underflow detection, this is not backported and
all the other commit (including e260ad01f) have no effect.
At the time I found this, I had no time to find out how and where to
report this.
@Cyril I guess you may know how and who to report this to?
J?rg
next prev parent reply other threads:[~2021-01-15 6:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 5:56 [LTP] LTP testcase(sysctl02) failed Gao =?unknown-8bit?b?TWVpdGFv77yI6auY546r5rab77yJ?=
2021-01-05 11:31 ` Cyril Hrubis
2021-01-15 6:14 ` Joerg Vehlow [this message]
2021-01-15 8:29 ` [LTP] 答复: " Gao =?unknown-8bit?b?TWVpdGFv77yI6auY546r5rab77yJ?=
2021-01-15 12:49 ` [LTP] " Cyril Hrubis
2021-02-05 9:12 ` Joerg Vehlow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3136f18-edd5-08b7-a720-72baeeed7fbc@jv-coder.de \
--to=lkml@jv-coder.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.