From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D1A4C43334 for ; Thu, 23 Jun 2022 03:38:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E209F845E9; Thu, 23 Jun 2022 03:38:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E209F845E9 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=C37+zF4A X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M81uPJ0Z8bmg; Thu, 23 Jun 2022 03:38:44 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id A0112845BA; Thu, 23 Jun 2022 03:38:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A0112845BA Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5EC9FC0032; Thu, 23 Jun 2022 03:38:43 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id AA80FC002D for ; Thu, 23 Jun 2022 03:38:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7D06B40370 for ; Thu, 23 Jun 2022 03:38:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7D06B40370 Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=C37+zF4A X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DoD_48kszubw for ; Thu, 23 Jun 2022 03:38:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 0DCB140207 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by smtp2.osuosl.org (Postfix) with ESMTPS id 0DCB140207 for ; Thu, 23 Jun 2022 03:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655955520; x=1687491520; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=U5JwulRGEY1I1BJUk8tkPc0NZfI5FzapZ/tvQYnIU7A=; b=C37+zF4AWZF7Mp4lI1ew9bTMTnefNaV2PEDOeUT+7AmWN0PRRGZWXWsH GasWWzj456FzYcuMbQ0ldZ3pBj6QeNIIe09y0WWzEZAM+ncm/ZrE4vCvb gkWdOcDf8w+OYywUqscJoifa57357suAZkKKg+H1/doYYgyhKycTJyPjN cSkIYmuYV+HbJl24CRz6q63Ml6ZMMisT30LHWcRV/e/D1VFr1EKpcKHg5 lggqrMnxUaWwY9+JAm0aa/6v1ZIcH9eeepLUiRiRXL/uxvUXBX9fIVLFd Y5kwF18zNI2iVSe5kqaa5UPoDlNdpldaY2lpTkmovGbBUfaskHgmrzt4a w==; X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="280661668" X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="280661668" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 20:38:39 -0700 X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="644525123" Received: from yutaoxu-mobl.ccr.corp.intel.com (HELO [10.249.172.190]) ([10.249.172.190]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 20:38:36 -0700 Message-ID: Date: Thu, 23 Jun 2022 11:38:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting Content-Language: en-US To: Jerry Snitselaar References: <9d6177ac-802f-eb11-4307-b0e49d8126b5@linux.intel.com> <20220615183650.32075-1-steve.wahl@hpe.com> <96984350-3a04-812a-60f1-a09138014fac@linux.intel.com> <20220623025126.ld45k72c2okodvvk@cantor> From: Baolu Lu In-Reply-To: <20220623025126.ld45k72c2okodvvk@cantor> Cc: Dimitri Sivanich , Kevin Tian , Joerg Roedel , Russ Anderson , Steve Wahl , Mike Travis , David Woodhouse , Kyung Min Park , Linux List Kernel Mailing , iommu , Will Deacon X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 2022/6/23 10:51, Jerry Snitselaar wrote: >> The real problem here is that the iommu sequence ID overflows if >> DMAR_UNITS_SUPPORTED is not big enough. This is purely a software >> implementation issue, I am not sure whether user opt-in when building a >> kernel package could help a lot here. >> > Is this something that could be figured out when parsing the dmar > table? It looks like currently iommu_refcnt[], iommu_did[], and > dmar_seq_ids[] depend on it. That's definitely a better solution. Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F29C43334 for ; Thu, 23 Jun 2022 04:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231963AbiFWEn3 (ORCPT ); Thu, 23 Jun 2022 00:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241110AbiFWDik (ORCPT ); Wed, 22 Jun 2022 23:38:40 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE10435271 for ; Wed, 22 Jun 2022 20:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655955519; x=1687491519; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=U5JwulRGEY1I1BJUk8tkPc0NZfI5FzapZ/tvQYnIU7A=; b=L6TQ795FlAUEmi45WH7cVPx001dKc11mPcKdjeFpStuMaqF1RrkgG4yy DP2S+MKNaniSQwufKomiW8xtYScyLBGZFIz+YBqTImOqOvq8mQq3jXMzo v2fpSUi3eyzI9f9QGrq2LYds37+r5M0pfnoryQHxDg9qfzGcRwrpjBD5h AO3OlbV9wYrxQW/DNNN6n0rsEpFSBpH/j3ytsOPlYGPOQQeWghO6gKdHc T9s7Ay4IDTyTSUTB6hfNzKbux07M+sYQFd9ibcJ7LkL+wgHBZw6rV4bcf hNzp/lxQuQcqVTyLnLl5mIRZnJEBy+i82reS5WtBtg8vpqooli8EcBt9Y g==; X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="281342007" X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="281342007" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 20:38:39 -0700 X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="644525123" Received: from yutaoxu-mobl.ccr.corp.intel.com (HELO [10.249.172.190]) ([10.249.172.190]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 20:38:36 -0700 Message-ID: Date: Thu, 23 Jun 2022 11:38:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: baolu.lu@linux.intel.com, Steve Wahl , Joerg Roedel , Kyung Min Park , David Woodhouse , Will Deacon , iommu , Kevin Tian , Mike Travis , Dimitri Sivanich , Russ Anderson , Linux List Kernel Mailing Subject: Re: [PATCH v3] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting Content-Language: en-US To: Jerry Snitselaar References: <9d6177ac-802f-eb11-4307-b0e49d8126b5@linux.intel.com> <20220615183650.32075-1-steve.wahl@hpe.com> <96984350-3a04-812a-60f1-a09138014fac@linux.intel.com> <20220623025126.ld45k72c2okodvvk@cantor> From: Baolu Lu In-Reply-To: <20220623025126.ld45k72c2okodvvk@cantor> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/6/23 10:51, Jerry Snitselaar wrote: >> The real problem here is that the iommu sequence ID overflows if >> DMAR_UNITS_SUPPORTED is not big enough. This is purely a software >> implementation issue, I am not sure whether user opt-in when building a >> kernel package could help a lot here. >> > Is this something that could be figured out when parsing the dmar > table? It looks like currently iommu_refcnt[], iommu_did[], and > dmar_seq_ids[] depend on it. That's definitely a better solution. Best regards, baolu