All of lore.kernel.org
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] i.MX fixes for 4.19, round 2
Date: Tue, 02 Oct 2018 13:42:43 +0200	[thread overview]
Message-ID: <f31c2fe8e753ba4c21e1c4b4ede270f88dddbf42.camel@pengutronix.de> (raw)
In-Reply-To: <CAK8P3a1e8+HMwsFjE5AJW1E8M309dTkXHLqQb0Dne1gO_n61vg@mail.gmail.com>

Hi Arnd,

Am Dienstag, den 02.10.2018, 11:59 +0200 schrieb Arnd Bergmann:
> On Mon, Oct 1, 2018 at 4:39 AM Shawn Guo <shawnguo@kernel.org> wrote:
> > 
> > The following changes since commit
> > 57361846b52bc686112da6ca5368d11210796804:
> > 
> >   Linux 4.19-rc2 (2018-09-02 14:37:30 -0700)
> > 
> > are available in the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> > tags/imx-fixes-4.19-2
> > 
> > for you to fetch changes up to
> > 4d8d4712e47c028306149bda04b79f70325aefb0:
> > 
> >   soc: imx: gpc: set DMA mask for PD platform devices (2018-09-26
> > 10:38:38 +0800)
> > 
> > ----------------------------------------------------------------
> > i.MX fixes for 4.19, round 2:
> >  - There appears an uninitialized DMA mask warning on i.MX GPC
> > driver
> >    with 4.19-rc kernel.  Set the DMA mask for powerdomain platform
> >    device to fix the warning given by device core.
> 
> I don't think this is the right fix, we should generally not just
> make up a dma
> mask pointer.
> 
> Lucas, do you have any more information regarding that warning?
> Are we trying to do DMA on a virtual device? What operation
> causes that warning?

The warning we are silencing here is generated by of_dma_configure() if
the dma_mask is not set, which gets called for all devices with a OF
node, regardless if the device is actually DMA capable.
As the platform bus code calls this function with force_dma = true, the
absent dma-ranges won't stop this function from trying to set up the
dma stuff, so I don't really see another clean way to get rid of this
warning.

Regards,
Lucas

  reply	other threads:[~2018-10-02 11:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01  2:39 [GIT PULL] i.MX fixes for 4.19, round 2 Shawn Guo
2018-10-02  9:59 ` Arnd Bergmann
2018-10-02 11:42   ` Lucas Stach [this message]
2018-10-02 12:09     ` Arnd Bergmann
2018-10-03  2:48       ` Shawn Guo
2018-10-04 15:34         ` Arnd Bergmann
2018-12-17 16:42       ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f31c2fe8e753ba4c21e1c4b4ede270f88dddbf42.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.