From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Auld Subject: Re: [PATCH] drm/i915/gtt: Avoid overflowing the WC stash Date: Wed, 29 May 2019 16:31:32 +0100 Message-ID: References: <20190529093407.31697-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 364506E07B for ; Wed, 29 May 2019 15:31:35 +0000 (UTC) In-Reply-To: <20190529093407.31697-1-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjkvMDUvMjAxOSAxMDozNCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IEFuIGludGVyZXN0aW5n IGlzc3VlIGNyb3BwZWQgd2l0aCBtYWtpbmcgdGhlIHBhZ2V0YWJsZXMgYmUgYWxsb2NhdGVkIGFu ZAo+IGZyZWVkIGNvbmN1cnJlbnRseSAoaS5lLiByZW1vdmluZyB0aGVpciBncmFuZGVvdXMgc3Ry dWN0X211dGV4IGd1YXJkKQo+IHdhcyB0aGF0IHdlIHdvdWxkIG92ZXJmbG93IHRoZSBwYWdlIHN0 YXNoLiBUaGlzIGhhcHBlbnMgd2hlbiB3ZSBoYXZlCj4gbXVsdGlwbGUgYWxsb2NhdG9ycyBncmFi YmluZyBXQyBwYWdlcyBzdWNoIHRoYXQgd2UgZmlsbCB0aGUgdm0ncyBsb2NhbAo+IHBhZ2Ugc3Rh c2ggYW5kIHRoZW4gd2hlbiB3ZSBmcmVlIGFub3RoZXIgcGFnZSwgdGhlIHBhZ2Ugc3Rhc2ggaXMg YWxyZWFkeQo+IGZ1bGwgYW5kIHdlIG92ZXJmbG93Lgo+IAo+IFRoZSBmaXggaXMgcXVpdGUgc2lt cGxlIHRvIGNoZWNrIGZvciBhIGZ1bGwgcGFnZSBzdGFzaCBiZWZvcmUgYWRkaW5nCj4gYW5vdGhl ci4gVGhpcyByZXN1bHRzIGluIHVzIGtlZXBpbmcgYSB2bSBsb2NhbCBwYWdlIHN0YXNoIGFyb3Vu ZCBmb3IKPiBtdWNoIGxvbmdlciB3aGljaCBpcyBib3RoIGEgYmxlc3NpbmcgYW5kIGEgY3Vyc2Uu Cj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+Cj4gQ2M6IE1hdHRoZXcgQXVsZCA8bWF0dGhldy5hdWxkQGludGVsLmNvbT4KPiBDYzogSm9v bmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgpSZXZpZXdlZC1i eTogTWF0dGhldyBBdWxkIDxtYXR0aGV3LmF1bGRAaW50ZWwuY29tPgoKPiAtLS0KPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIHwgMTAgKysrKysrLS0tLQo+ICAgMSBmaWxl IGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbV9ndHQuYwo+IGluZGV4IDc0OTZjY2UwZDc5OC4uMmQ3YTk2OGQ0ZmQ1IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBAQCAtMzQxLDExICszNDEsMTEg QEAgc3RhdGljIHN0cnVjdCBwYWdlICpzdGFzaF9wb3BfcGFnZShzdHJ1Y3QgcGFnZXN0YXNoICpz dGFzaCkKPiAgIAo+ICAgc3RhdGljIHZvaWQgc3Rhc2hfcHVzaF9wYWdldmVjKHN0cnVjdCBwYWdl c3Rhc2ggKnN0YXNoLCBzdHJ1Y3QgcGFnZXZlYyAqcHZlYykKPiAgIHsKPiAtCWludCBucjsKPiAr CXVuc2lnbmVkIGludCBucjsKPiAgIAo+ICAgCXNwaW5fbG9ja19uZXN0ZWQoJnN0YXNoLT5sb2Nr LCBTSU5HTEVfREVQVEhfTkVTVElORyk7Cj4gICAKPiAtCW5yID0gbWluX3QoaW50LCBwdmVjLT5u ciwgcGFnZXZlY19zcGFjZSgmc3Rhc2gtPnB2ZWMpKTsKPiArCW5yID0gbWluX3QodHlwZW9mKG5y KSwgcHZlYy0+bnIsIHBhZ2V2ZWNfc3BhY2UoJnN0YXNoLT5wdmVjKSk7Cj4gICAJbWVtY3B5KHN0 YXNoLT5wdmVjLnBhZ2VzICsgc3Rhc2gtPnB2ZWMubnIsCj4gICAJICAgICAgIHB2ZWMtPnBhZ2Vz ICsgcHZlYy0+bnIgLSBuciwKPiAgIAkgICAgICAgc2l6ZW9mKHB2ZWMtPnBhZ2VzWzBdKSAqIG5y KTsKPiBAQCAtMzk5LDcgKzM5OSw4IEBAIHN0YXRpYyBzdHJ1Y3QgcGFnZSAqdm1fYWxsb2NfcGFn ZShzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSwgZ2ZwX3QgZ2ZwKQo+ICAgCQlwYWdlID0g c3RhY2sucGFnZXNbLS1zdGFjay5ucl07Cj4gICAKPiAgIAkJLyogTWVyZ2Ugc3BhcmUgV0MgcGFn ZXMgdG8gdGhlIGdsb2JhbCBzdGFzaCAqLwo+IC0JCXN0YXNoX3B1c2hfcGFnZXZlYygmdm0tPmk5 MTUtPm1tLndjX3N0YXNoLCAmc3RhY2spOwo+ICsJCWlmIChzdGFjay5ucikKPiArCQkJc3Rhc2hf cHVzaF9wYWdldmVjKCZ2bS0+aTkxNS0+bW0ud2Nfc3Rhc2gsICZzdGFjayk7Cj4gICAKPiAgIAkJ LyogUHVzaCBhbnkgc3VycGx1cyBXQyBwYWdlcyBvbnRvIHRoZSBsb2NhbCBWTSBzdGFzaCAqLwo+ ICAgCQlpZiAoc3RhY2subnIpCj4gQEAgLTQ2OSw4ICs0NzAsOSBAQCBzdGF0aWMgdm9pZCB2bV9m cmVlX3BhZ2Uoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sIHN0cnVjdCBwYWdlICpwYWdl KQo+ICAgCSAqLwo+ICAgCW1pZ2h0X3NsZWVwKCk7Cj4gICAJc3Bpbl9sb2NrKCZ2bS0+ZnJlZV9w YWdlcy5sb2NrKTsKPiAtCWlmICghcGFnZXZlY19hZGQoJnZtLT5mcmVlX3BhZ2VzLnB2ZWMsIHBh Z2UpKQo+ICsJaWYgKCFwYWdldmVjX3NwYWNlKCZ2bS0+ZnJlZV9wYWdlcy5wdmVjKSkKPiAgIAkJ dm1fZnJlZV9wYWdlc19yZWxlYXNlKHZtLCBmYWxzZSk7Cj4gKwlwYWdldmVjX2FkZCgmdm0tPmZy ZWVfcGFnZXMucHZlYywgcGFnZSk7Cj4gICAJc3Bpbl91bmxvY2soJnZtLT5mcmVlX3BhZ2VzLmxv Y2spOwo+ICAgfQo+ICAgCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeA==