From: "Luca Bocassi" <luca.boccassi@gmail.com>
To: Konrad Weihmann <kweihmann@outlook.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] Add new recipe for squashfs-tools-ng
Date: Thu, 22 Oct 2020 10:21:33 +0100 [thread overview]
Message-ID: <f331436c48d4109a69199ff247132fc684c94524.camel@gmail.com> (raw)
In-Reply-To: <VI1PR01MB6462255CF43C3222C6DF6281A81C0@VI1PR01MB6462.eurprd01.prod.exchangelabs.com>
On Wed, 2020-10-21 at 21:08 +0200, Konrad Weihmann wrote:
> On 21.10.20 17:58, Luca Bocassi wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > The main difference with squashfs-tools is the availability
> > of a shared library and a programmatic interface, rather
> > than just command-line tools.
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> > .../squashfs-tools-ng_git.bb | 37 +++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> > create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> >
> > diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> > new file mode 100644
> > index 0000000000..bbc5f86ae9
> > --- /dev/null
> > +++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> > @@ -0,0 +1,37 @@
> > +SUMMARY = "New set of tools for working with SquashFS images"
> > +SECTION = "base"
> > +LICENSE = "GPLv3+ & LGPL-3.0+"
>
> A bit of nitpick, but with all the license files mentioned below the
> LICENSE setting looks wrong to me.
> I would at least expect some BSD and zLib SPDX identifiers here.
Added MIT, Zlib and BSD-2-Clause in v2.
> To be super exact one would have to take the PACKAGECONFIG into account
> to get the correct value
The binary is distributed under the terms of GPL3 regardless, so not
sure it's worth the complications? Is it required/commonly done in
other recipes?
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2020-10-22 9:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 15:58 [PATCH] Add new recipe for squashfs-tools-ng Luca Bocassi
2020-10-21 19:02 ` [OE-core] " Richard Purdie
2020-10-22 2:21 ` Khem Raj
2020-10-22 9:13 ` Luca Bocassi
2020-10-21 19:08 ` Konrad Weihmann
2020-10-22 9:21 ` Luca Bocassi [this message]
2020-10-22 9:20 ` [PATCH v2] " Luca Bocassi
2020-10-22 11:10 ` [OE-core] " Peter Kjellerstedt
2020-10-22 11:30 ` Luca Bocassi
2020-10-22 11:30 ` [PATCH v3] " Luca Bocassi
2020-10-22 19:10 ` [OE-core] " Khem Raj
2020-10-23 8:57 ` Luca Bocassi
2020-10-24 12:58 ` Richard Purdie
2020-10-26 10:05 ` Luca Bocassi
2020-10-26 10:05 ` [PATCH v4] " Luca Bocassi
2020-10-26 10:29 ` Richard Purdie
2020-10-26 13:09 ` Luca Bocassi
2020-10-27 10:31 ` Luca Bocassi
2020-10-27 10:37 ` Richard Purdie
2020-10-27 10:59 ` Luca Bocassi
2020-10-27 11:19 ` [OE-core] " Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f331436c48d4109a69199ff247132fc684c94524.camel@gmail.com \
--to=luca.boccassi@gmail.com \
--cc=kweihmann@outlook.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.