From: Mike Christie <michael.christie@oracle.com>
To: Bodo Stroesser <bostroesser@gmail.com>,
Chaitanya.Kulkarni@wdc.com, loberman@redhat.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, mst@redhat.com,
stefanha@redhat.com, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 03/13] target: add workqueue based cmd submission
Date: Tue, 9 Feb 2021 12:43:01 -0600 [thread overview]
Message-ID: <f33bd053-3a78-fc9c-0ec5-2b5e97dadcfc@oracle.com> (raw)
In-Reply-To: <206a3f41-dea8-2152-4811-817138ffb580@gmail.com>
On 2/9/21 9:48 AM, Bodo Stroesser wrote:
> On 09.02.21 13:38, Mike Christie wrote:
>> +void target_queued_submit_work(struct work_struct *work)
>> +{
>> + struct se_cmd_queue *sq = container_of(work, struct se_cmd_queue, work);
>> + struct se_cmd *se_cmd, *next_cmd;
>> + struct llist_node *cmd_list;
>> + unsigned char *cdb;
>> +
>> + cmd_list = llist_del_all(&sq->cmd_list);
>> + if (!cmd_list)
>> + /* Previous call took what we were queued to submit */
>> + return;
>> +
>> + cmd_list = llist_reverse_order(cmd_list);
>> + llist_for_each_entry_safe(se_cmd, next_cmd, cmd_list, se_cmd_list) {
>> + cdb = se_cmd->se_tfo->get_cdb(se_cmd);
>
> If I got it right, get_cdb is a new, optional callback.
> So, should we check, whether it is set?
I think a check is not really useful. The caller has to implement it
if they call target_queue_cmd_submit. It would be a BUG() and so
either way you would get a crash when you are developing a patch.
>
> Maybe the check better could be done early in target_queue_cmd_submit.
>
next prev parent reply other threads:[~2021-02-09 23:17 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 12:38 [PATCH 00/12 V2] target: fix cmd plugging and completion Mike Christie
2021-02-09 12:38 ` [PATCH 01/13] target: move t_task_cdb initialization Mike Christie
2021-02-10 8:35 ` Christoph Hellwig
2021-02-10 8:35 ` Christoph Hellwig
2021-02-09 12:38 ` [PATCH 02/13] target: split target_submit_cmd_map_sgls Mike Christie
2021-02-09 16:15 ` kernel test robot
2021-02-09 16:15 ` kernel test robot
2021-02-09 16:15 ` kernel test robot
2021-02-09 18:40 ` Mike Christie
2021-02-09 18:40 ` Mike Christie
2021-02-10 8:36 ` Christoph Hellwig
2021-02-10 8:36 ` Christoph Hellwig
2021-02-09 12:38 ` [PATCH 03/13] target: add workqueue based cmd submission Mike Christie
2021-02-09 15:48 ` Bodo Stroesser
2021-02-09 18:43 ` Mike Christie [this message]
2021-02-09 19:10 ` Mike Christie
2021-02-09 12:38 ` [PATCH 04/13] vhost scsi: use lio wq cmd submission helper Mike Christie
2021-02-09 12:38 ` [PATCH 05/13] tcm loop: use blk cmd allocator for se_cmds Mike Christie
2021-02-10 8:37 ` Christoph Hellwig
2021-02-10 8:37 ` Christoph Hellwig
2021-02-09 12:38 ` [PATCH 06/13] tcm loop: use lio wq cmd submission helper Mike Christie
2021-02-09 15:59 ` Bodo Stroesser
2021-02-09 18:44 ` Mike Christie
2021-02-09 17:39 ` kernel test robot
2021-02-09 17:39 ` kernel test robot
2021-02-09 12:38 ` [PATCH 07/13] target: cleanup cmd flag bits Mike Christie
2021-02-10 8:38 ` Christoph Hellwig
2021-02-10 8:38 ` Christoph Hellwig
2021-02-09 12:38 ` [PATCH 08/13] target: fix backend plugging Mike Christie
2021-02-09 12:38 ` [PATCH 09/13] target iblock: add backend plug/unplug callouts Mike Christie
2021-02-09 12:38 ` [PATCH 10/13] target_core_user: " Mike Christie
2021-02-09 16:32 ` Bodo Stroesser
2021-02-09 18:59 ` Mike Christie
2021-02-09 12:38 ` [PATCH 11/13] target: replace work per cmd in completion path Mike Christie
2021-02-09 17:01 ` Bodo Stroesser
2021-02-09 18:50 ` Mike Christie
2021-02-10 8:42 ` Christoph Hellwig
2021-02-10 8:42 ` Christoph Hellwig
2021-02-10 18:33 ` Mike Christie
2021-02-09 12:38 ` [PATCH 12/13] target, vhost-scsi: don't switch cpus on completion Mike Christie
2021-02-10 8:44 ` Christoph Hellwig
2021-02-10 8:44 ` Christoph Hellwig
2021-02-10 18:43 ` Mike Christie
2021-02-10 18:45 ` Mike Christie
2021-02-09 12:38 ` [PATCH 13/13] target: flush submission work during TMR processing Mike Christie
2021-02-09 14:31 ` Laurence Oberman
2021-02-10 14:25 ` Laurence Oberman
2021-02-09 17:05 ` Bodo Stroesser
2021-02-09 18:49 ` Mike Christie
2021-02-10 4:55 [PATCH 00/13 V3] target: fix cmd plugging and completion Mike Christie
2021-02-10 4:55 ` [PATCH 03/13] target: add workqueue based cmd submission Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f33bd053-3a78-fc9c-0ec5-2b5e97dadcfc@oracle.com \
--to=michael.christie@oracle.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=bostroesser@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.