From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v4] bus/pci: fix vfio mode Date: Tue, 31 Oct 2017 09:58:29 -0700 Message-ID: References: <8492fe4cf1a8d6f15d389c9148e4942f1d060a40.1509381300.git.gaetan.rivet@6wind.com> <20171030223227.8852-1-ferruh.yigit@intel.com> <20171031120338.GA6052@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Anatoly Burakov , dev@dpdk.org, Jerin Jacob , Gaetan Rivet To: Bruce Richardson Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B8F361B219 for ; Tue, 31 Oct 2017 17:58:30 +0100 (CET) In-Reply-To: <20171031120338.GA6052@bricha3-MOBL3.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/31/2017 5:03 AM, Bruce Richardson wrote: > On Mon, Oct 30, 2017 at 10:32:27PM +0000, Ferruh Yigit wrote: >> Revert back to using VFIO_PRESENT as a marker to enable compilation >> of VFIO-related segments. >> >> VFIO_PRESENT is the combination of user configuration RTE_EAL_VFIO and >> kernel version support check. >> >> eal_vfio.h VFIO_PRESENT related check ordered to be compatible with >> rte_vfio.h one, no functional modification. >> >> Fixes: 279b581c897d ("vfio: expose functions") >> >> Signed-off-by: Jerin Jacob >> Signed-off-by: Gaetan Rivet >> Signed-off-by: Ferruh Yigit >> --- >> v4: >> >> * Alternative to v3, not superseding it, need to decide which one to >> get. This one: >> * fixes vfio for new kernels >> * fixes build for old kernels for vfio enabled in config case >> * print warning if vfio enabled in config but not supported by kernel >> >> * Independent from this patch, following may need fixing later >> * Kernel version check for vfio is broken for RTE_KERNELDIR >> * Kernel VFIO support check can be improved >> --- >> drivers/bus/pci/linux/pci_init.h | 2 +- >> drivers/bus/pci/linux/pci_vfio.c | 2 +- >> lib/librte_eal/common/include/rte_vfio.h | 14 ++++++++++++++ >> lib/librte_eal/linuxapp/eal/eal_interrupts.c | 1 - >> lib/librte_eal/linuxapp/eal/eal_vfio.h | 14 ++++++++++---- >> 5 files changed, 26 insertions(+), 7 deletions(-) >> > Hi, > > just to confirm that applying this patch fixes DPDK on my system at > least. > > From the discussion, I understood that this was a "compilation problem", > but in practice it manifests itself as compile working ok but your app > won't work with ports bound to vfio-pci. So please apply some fix for > this soon. The main reason of the patch is vfio issue. All three of patches from Jerin, Gaetan, and this are fixing that issue. Difference is: - Create or not dependency to eal_vfio.h again - Break or not build for old kernels > > Thanks for the work on this, all. > > Tested-by: Bruce Richardson >