From: Guenter Roeck <linux@roeck-us.net>
To: Adam Wujek <dev_public@wujek.eu>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] hwmon: (pmbus) add MFR_* registers to debugfs
Date: Wed, 20 Apr 2022 06:53:37 -0700 [thread overview]
Message-ID: <f34ec7ac-7b34-6d98-25ad-31b13fe08c59@roeck-us.net> (raw)
In-Reply-To: <20220420122128.411757-1-dev_public@wujek.eu>
On 4/20/22 05:22, Adam Wujek wrote:
> Add registers to debugfs:
> PMBUS_MFR_ID
> PMBUS_MFR_MODEL
> PMBUS_MFR_REVISION
> PMBUS_MFR_LOCATION
> PMBUS_MFR_DATE
> PMBUS_MFR_SERIAL
>
> Signed-off-by: Adam Wujek <dev_public@wujek.eu>
Where is patch 1/2, and why did you resend this patch ?
Guenter
> ---
> drivers/hwmon/pmbus/pmbus_core.c | 84 ++++++++++++++++++++++++++++++++
> 1 file changed, 84 insertions(+)
>
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index 0af7a3d74f47..1dc186780ccf 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -2625,6 +2625,30 @@ static int pmbus_debugfs_get_status(void *data, u64 *val)
> DEFINE_DEBUGFS_ATTRIBUTE(pmbus_debugfs_ops_status, pmbus_debugfs_get_status,
> NULL, "0x%04llx\n");
>
> +static ssize_t pmbus_debugfs_mfr_read(struct file *file, char __user *buf,
> + size_t count, loff_t *ppos)
> +{
> + int rc;
> + struct pmbus_debugfs_entry *entry = file->private_data;
> + char data[I2C_SMBUS_BLOCK_MAX + 2] = { 0 };
> +
> + rc = i2c_smbus_read_block_data(entry->client, entry->reg, data);
> + if (rc < 0)
> + return rc;
> +
> + data[rc] = '\n';
> + rc += 2;
> +
> + return simple_read_from_buffer(buf, count, ppos, data, rc);
> +}
> +
> +static const struct file_operations pmbus_debugfs_ops_mfr = {
> + .llseek = noop_llseek,
> + .read = pmbus_debugfs_mfr_read,
> + .write = NULL,
> + .open = simple_open,
> +};
> +
> static int pmbus_debugfs_get_pec(void *data, u64 *val)
> {
> struct i2c_client *client = data;
> @@ -2801,6 +2825,66 @@ static int pmbus_init_debugfs(struct i2c_client *client,
> &entries[idx++],
> &pmbus_debugfs_ops);
> }
> +
> + if (pmbus_check_byte_register(client, i, PMBUS_MFR_ID)) {
> + entries[idx].client = client;
> + entries[idx].page = i;
> + entries[idx].reg = PMBUS_MFR_ID;
> + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_id", i);
> + debugfs_create_file(name, 0444, data->debugfs,
> + &entries[idx++],
> + &pmbus_debugfs_ops_mfr);
> + }
> +
> + if (pmbus_check_byte_register(client, i, PMBUS_MFR_MODEL)) {
> + entries[idx].client = client;
> + entries[idx].page = i;
> + entries[idx].reg = PMBUS_MFR_MODEL;
> + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_model", i);
> + debugfs_create_file(name, 0444, data->debugfs,
> + &entries[idx++],
> + &pmbus_debugfs_ops_mfr);
> + }
> +
> + if (pmbus_check_byte_register(client, i, PMBUS_MFR_REVISION)) {
> + entries[idx].client = client;
> + entries[idx].page = i;
> + entries[idx].reg = PMBUS_MFR_REVISION;
> + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_revision", i);
> + debugfs_create_file(name, 0444, data->debugfs,
> + &entries[idx++],
> + &pmbus_debugfs_ops_mfr);
> + }
> +
> + if (pmbus_check_byte_register(client, i, PMBUS_MFR_LOCATION)) {
> + entries[idx].client = client;
> + entries[idx].page = i;
> + entries[idx].reg = PMBUS_MFR_LOCATION;
> + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_location", i);
> + debugfs_create_file(name, 0444, data->debugfs,
> + &entries[idx++],
> + &pmbus_debugfs_ops_mfr);
> + }
> +
> + if (pmbus_check_byte_register(client, i, PMBUS_MFR_DATE)) {
> + entries[idx].client = client;
> + entries[idx].page = i;
> + entries[idx].reg = PMBUS_MFR_DATE;
> + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_date", i);
> + debugfs_create_file(name, 0444, data->debugfs,
> + &entries[idx++],
> + &pmbus_debugfs_ops_mfr);
> + }
> +
> + if (pmbus_check_byte_register(client, i, PMBUS_MFR_SERIAL)) {
> + entries[idx].client = client;
> + entries[idx].page = i;
> + entries[idx].reg = PMBUS_MFR_SERIAL;
> + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_serial", i);
> + debugfs_create_file(name, 0444, data->debugfs,
> + &entries[idx++],
> + &pmbus_debugfs_ops_mfr);
> + }
> }
>
> return devm_add_action_or_reset(data->dev,
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2022-04-20 13:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 21:53 [PATCH] hwmon: (pmbus) add MFR_* registers to debugfs Adam Wujek
2022-04-20 12:22 ` [PATCH 2/2] " Adam Wujek
2022-04-20 13:53 ` Guenter Roeck [this message]
2022-04-20 13:58 ` wujek dev
2022-04-20 14:15 ` Guenter Roeck
2022-04-20 15:41 ` [v3 PATCH] " Adam Wujek
2022-04-20 15:51 ` [PATCH 2/2] " wujek dev
2022-04-20 16:06 ` Guenter Roeck
2022-04-20 21:37 ` wujek dev
2022-04-20 21:41 ` [v4 PATCH] " Adam Wujek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f34ec7ac-7b34-6d98-25ad-31b13fe08c59@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dev_public@wujek.eu \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.