From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68882C4338F for ; Thu, 29 Jul 2021 11:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AF6760F22 for ; Thu, 29 Jul 2021 11:58:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235506AbhG2L6k (ORCPT ); Thu, 29 Jul 2021 07:58:40 -0400 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]:39398 "EHLO smtp-relay-canonical-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235324AbhG2L6j (ORCPT ); Thu, 29 Jul 2021 07:58:39 -0400 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 8AADE3F22C for ; Thu, 29 Jul 2021 11:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627559915; bh=mJegt6nAKectUckt+rbFcl6x63P1a1GPjk8ahj5YQQU=; h=Subject:From:To:Cc:References:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=bQGamwfephWaMoWpVCkkn6eCMN3KZaBoWqWicZ/qbKALsfgq4hHLFVuaMtxQWYAe6 /SoeM+AKnrhtCw2Izm17aHvKnl1DeKyE39GgEIdY1DKgxYWcAe2hBKDjPE0Lgz4BWp w28yBjEQOLTe14gTT4MVxOGq2cahZs3scRYruWtIWCiHxQq4zZPtQCp/gf5xed38ru 0Pi4Y6uqp779oBX/W+n7BelGsVbD6+ubLDIRvE+E9ArgKmalQ0vbqLSULXFFmfj3gi eCG7jKJpRw0Hn05NSmjREt6ODJPb1YsR8ETYYs3Eirrk8fssajqcvSVPS2XEyXIPpq ANnjJ6G20RQwg== Received: by mail-ej1-f72.google.com with SMTP id a19-20020a1709063e93b0290551ea218ea2so1901441ejj.5 for ; Thu, 29 Jul 2021 04:58:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mJegt6nAKectUckt+rbFcl6x63P1a1GPjk8ahj5YQQU=; b=l8wod72w0VQZdYT2Zv7a7m7rznEbFLQKKkYV5vRNPQoLfYKtdNkBXdrvh0FXYZUuLR b/tmef568iRinF2ExwaPaT9B3piiK427B54h06BI9urPszcEg3LwUkAOD+oDAKFTi0r8 fa4ARcXdkZxK9yNv+kAoYqetCSWaHcLlC/qxCIV1R8amSz6Cnqh34C5/c8wZ5X2SvLA8 Qr/veHNGkTmUsJWXMNyNKClCwToSHDnEtp+YnRQZmQ4oCOpxwQJ3Q4fBkTfE4PIv//SC Dxk2f9YbkT9CUg+0bi+c09IkY/GNWULA4WKIPuxDmEEcYI/mGdw+LcL/Si+2VHHewr5N 0fUw== X-Gm-Message-State: AOAM53080qUuyAvHUY0tNqThz8NFJ1Ht/pE8wuawVCNMMLmQ4bMYSIIE UyShInumrPYkZD4F70vx/R/wxlUpzzoSdlZH9wcU6pKOOL4gmoLafw66V//d0X1IljiwAUNjnyo Hty04UtZ7/0MzYjHhvVlRXBA3cl+0xf/Wz1Pige9KBBxL X-Received: by 2002:a17:906:c085:: with SMTP id f5mr4338570ejz.250.1627559914474; Thu, 29 Jul 2021 04:58:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzv4BAiKXa3/y/e8C9RanIKpgbXJfSN4+8ZZEBon9lao+WKG0BTNjyji29VQ1OsQPbAi6/DMw== X-Received: by 2002:a17:906:c085:: with SMTP id f5mr4338563ejz.250.1627559914327; Thu, 29 Jul 2021 04:58:34 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id n11sm908803ejg.111.2021.07.29.04.58.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 04:58:33 -0700 (PDT) Subject: Re: [PATCH 00/12] nfc: constify, continued (part 2) From: Krzysztof Kozlowski To: patchwork-bot+netdevbpf@kernel.org, davem@davemloft.net Cc: mgreer@animalcreek.com, bongsu.jeon@samsung.com, kuba@kernel.org, linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org References: <20210729104022.47761-1-krzysztof.kozlowski@canonical.com> <162755820704.26856.6157999905884570707.git-patchwork-notify@kernel.org> <7b0ae615-dcdc-251e-4067-959b31c28159@canonical.com> Message-ID: Date: Thu, 29 Jul 2021 13:58:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <7b0ae615-dcdc-251e-4067-959b31c28159@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 29/07/2021 13:35, Krzysztof Kozlowski wrote: > On 29/07/2021 13:30, patchwork-bot+netdevbpf@kernel.org wrote: >> Hello: >> >> This series was applied to netdev/net-next.git (refs/heads/master): >> >> On Thu, 29 Jul 2021 12:40:10 +0200 you wrote: >>> Hi, >>> >>> On top of: >>> nfc: constify pointed data >>> https://lore.kernel.org/lkml/20210726145224.146006-1-krzysztof.kozlowski@canonical.com/ >>> >>> Best regards, >>> Krzysztof >>> >>> [...] >> >> Here is the summary with links: >> - [01/12] nfc: constify passed nfc_dev >> https://git.kernel.org/netdev/net-next/c/dd8987a394c0 >> - [02/12] nfc: mei_phy: constify buffer passed to mei_nfc_send() >> https://git.kernel.org/netdev/net-next/c/894a6e158633 >> - [03/12] nfc: port100: constify several pointers >> https://git.kernel.org/netdev/net-next/c/9a4af01c35a5 >> - [04/12] nfc: trf7970a: constify several pointers >> https://git.kernel.org/netdev/net-next/c/ea050c5ee74a >> - [05/12] nfc: virtual_ncidev: constify pointer to nfc_dev >> https://git.kernel.org/netdev/net-next/c/83428dbbac51 >> - [06/12] nfc: nfcsim: constify drvdata (struct nfcsim) >> https://git.kernel.org/netdev/net-next/c/582fdc98adc8 >> - [07/12] nfc: fdp: drop unneeded cast for printing firmware size in dev_dbg() >> https://git.kernel.org/netdev/net-next/c/6c755b1d2511 >> - [08/12] nfc: fdp: use unsigned int as loop iterator >> https://git.kernel.org/netdev/net-next/c/c3e26b6dc1b4 >> - [09/12] nfc: fdp: constify several pointers >> https://git.kernel.org/netdev/net-next/c/3d463dd5023b >> - [10/12] nfc: microread: constify several pointers >> https://git.kernel.org/netdev/net-next/c/a751449f8b47 >> - [11/12] nfc: mrvl: constify several pointers >> https://git.kernel.org/netdev/net-next/c/fe53159fe3e0 > > Oh, folks, too fast :) > > Sorry for the mess, but the patch 11/12 has one const which is wrong > (I sent an email for it) and this should be on top of my > previous set: > https://lore.kernel.org/lkml/20210726145224.146006-1-krzysztof.kozlowski@canonical.com/ > which I think you did not take in. > > I am not sure if it compiles cleanly without the one above. Hi David, This fails because of missing patchset above: ../drivers/nfc/fdp/fdp.c: In function ‘fdp_nci_set_production_data’: ../drivers/nfc/fdp/fdp.c:116:60: warning: passing argument 4 of ‘nci_prop_cmd’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 116 | return nci_prop_cmd(ndev, NCI_OP_PROP_SET_PDATA_OID, len, data); It also has one issue in patch 11/12. Can you drop this from net-dev/master? I can send a v2 of both patchsets combined. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB983C4320E for ; Thu, 29 Jul 2021 11:58:40 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A01B160F38 for ; Thu, 29 Jul 2021 11:58:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A01B160F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 2AD19100EB829; Thu, 29 Jul 2021 04:58:40 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=185.125.188.120; helo=smtp-relay-canonical-0.canonical.com; envelope-from=krzysztof.kozlowski@canonical.com; receiver= Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8B273100EBB9E for ; Thu, 29 Jul 2021 04:58:37 -0700 (PDT) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 5A6EB3F10B for ; Thu, 29 Jul 2021 11:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627559915; bh=mJegt6nAKectUckt+rbFcl6x63P1a1GPjk8ahj5YQQU=; h=Subject:From:To:Cc:References:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=bQGamwfephWaMoWpVCkkn6eCMN3KZaBoWqWicZ/qbKALsfgq4hHLFVuaMtxQWYAe6 /SoeM+AKnrhtCw2Izm17aHvKnl1DeKyE39GgEIdY1DKgxYWcAe2hBKDjPE0Lgz4BWp w28yBjEQOLTe14gTT4MVxOGq2cahZs3scRYruWtIWCiHxQq4zZPtQCp/gf5xed38ru 0Pi4Y6uqp779oBX/W+n7BelGsVbD6+ubLDIRvE+E9ArgKmalQ0vbqLSULXFFmfj3gi eCG7jKJpRw0Hn05NSmjREt6ODJPb1YsR8ETYYs3Eirrk8fssajqcvSVPS2XEyXIPpq ANnjJ6G20RQwg== Received: by mail-ed1-f69.google.com with SMTP id a23-20020a50ff170000b02903b85a16b672so2838978edu.1 for ; Thu, 29 Jul 2021 04:58:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mJegt6nAKectUckt+rbFcl6x63P1a1GPjk8ahj5YQQU=; b=lP4cOgUJu0OAgDFFExJCnH7/tSe/Aq9zIXybmxD/ut8j4u6m6P1V7wRxD1/9cjvN4N ygirzZhZPXBqTjptNYJ4nblrvwpvEArKJ26J2s4sByhRY016XB3vSiwECNdfuXcTpSui 9gcpeluvh4M3dQgBm68JUqbvH+0Jq/O2EAEemBo8Gtytaho2TB0fIXNu3wyqay4LhKn+ w7kSIwVLg4hX9GfR31eBizR3dKe6R2IakvmNA6S4zayVSUEuvjgm4pLD4smUptpqzBX3 AYDD3C3VJ7D9B+nbRXNwTQ2a447u1sKakgNeBEoPWJCUipFyJQExL6Lv888RnIS0/4kS RmcA== X-Gm-Message-State: AOAM5304Qf6MsLrZtRNqaUiSqRsNQ8VpmrQAhIZTn4T6LRVRKmTsNHvd A/CxOLiDVmXOj8pPRb7pd793i8HPuOIBOGCb8OHnwfBeTB1XPw7qO9P+Uv33i+QvfXo5jgS2Jzu RljfivgHwecybsW68L+jLsS7FIefJMC04LA== X-Received: by 2002:a17:906:c085:: with SMTP id f5mr4338574ejz.250.1627559914476; Thu, 29 Jul 2021 04:58:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzv4BAiKXa3/y/e8C9RanIKpgbXJfSN4+8ZZEBon9lao+WKG0BTNjyji29VQ1OsQPbAi6/DMw== X-Received: by 2002:a17:906:c085:: with SMTP id f5mr4338563ejz.250.1627559914327; Thu, 29 Jul 2021 04:58:34 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id n11sm908803ejg.111.2021.07.29.04.58.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 04:58:33 -0700 (PDT) From: Krzysztof Kozlowski To: patchwork-bot+netdevbpf@kernel.org, davem@davemloft.net References: <20210729104022.47761-1-krzysztof.kozlowski@canonical.com> <162755820704.26856.6157999905884570707.git-patchwork-notify@kernel.org> <7b0ae615-dcdc-251e-4067-959b31c28159@canonical.com> Message-ID: Date: Thu, 29 Jul 2021 13:58:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <7b0ae615-dcdc-251e-4067-959b31c28159@canonical.com> Content-Language: en-US Message-ID-Hash: E6MKSQKQETZ6T3TIWDLQCLM5YP3N2G6C X-Message-ID-Hash: E6MKSQKQETZ6T3TIWDLQCLM5YP3N2G6C X-MailFrom: krzysztof.kozlowski@canonical.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: bongsu.jeon@samsung.com, kuba@kernel.org, linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org X-Mailman-Version: 3.1.1 Precedence: list Subject: [linux-nfc] Re: [PATCH 00/12] nfc: constify, continued (part 2) List-Id: NFC on Linux Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gMjkvMDcvMjAyMSAxMzozNSwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToNCj4gT24gMjkv MDcvMjAyMSAxMzozMCwgcGF0Y2h3b3JrLWJvdCtuZXRkZXZicGZAa2VybmVsLm9yZyB3cm90ZToN Cj4+IEhlbGxvOg0KPj4NCj4+IFRoaXMgc2VyaWVzIHdhcyBhcHBsaWVkIHRvIG5ldGRldi9uZXQt bmV4dC5naXQgKHJlZnMvaGVhZHMvbWFzdGVyKToNCj4+DQo+PiBPbiBUaHUsIDI5IEp1bCAyMDIx IDEyOjQwOjEwICswMjAwIHlvdSB3cm90ZToNCj4+PiBIaSwNCj4+Pg0KPj4+IE9uIHRvcCBvZjoN Cj4+PiBuZmM6IGNvbnN0aWZ5IHBvaW50ZWQgZGF0YQ0KPj4+IGh0dHBzOi8vbG9yZS5rZXJuZWwu b3JnL2xrbWwvMjAyMTA3MjYxNDUyMjQuMTQ2MDA2LTEta3J6eXN6dG9mLmtvemxvd3NraUBjYW5v bmljYWwuY29tLw0KPj4+DQo+Pj4gQmVzdCByZWdhcmRzLA0KPj4+IEtyenlzenRvZg0KPj4+DQo+ Pj4gWy4uLl0NCj4+DQo+PiBIZXJlIGlzIHRoZSBzdW1tYXJ5IHdpdGggbGlua3M6DQo+PiAgIC0g WzAxLzEyXSBuZmM6IGNvbnN0aWZ5IHBhc3NlZCBuZmNfZGV2DQo+PiAgICAgaHR0cHM6Ly9naXQu a2VybmVsLm9yZy9uZXRkZXYvbmV0LW5leHQvYy9kZDg5ODdhMzk0YzANCj4+ICAgLSBbMDIvMTJd IG5mYzogbWVpX3BoeTogY29uc3RpZnkgYnVmZmVyIHBhc3NlZCB0byBtZWlfbmZjX3NlbmQoKQ0K Pj4gICAgIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvbmV0ZGV2L25ldC1uZXh0L2MvODk0YTZlMTU4 NjMzDQo+PiAgIC0gWzAzLzEyXSBuZmM6IHBvcnQxMDA6IGNvbnN0aWZ5IHNldmVyYWwgcG9pbnRl cnMNCj4+ICAgICBodHRwczovL2dpdC5rZXJuZWwub3JnL25ldGRldi9uZXQtbmV4dC9jLzlhNGFm MDFjMzVhNQ0KPj4gICAtIFswNC8xMl0gbmZjOiB0cmY3OTcwYTogY29uc3RpZnkgc2V2ZXJhbCBw b2ludGVycw0KPj4gICAgIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvbmV0ZGV2L25ldC1uZXh0L2Mv ZWEwNTBjNWVlNzRhDQo+PiAgIC0gWzA1LzEyXSBuZmM6IHZpcnR1YWxfbmNpZGV2OiBjb25zdGlm eSBwb2ludGVyIHRvIG5mY19kZXYNCj4+ICAgICBodHRwczovL2dpdC5rZXJuZWwub3JnL25ldGRl di9uZXQtbmV4dC9jLzgzNDI4ZGJiYWM1MQ0KPj4gICAtIFswNi8xMl0gbmZjOiBuZmNzaW06IGNv bnN0aWZ5IGRydmRhdGEgKHN0cnVjdCBuZmNzaW0pDQo+PiAgICAgaHR0cHM6Ly9naXQua2VybmVs Lm9yZy9uZXRkZXYvbmV0LW5leHQvYy81ODJmZGM5OGFkYzgNCj4+ICAgLSBbMDcvMTJdIG5mYzog ZmRwOiBkcm9wIHVubmVlZGVkIGNhc3QgZm9yIHByaW50aW5nIGZpcm13YXJlIHNpemUgaW4gZGV2 X2RiZygpDQo+PiAgICAgaHR0cHM6Ly9naXQua2VybmVsLm9yZy9uZXRkZXYvbmV0LW5leHQvYy82 Yzc1NWIxZDI1MTENCj4+ICAgLSBbMDgvMTJdIG5mYzogZmRwOiB1c2UgdW5zaWduZWQgaW50IGFz IGxvb3AgaXRlcmF0b3INCj4+ICAgICBodHRwczovL2dpdC5rZXJuZWwub3JnL25ldGRldi9uZXQt bmV4dC9jL2MzZTI2YjZkYzFiNA0KPj4gICAtIFswOS8xMl0gbmZjOiBmZHA6IGNvbnN0aWZ5IHNl dmVyYWwgcG9pbnRlcnMNCj4+ICAgICBodHRwczovL2dpdC5rZXJuZWwub3JnL25ldGRldi9uZXQt bmV4dC9jLzNkNDYzZGQ1MDIzYg0KPj4gICAtIFsxMC8xMl0gbmZjOiBtaWNyb3JlYWQ6IGNvbnN0 aWZ5IHNldmVyYWwgcG9pbnRlcnMNCj4+ICAgICBodHRwczovL2dpdC5rZXJuZWwub3JnL25ldGRl di9uZXQtbmV4dC9jL2E3NTE0NDlmOGI0Nw0KPj4gICAtIFsxMS8xMl0gbmZjOiBtcnZsOiBjb25z dGlmeSBzZXZlcmFsIHBvaW50ZXJzDQo+PiAgICAgaHR0cHM6Ly9naXQua2VybmVsLm9yZy9uZXRk ZXYvbmV0LW5leHQvYy9mZTUzMTU5ZmUzZTANCj4gDQo+IE9oLCBmb2xrcywgdG9vIGZhc3QgOikN Cj4gDQo+IFNvcnJ5IGZvciB0aGUgbWVzcywgYnV0IHRoZSBwYXRjaCAxMS8xMiBoYXMgb25lIGNv bnN0IHdoaWNoIGlzIHdyb25nDQo+IChJIHNlbnQgYW4gZW1haWwgZm9yIGl0KSBhbmQgdGhpcyBz aG91bGQgYmUgb24gdG9wIG9mIG15DQo+IHByZXZpb3VzIHNldDoNCj4gaHR0cHM6Ly9sb3JlLmtl cm5lbC5vcmcvbGttbC8yMDIxMDcyNjE0NTIyNC4xNDYwMDYtMS1rcnp5c3p0b2Yua296bG93c2tp QGNhbm9uaWNhbC5jb20vDQo+IHdoaWNoIEkgdGhpbmsgeW91IGRpZCBub3QgdGFrZSBpbi4NCj4g DQo+IEkgYW0gbm90IHN1cmUgaWYgaXQgY29tcGlsZXMgY2xlYW5seSB3aXRob3V0IHRoZSBvbmUg YWJvdmUuDQoNCkhpIERhdmlkLA0KDQpUaGlzIGZhaWxzIGJlY2F1c2Ugb2YgbWlzc2luZyBwYXRj aHNldCBhYm92ZToNCi4uL2RyaXZlcnMvbmZjL2ZkcC9mZHAuYzogSW4gZnVuY3Rpb24g4oCYZmRw X25jaV9zZXRfcHJvZHVjdGlvbl9kYXRh4oCZOg0KLi4vZHJpdmVycy9uZmMvZmRwL2ZkcC5jOjEx Njo2MDogd2FybmluZzogcGFzc2luZyBhcmd1bWVudCA0IG9mDQrigJhuY2lfcHJvcF9jbWTigJkg ZGlzY2FyZHMg4oCYY29uc3TigJkgcXVhbGlmaWVyIGZyb20gcG9pbnRlciB0YXJnZXQgdHlwZQ0K Wy1XZGlzY2FyZGVkLXF1YWxpZmllcnNdDQogIDExNiB8ICByZXR1cm4gbmNpX3Byb3BfY21kKG5k ZXYsIE5DSV9PUF9QUk9QX1NFVF9QREFUQV9PSUQsIGxlbiwgZGF0YSk7DQoNCkl0IGFsc28gaGFz IG9uZSBpc3N1ZSBpbiBwYXRjaCAxMS8xMi4gQ2FuIHlvdSBkcm9wIHRoaXMgZnJvbQ0KbmV0LWRl di9tYXN0ZXI/IEkgY2FuIHNlbmQgYSB2MiBvZiBib3RoIHBhdGNoc2V0cyBjb21iaW5lZC4NCg0K QmVzdCByZWdhcmRzLA0KS3J6eXN6dG9mCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkxpbnV4LW5mYyBtYWlsaW5nIGxpc3QgLS0gbGludXgtbmZjQGxpc3Rz LjAxLm9yZwpUbyB1bnN1YnNjcmliZSBzZW5kIGFuIGVtYWlsIHRvIGxpbnV4LW5mYy1sZWF2ZUBs aXN0cy4wMS5vcmcKJSh3ZWJfcGFnZV91cmwpc2xpc3RpbmZvJShjZ2lleHQpcy8lKF9pbnRlcm5h bF9uYW1lKXM= From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6752939461642675069==" MIME-Version: 1.0 From: Krzysztof Kozlowski To: linux-nfc@lists.01.org Subject: Re: [PATCH 00/12] nfc: constify, continued (part 2) Date: Thu, 29 Jul 2021 13:58:32 +0200 Message-ID: In-Reply-To: <7b0ae615-dcdc-251e-4067-959b31c28159@canonical.com> List-Id: --===============6752939461642675069== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 29/07/2021 13:35, Krzysztof Kozlowski wrote: > On 29/07/2021 13:30, patchwork-bot+netdevbpf(a)kernel.org wrote: >> Hello: >> >> This series was applied to netdev/net-next.git (refs/heads/master): >> >> On Thu, 29 Jul 2021 12:40:10 +0200 you wrote: >>> Hi, >>> >>> On top of: >>> nfc: constify pointed data >>> https://lore.kernel.org/lkml/20210726145224.146006-1-krzysztof.kozlowsk= i(a)canonical.com/ >>> >>> Best regards, >>> Krzysztof >>> >>> [...] >> >> Here is the summary with links: >> - [01/12] nfc: constify passed nfc_dev >> https://git.kernel.org/netdev/net-next/c/dd8987a394c0 >> - [02/12] nfc: mei_phy: constify buffer passed to mei_nfc_send() >> https://git.kernel.org/netdev/net-next/c/894a6e158633 >> - [03/12] nfc: port100: constify several pointers >> https://git.kernel.org/netdev/net-next/c/9a4af01c35a5 >> - [04/12] nfc: trf7970a: constify several pointers >> https://git.kernel.org/netdev/net-next/c/ea050c5ee74a >> - [05/12] nfc: virtual_ncidev: constify pointer to nfc_dev >> https://git.kernel.org/netdev/net-next/c/83428dbbac51 >> - [06/12] nfc: nfcsim: constify drvdata (struct nfcsim) >> https://git.kernel.org/netdev/net-next/c/582fdc98adc8 >> - [07/12] nfc: fdp: drop unneeded cast for printing firmware size in d= ev_dbg() >> https://git.kernel.org/netdev/net-next/c/6c755b1d2511 >> - [08/12] nfc: fdp: use unsigned int as loop iterator >> https://git.kernel.org/netdev/net-next/c/c3e26b6dc1b4 >> - [09/12] nfc: fdp: constify several pointers >> https://git.kernel.org/netdev/net-next/c/3d463dd5023b >> - [10/12] nfc: microread: constify several pointers >> https://git.kernel.org/netdev/net-next/c/a751449f8b47 >> - [11/12] nfc: mrvl: constify several pointers >> https://git.kernel.org/netdev/net-next/c/fe53159fe3e0 > = > Oh, folks, too fast :) > = > Sorry for the mess, but the patch 11/12 has one const which is wrong > (I sent an email for it) and this should be on top of my > previous set: > https://lore.kernel.org/lkml/20210726145224.146006-1-krzysztof.kozlowski(= a)canonical.com/ > which I think you did not take in. > = > I am not sure if it compiles cleanly without the one above. Hi David, This fails because of missing patchset above: ../drivers/nfc/fdp/fdp.c: In function =E2=80=98fdp_nci_set_production_data= =E2=80=99: ../drivers/nfc/fdp/fdp.c:116:60: warning: passing argument 4 of =E2=80=98nci_prop_cmd=E2=80=99 discards =E2=80=98const=E2=80=99 qualifier f= rom pointer target type [-Wdiscarded-qualifiers] 116 | return nci_prop_cmd(ndev, NCI_OP_PROP_SET_PDATA_OID, len, data); It also has one issue in patch 11/12. Can you drop this from net-dev/master? I can send a v2 of both patchsets combined. Best regards, Krzysztof --===============6752939461642675069==--