From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB34A6ED30 for ; Thu, 31 Jan 2019 18:43:00 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id u47so4616064qtj.6 for ; Thu, 31 Jan 2019 10:43:00 -0800 (PST) Message-ID: From: Lyude Paul Date: Thu, 31 Jan 2019 13:42:52 -0500 In-Reply-To: <20190130153828.4gd5mr546spvamgx@flea> References: <20190125145842.15738-1-maxime.ripard@bootlin.com> <20190125145842.15738-8-maxime.ripard@bootlin.com> <45cfa144bcb2366a54a1ec3128f71baeee61e6fb.camel@redhat.com> <20190130153828.4gd5mr546spvamgx@flea> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v5 07/13] igt: fb: Don't pass the stride when allocating a dumb, multi-planar buffer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maxime Ripard Cc: igt-dev@lists.freedesktop.org, Petri Latvala , Thomas Petazzoni , eben@raspberrypi.org List-ID: T24gV2VkLCAyMDE5LTAxLTMwIGF0IDE2OjM4ICswMTAwLCBNYXhpbWUgUmlwYXJkIHdyb3RlOgo+ IEhpIQo+IAo+IE9uIFR1ZSwgSmFuIDI5LCAyMDE5IGF0IDAzOjA4OjEwUE0gLTA1MDAsIEx5dWRl IFBhdWwgd3JvdGU6Cj4gPiBPbiBGcmksIDIwMTktMDEtMjUgYXQgMTU6NTggKzAxMDAsIE1heGlt ZSBSaXBhcmQgd3JvdGU6Cj4gPiA+IFRoZSBkdW1iIGJ1ZmZlciBhbGxvY2F0aW9uIEFQSSBvbmx5 IGNvbnNpZGVycyBhIHNpbmdsZSBwbGFuZSwgYW5kIGV2ZW4KPiA+ID4gdGhvdWdoIGFsbG9jYXRp bmcgbXVsdGktcGxhbmFyIGJ1ZmZlcnMgdGhyb3VnaCBpdCBpcyBhbGxvd2VkLCB0aGUgc3RyaWRl Cj4gPiA+IGl0Cj4gPiA+IGdpdmVzIGJhY2sgaXMgdGhlIHRoZSB3aWR0aCB0aW1lcyB0aGUgYnBw IHBhc3NlZCBhcyBhbiBhcmd1bWVudC4KPiA+ID4gCj4gPiA+IFRoYXQgZG9lc24ndCB3b3JrIGlu IG91ciBjYXNlLCBzaW5jZSB0aGUgYnBwIGlzIGdvaW5nIHRvIGJlIHRoZSBvbmUgd2UKPiA+ID4g Z2l2ZQo+ID4gPiBhcyBhbiBhcmd1bWVudCwgYnV0IHNwbGl0IG92ZXIgdGhyZWUgcGxhbmVzIHNv IHRoZSBzdHJpZGUgZG9lc24ndCBtYXRjaAo+ID4gPiBhbnltb3JlLgo+ID4gPiAKPiA+ID4gQSBw cm9wZXIgZml4IGZvciB0aGlzIHdvdWxkIGJlIHRvIGhhdmUgYSBiZXR0ZXIgZHVtYiBidWZmZXIg YWxsb2NhdGlvbgo+ID4gPiBBUEksCj4gPiA+IGJ1dCBmb3IgdGhlIHRpbWUgYmVpbmcsIGxldCdz IGRvIGl0IHRoYXQgd2F5Lgo+ID4gPiAKPiA+ID4gUmV2aWV3ZWQtYnk6IFBhdWwgS29jaWFsa293 c2tpIDxwYXVsLmtvY2lhbGtvd3NraUBib290bGluLmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1ieTog TWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBib290bGluLmNvbT4KPiA+ID4gLS0tCj4gPiA+ ICBsaWIvaWd0X2ZiLmMgfCAxNyArKysrKysrKysrKysrKysrLQo+ID4gPiAgMSBmaWxlIGNoYW5n ZWQsIDE2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1n aXQgYS9saWIvaWd0X2ZiLmMgYi9saWIvaWd0X2ZiLmMKPiA+ID4gaW5kZXggMWM1MmFlYmI2NzRl Li4wNDhkMjc0ZTVkMzYgMTAwNjQ0Cj4gPiA+IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ID4gPiArKysg Yi9saWIvaWd0X2ZiLmMKPiA+ID4gQEAgLTUzMCw2ICs1MzAsNyBAQCBzdGF0aWMgaW50IGNyZWF0 ZV9ib19mb3JfZmIoc3RydWN0IGlndF9mYiAqZmIpCj4gPiA+ICB7Cj4gPiA+ICAJY29uc3Qgc3Ry dWN0IGZvcm1hdF9kZXNjX3N0cnVjdCAqZm10ID0gbG9va3VwX2RybV9mb3JtYXQoZmItCj4gPiA+ ID4gZHJtX2Zvcm1hdCk7Cj4gPiA+ICAJdW5zaWduZWQgaW50IHBsYW5lLCBicHA7Cj4gPiA+ICsJ dW5zaWduZWQgKnN0cmlkZXMgPSAmZmItPnN0cmlkZXNbMF07Cj4gPiA+ICAJaW50IGZkID0gZmIt PmZkOwo+ID4gPiAgCj4gPiA+ICAJaWYgKGZiLT50aWxpbmcgfHwgZmItPnNpemUgfHwgZmItPnN0 cmlkZXNbMF0gfHwgaWd0X2Zvcm1hdF9pc195dXYoZmItCj4gPiA+ID4gZHJtX2Zvcm1hdCkpIHsK PiA+ID4gQEAgLTU3NSw4ICs1NzYsMjIgQEAgc3RhdGljIGludCBjcmVhdGVfYm9fZm9yX2ZiKHN0 cnVjdCBpZ3RfZmIgKmZiKQo+ID4gPiAgCQkJCSAgICBwbGFuZSA/IGZtdC0+aHN1YiAqIGZtdC0+ dnN1YiA6IDEpOwo+ID4gPiAgCj4gPiA+ICAJZmItPmlzX2R1bWIgPSB0cnVlOwo+ID4gPiArCj4g PiA+ICsJLyoKPiA+ID4gKwkgKiBXZSBjYW4ndCByZWFsbHkgcGFzcyB0aGUgc3RyaWRlIGFycmF5 IGhlcmUgc2luY2UgdGhlIGR1bWIKPiA+ID4gKwkgKiBidWZmZXIgYWxsb2NhdGlvbiBpcyBhc3N1 bWluZyB0aGF0IGl0IG9wZXJhdGVzIG9uIG9uZQo+ID4gPiArCSAqIHBsYW5lLCBhbmQgdGhlcmVm b3JlIHdpbGwgY2FsY3VsYXRlIHRoZSBzdHJpZGUgYXMgaWYgZWFjaAo+ID4gPiArCSAqIHBpeGVs cyB3ZXJlIHN0b3JlZCBvbiBhIHNpbmdsZSBwbGFuZS4KPiA+IAo+ID4gbml0cGljazogcy9lYWNo IHBpeGVscyB3ZXJlL2VhY2ggcGl4ZWwgd2FzLwo+ID4gCj4gPiA+ICsJICoKPiA+ID4gKwkgKiBU aGlzIG1pZ2h0IGNhdXNlIGlzc3VlcyBhdCBzb21lIHBvaW50IG9uIGRyaXZlcnMgdGhhdCB3b3Vs ZAo+ID4gPiArCSAqIGNoYW5nZSB0aGUgc3RyaWRlIG9mIFlVViBidWZmZXJzLCBidXQgd2UgaGF2 ZW4ndAo+ID4gPiArCSAqIGVuY291bnRlcmVkIGFueSB5ZXQuCj4gPiA+ICsJICovCj4gPiBJcyBp dCBwb3NzaWJsZSB0byBhZGQgYW4gaWd0X2Fzc2VydCB0byBjaGVjayBmb3IgdGhpcz8gRWl0aGVy IHdheSwgd2l0aAo+ID4gdGhvc2UKPiA+IGNoYW5nZXM6Cj4gCj4gSSdtIG5vdCBzdXJlIHdlIGNh biB0ZXN0IHRoaXMgYWN0dWFsbHkuIElmIHdlIGRvbid0IHBhc3MgYW55IHBvaW50ZXIsCj4gdGhl biB3ZSBkb24ndCBnZXQgYSBzdHJpZGUgYmFjaywgYW5kIGlmIHdlIGRvIHRoZW4gd2Ugd2lsbCBh bHdheXMgZ2V0Cj4gYSBzdHJpZGUgdGhhdCBpcyB3cm9uZyBmb3Igd2hhdCB3ZSdyZSB0cnlpbmcg dG8gZG8gOi8KQWgsIG1ha2VzIHNlbnNlCj4gCj4gTWF4aW1lCj4gCi0tIApDaGVlcnMsCglMeXVk ZSBQYXVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpp Z3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK