* [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
@ 2016-07-28 16:18 Wei Yongjun
2016-07-29 19:35 ` Sean Paul
0 siblings, 1 reply; 9+ messages in thread
From: Wei Yongjun @ 2016-07-28 16:18 UTC (permalink / raw)
To: Alex Deucher, christian.koenig, airlied, sonny.jiang, leo.liu,
arindam.nath, David1.Zhou, Jammy.Zhou, Monk.Liu
Cc: Wei Yongjun, dri-devel, linux-kernel
Use kmemdup rather than duplicating its implementation.
Generated by: scripts/coccinelle/api/memdup.cocci
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
index a46a64c..b779b5f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
@@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device *adev)
size = amdgpu_bo_size(adev->uvd.vcpu_bo);
ptr = adev->uvd.cpu_addr;
- adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
+ adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
if (!adev->uvd.saved_bo)
return -ENOMEM;
- memcpy(adev->uvd.saved_bo, ptr, size);
-
return 0;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
2016-07-28 16:18 [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation Wei Yongjun
@ 2016-07-29 19:35 ` Sean Paul
2016-07-29 19:38 ` Deucher, Alexander
0 siblings, 1 reply; 9+ messages in thread
From: Sean Paul @ 2016-07-29 19:35 UTC (permalink / raw)
To: Wei Yongjun
Cc: Alex Deucher, Christian König, Dave Airlie, sonny.jiang,
leo.liu, arindam.nath, David1.Zhou, Jammy.Zhou, Monk.Liu,
dri-devel, Linux Kernel Mailing List
On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> Use kmemdup rather than duplicating its implementation.
>
> Generated by: scripts/coccinelle/api/memdup.cocci
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Thanks for the patch. I'll apply this to -misc once the merge window is closed.
Acked-by: Sean Paul <seanpaul@chromium.org>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> index a46a64c..b779b5f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device *adev)
> size = amdgpu_bo_size(adev->uvd.vcpu_bo);
> ptr = adev->uvd.cpu_addr;
>
> - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
> + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
> if (!adev->uvd.saved_bo)
> return -ENOMEM;
>
> - memcpy(adev->uvd.saved_bo, ptr, size);
> -
> return 0;
> }
>
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
2016-07-29 19:35 ` Sean Paul
@ 2016-07-29 19:38 ` Deucher, Alexander
0 siblings, 0 replies; 9+ messages in thread
From: Deucher, Alexander @ 2016-07-29 19:38 UTC (permalink / raw)
To: 'Sean Paul', Wei Yongjun
Cc: Koenig, Christian, Dave Airlie, Jiang, Sonny, Liu, Leo, Nath,
Arindam, Zhou, David(ChunMing),
Zhou, Jammy, Liu, Monk, dri-devel, Linux Kernel Mailing List
> -----Original Message-----
> From: Sean Paul [mailto:seanpaul@google.com]
> Sent: Friday, July 29, 2016 3:35 PM
> To: Wei Yongjun
> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang, Sonny; Liu, Leo;
> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk; dri-devel;
> Linux Kernel Mailing List
> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than
> duplicating its implementation
>
> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> > Use kmemdup rather than duplicating its implementation.
> >
> > Generated by: scripts/coccinelle/api/memdup.cocci
> >
> > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>
>
> Thanks for the patch. I'll apply this to -misc once the merge window is closed.
>
> Acked-by: Sean Paul <seanpaul@chromium.org>
Unless you've already applied this to the misc tree, I'd prefer to take it via the amdgpu tree.
Alex
>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > index a46a64c..b779b5f 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device
> *adev)
> > size = amdgpu_bo_size(adev->uvd.vcpu_bo);
> > ptr = adev->uvd.cpu_addr;
> >
> > - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
> > + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
> > if (!adev->uvd.saved_bo)
> > return -ENOMEM;
> >
> > - memcpy(adev->uvd.saved_bo, ptr, size);
> > -
> > return 0;
> > }
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
@ 2016-07-29 19:38 ` Deucher, Alexander
0 siblings, 0 replies; 9+ messages in thread
From: Deucher, Alexander @ 2016-07-29 19:38 UTC (permalink / raw)
To: 'Sean Paul', Wei Yongjun
Cc: Nath, Arindam, Zhou, Jammy, Linux Kernel Mailing List, dri-devel,
Jiang, Sonny, Liu, Leo, Koenig, Christian, Liu, Monk
> -----Original Message-----
> From: Sean Paul [mailto:seanpaul@google.com]
> Sent: Friday, July 29, 2016 3:35 PM
> To: Wei Yongjun
> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang, Sonny; Liu, Leo;
> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk; dri-devel;
> Linux Kernel Mailing List
> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than
> duplicating its implementation
>
> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> > Use kmemdup rather than duplicating its implementation.
> >
> > Generated by: scripts/coccinelle/api/memdup.cocci
> >
> > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>
>
> Thanks for the patch. I'll apply this to -misc once the merge window is closed.
>
> Acked-by: Sean Paul <seanpaul@chromium.org>
Unless you've already applied this to the misc tree, I'd prefer to take it via the amdgpu tree.
Alex
>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > index a46a64c..b779b5f 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device
> *adev)
> > size = amdgpu_bo_size(adev->uvd.vcpu_bo);
> > ptr = adev->uvd.cpu_addr;
> >
> > - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
> > + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
> > if (!adev->uvd.saved_bo)
> > return -ENOMEM;
> >
> > - memcpy(adev->uvd.saved_bo, ptr, size);
> > -
> > return 0;
> > }
> >
> >
> >
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
2016-07-29 19:38 ` Deucher, Alexander
(?)
@ 2016-07-29 19:40 ` Sean Paul
-1 siblings, 0 replies; 9+ messages in thread
From: Sean Paul @ 2016-07-29 19:40 UTC (permalink / raw)
To: Deucher, Alexander
Cc: Wei Yongjun, Koenig, Christian, Dave Airlie, Jiang, Sonny, Liu,
Leo, Nath, Arindam, Zhou, David(ChunMing),
Zhou, Jammy, Liu, Monk, dri-devel, Linux Kernel Mailing List
On Fri, Jul 29, 2016 at 3:38 PM, Deucher, Alexander
<Alexander.Deucher@amd.com> wrote:
>> -----Original Message-----
>> From: Sean Paul [mailto:seanpaul@google.com]
>> Sent: Friday, July 29, 2016 3:35 PM
>> To: Wei Yongjun
>> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang, Sonny; Liu, Leo;
>> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk; dri-devel;
>> Linux Kernel Mailing List
>> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than
>> duplicating its implementation
>>
>> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
>> > Use kmemdup rather than duplicating its implementation.
>> >
>> > Generated by: scripts/coccinelle/api/memdup.cocci
>> >
>> > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>>
>>
>> Thanks for the patch. I'll apply this to -misc once the merge window is closed.
>>
>> Acked-by: Sean Paul <seanpaul@chromium.org>
>
> Unless you've already applied this to the misc tree, I'd prefer to take it via the amdgpu tree.
>
Nope, it's all yours.
Sean
> Alex
>
>>
>>
>> > ---
>> > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
>> > 1 file changed, 1 insertion(+), 3 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> > index a46a64c..b779b5f 100644
>> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> > @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device
>> *adev)
>> > size = amdgpu_bo_size(adev->uvd.vcpu_bo);
>> > ptr = adev->uvd.cpu_addr;
>> >
>> > - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
>> > + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
>> > if (!adev->uvd.saved_bo)
>> > return -ENOMEM;
>> >
>> > - memcpy(adev->uvd.saved_bo, ptr, size);
>> > -
>> > return 0;
>> > }
>> >
>> >
>> >
>> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
2016-07-29 19:38 ` Deucher, Alexander
@ 2016-08-01 12:16 ` Nicolai Hähnle
-1 siblings, 0 replies; 9+ messages in thread
From: Nicolai Hähnle @ 2016-08-01 12:16 UTC (permalink / raw)
To: Deucher, Alexander, 'Sean Paul', Wei Yongjun
Cc: Nath, Arindam, Zhou, Jammy, Linux Kernel Mailing List, dri-devel,
Jiang, Sonny, Liu, Leo, Koenig, Christian, Liu, Monk
On 29.07.2016 20:38, Deucher, Alexander wrote:
>> -----Original Message-----
>> From: Sean Paul [mailto:seanpaul@google.com]
>> Sent: Friday, July 29, 2016 3:35 PM
>> To: Wei Yongjun
>> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang, Sonny; Liu, Leo;
>> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk; dri-devel;
>> Linux Kernel Mailing List
>> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than
>> duplicating its implementation
>>
>> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
>>> Use kmemdup rather than duplicating its implementation.
>>>
>>> Generated by: scripts/coccinelle/api/memdup.cocci
>>>
>>> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>>
>>
>> Thanks for the patch. I'll apply this to -misc once the merge window is closed.
>>
>> Acked-by: Sean Paul <seanpaul@chromium.org>
>
> Unless you've already applied this to the misc tree, I'd prefer to take it via the amdgpu tree.
I recall Christian NAKing an almost identical patch some time ago.
Something about needing memcpy_fromio()?
Yup, it's here: https://lkml.org/lkml/2016/5/19/235
Cheers,
Nicolai
>
> Alex
>
>>
>>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>> index a46a64c..b779b5f 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>> @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device
>> *adev)
>>> size = amdgpu_bo_size(adev->uvd.vcpu_bo);
>>> ptr = adev->uvd.cpu_addr;
>>>
>>> - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
>>> + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
>>> if (!adev->uvd.saved_bo)
>>> return -ENOMEM;
>>>
>>> - memcpy(adev->uvd.saved_bo, ptr, size);
>>> -
>>> return 0;
>>> }
>>>
>>>
>>>
>>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
@ 2016-08-01 12:16 ` Nicolai Hähnle
0 siblings, 0 replies; 9+ messages in thread
From: Nicolai Hähnle @ 2016-08-01 12:16 UTC (permalink / raw)
To: Deucher, Alexander, 'Sean Paul', Wei Yongjun
Cc: Jiang, Sonny, Zhou, Jammy, Linux Kernel Mailing List, dri-devel,
Nath, Arindam, Liu, Leo, Koenig, Christian, Liu, Monk
On 29.07.2016 20:38, Deucher, Alexander wrote:
>> -----Original Message-----
>> From: Sean Paul [mailto:seanpaul@google.com]
>> Sent: Friday, July 29, 2016 3:35 PM
>> To: Wei Yongjun
>> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang, Sonny; Liu, Leo;
>> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk; dri-devel;
>> Linux Kernel Mailing List
>> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than
>> duplicating its implementation
>>
>> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
>>> Use kmemdup rather than duplicating its implementation.
>>>
>>> Generated by: scripts/coccinelle/api/memdup.cocci
>>>
>>> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>>
>>
>> Thanks for the patch. I'll apply this to -misc once the merge window is closed.
>>
>> Acked-by: Sean Paul <seanpaul@chromium.org>
>
> Unless you've already applied this to the misc tree, I'd prefer to take it via the amdgpu tree.
I recall Christian NAKing an almost identical patch some time ago.
Something about needing memcpy_fromio()?
Yup, it's here: https://lkml.org/lkml/2016/5/19/235
Cheers,
Nicolai
>
> Alex
>
>>
>>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>> index a46a64c..b779b5f 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>> @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device
>> *adev)
>>> size = amdgpu_bo_size(adev->uvd.vcpu_bo);
>>> ptr = adev->uvd.cpu_addr;
>>>
>>> - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
>>> + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
>>> if (!adev->uvd.saved_bo)
>>> return -ENOMEM;
>>>
>>> - memcpy(adev->uvd.saved_bo, ptr, size);
>>> -
>>> return 0;
>>> }
>>>
>>>
>>>
>>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
2016-08-01 12:16 ` Nicolai Hähnle
@ 2016-08-02 13:37 ` Christian König
-1 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2016-08-02 13:37 UTC (permalink / raw)
To: Nicolai Hähnle, Deucher, Alexander, 'Sean Paul',
Wei Yongjun
Cc: Jiang, Sonny, Zhou, Jammy, Linux Kernel Mailing List, dri-devel,
Nath, Arindam, Liu, Leo, Koenig, Christian, Liu, Monk
Am 01.08.2016 um 14:16 schrieb Nicolai Hähnle:
> On 29.07.2016 20:38, Deucher, Alexander wrote:
>>> -----Original Message-----
>>> From: Sean Paul [mailto:seanpaul@google.com]
>>> Sent: Friday, July 29, 2016 3:35 PM
>>> To: Wei Yongjun
>>> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang,
>>> Sonny; Liu, Leo;
>>> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk;
>>> dri-devel;
>>> Linux Kernel Mailing List
>>> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than
>>> duplicating its implementation
>>>
>>> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com>
>>> wrote:
>>>> Use kmemdup rather than duplicating its implementation.
>>>>
>>>> Generated by: scripts/coccinelle/api/memdup.cocci
>>>>
>>>> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>>>
>>>
>>> Thanks for the patch. I'll apply this to -misc once the merge window
>>> is closed.
>>>
>>> Acked-by: Sean Paul <seanpaul@chromium.org>
>>
>> Unless you've already applied this to the misc tree, I'd prefer to
>> take it via the amdgpu tree.
>
> I recall Christian NAKing an almost identical patch some time ago.
> Something about needing memcpy_fromio()?
>
> Yup, it's here: https://lkml.org/lkml/2016/5/19/235
Yes, exactly. We need memcpy_fromio() and memcpy_toio() in the
suspend/resume functions instead of memcpy.
I just didn't had time to test that yet (and that was unfortunately a
few month ago already).
So please drop this patch,
Christian.
>
> Cheers,
> Nicolai
>
>>
>> Alex
>>
>>>
>>>
>>>> ---
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
>>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>>> index a46a64c..b779b5f 100644
>>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>>> @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device
>>> *adev)
>>>> size = amdgpu_bo_size(adev->uvd.vcpu_bo);
>>>> ptr = adev->uvd.cpu_addr;
>>>>
>>>> - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
>>>> + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
>>>> if (!adev->uvd.saved_bo)
>>>> return -ENOMEM;
>>>>
>>>> - memcpy(adev->uvd.saved_bo, ptr, size);
>>>> -
>>>> return 0;
>>>> }
>>>>
>>>>
>>>>
>>>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
@ 2016-08-02 13:37 ` Christian König
0 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2016-08-02 13:37 UTC (permalink / raw)
To: Nicolai Hähnle, Deucher, Alexander, 'Sean Paul',
Wei Yongjun
Cc: Nath, Arindam, Zhou, Jammy, Linux Kernel Mailing List, dri-devel,
Jiang, Sonny, Liu, Leo, Koenig, Christian, Liu, Monk
Am 01.08.2016 um 14:16 schrieb Nicolai Hähnle:
> On 29.07.2016 20:38, Deucher, Alexander wrote:
>>> -----Original Message-----
>>> From: Sean Paul [mailto:seanpaul@google.com]
>>> Sent: Friday, July 29, 2016 3:35 PM
>>> To: Wei Yongjun
>>> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang,
>>> Sonny; Liu, Leo;
>>> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk;
>>> dri-devel;
>>> Linux Kernel Mailing List
>>> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than
>>> duplicating its implementation
>>>
>>> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com>
>>> wrote:
>>>> Use kmemdup rather than duplicating its implementation.
>>>>
>>>> Generated by: scripts/coccinelle/api/memdup.cocci
>>>>
>>>> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>>>
>>>
>>> Thanks for the patch. I'll apply this to -misc once the merge window
>>> is closed.
>>>
>>> Acked-by: Sean Paul <seanpaul@chromium.org>
>>
>> Unless you've already applied this to the misc tree, I'd prefer to
>> take it via the amdgpu tree.
>
> I recall Christian NAKing an almost identical patch some time ago.
> Something about needing memcpy_fromio()?
>
> Yup, it's here: https://lkml.org/lkml/2016/5/19/235
Yes, exactly. We need memcpy_fromio() and memcpy_toio() in the
suspend/resume functions instead of memcpy.
I just didn't had time to test that yet (and that was unfortunately a
few month ago already).
So please drop this patch,
Christian.
>
> Cheers,
> Nicolai
>
>>
>> Alex
>>
>>>
>>>
>>>> ---
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
>>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>>> index a46a64c..b779b5f 100644
>>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>>> @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device
>>> *adev)
>>>> size = amdgpu_bo_size(adev->uvd.vcpu_bo);
>>>> ptr = adev->uvd.cpu_addr;
>>>>
>>>> - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
>>>> + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
>>>> if (!adev->uvd.saved_bo)
>>>> return -ENOMEM;
>>>>
>>>> - memcpy(adev->uvd.saved_bo, ptr, size);
>>>> -
>>>> return 0;
>>>> }
>>>>
>>>>
>>>>
>>>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-08-02 13:48 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-28 16:18 [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation Wei Yongjun
2016-07-29 19:35 ` Sean Paul
2016-07-29 19:38 ` Deucher, Alexander
2016-07-29 19:38 ` Deucher, Alexander
2016-07-29 19:40 ` Sean Paul
2016-08-01 12:16 ` Nicolai Hähnle
2016-08-01 12:16 ` Nicolai Hähnle
2016-08-02 13:37 ` Christian König
2016-08-02 13:37 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.