All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matt Reimer" <mattjreimer@gmail.com>
To: "Matthieu CASTET" <matthieu.castet@parrot.fr>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] S3C2412 TACLS rate calculation fix
Date: Tue, 13 Feb 2007 10:47:27 -0800	[thread overview]
Message-ID: <f383264b0702131047r19254b52nf6f38882164ce588@mail.gmail.com> (raw)
In-Reply-To: <loom.20070213T122031-705@post.gmane.org>

On 2/13/07, Matthieu CASTET <matthieu.castet@parrot.fr> wrote:
> Ben Dooks <ben <at> fluff.org.uk> writes:
>
> >
> > The TALCs value on the S3C2412 value does not have
> > an +1 adjustment unlike the S3C2410 and S3C2440.
> >
> > The TALCs value on the S3C2440 is only 2 bits instead
> > of three, so change it to a maximum of 4.
> >
> > Re-work of an patch by Matt Reimer <mreimer <at> vpop.net>
> >
> Doesn't we lose the part that allow tacls to be 0 ?

Yes, we need that so 2410 can use 0 (which translates to 10 ns).

Also, I sent another patch that seems to have gotten hung up by the ml:

--- a/drivers/mtd/nand/s3c2410.c        Tue Jan 30 12:15:08 2007
+++ b/drivers/mtd/nand/s3c2410.c.patched        Tue Jan 30 12:15:08 2007
@@ -159,7 +159,8 @@ static int s3c_nand_calc_rate(int wanted
        int result;

        result = (wanted * clk) / NS_IN_KHZ;
-       result++;
+       if (((wanted * clk) % NS_IN_KHZ) != 0)
+               result++;

        pr_debug("result %d from %ld, %d\n", result, clk, wanted);

(Thanks the in-line clue Ben.)

Matt

      reply	other threads:[~2007-02-13 18:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-13 11:12 [PATCH] S3C2412 TACLS rate calculation fix Ben Dooks
2007-02-13 11:22 ` Matthieu CASTET
2007-02-13 18:47   ` Matt Reimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f383264b0702131047r19254b52nf6f38882164ce588@mail.gmail.com \
    --to=mattjreimer@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=matthieu.castet@parrot.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.