From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93F13C433EF for ; Tue, 5 Oct 2021 20:44:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2933E61181 for ; Tue, 5 Oct 2021 20:44:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2933E61181 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:46462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXrIC-0008O2-68 for qemu-devel@archiver.kernel.org; Tue, 05 Oct 2021 16:44:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXrG1-0007PC-3N; Tue, 05 Oct 2021 16:41:49 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:40793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXrFz-0005iw-DO; Tue, 05 Oct 2021 16:41:48 -0400 Received: from [192.168.100.1] ([82.142.3.114]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MjSPq-1nE1ks1KtG-00kwR4; Tue, 05 Oct 2021 22:41:24 +0200 Subject: Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host To: Paolo Bonzini , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20210926220103.1721355-1-f4bug@amsat.org> <20210926220103.1721355-2-f4bug@amsat.org> From: Laurent Vivier Message-ID: Date: Tue, 5 Oct 2021 22:41:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:noBP2QQ7HaA89+WEJDYwzjswp0ca2R369c2tF8OX7XkC3PFxOuH V0iNcwKZS6zvfpP8LY9OZ8ajSem1cLlnTIuOR1B6+543+bUGVkIOhCtji95bMJfMT2Z0hQr /KR3z2JK8EUTymeeqt6gScOrSUusR0DUl+U/hnZbXvOSx+TDBud1rTEs0K1VUX8dpwpqJ6o BVvlTHIMks9t3zv5SZsEw== X-UI-Out-Filterresults: notjunk:1;V03:K0:upEen/eyM78=:yiajRisN9vvugw2qCBOXjW uZIvJ8YI1AEevp33KFQMU4xbINQFdy82jRnc/R8u5RoGgp0VjxzhM+GKkK1FTi1LZXR3ZbWBk wP80kMkRHtUhmXluiePRjzHm7Q7hTFKLEvmUOhmtz2h6kLMKLbX18Q9FgYjnWKgsHvJSeLzY9 HLKaqwh/bgRqwZLOr9k2b5i/yJRiRN0MVmG5zjcpzM+gMdnFpa1XXnGf3gMogXUsXccaK7ndW Cf6lLdQzkOJtMVzrlwkeltSVs1lIfhP4pTknUsLEt6Qm6ZD6yXTOkRNIl0PhWw6/XOhDCMlPY X1i+Im8HlQTUJPSQBjlXdklrOiecRe8Fr2NcdDG/ie7pkwvZvqCSqnvWxSfr3ai2CEr4LLgU4 vjp8UV/f8WerKnin92Sb4R4EJA6XukTYzCJMYipZvp8OGIeH2FLXkvEHY9Uv4zjhon2jw/Joj fe5Sc92zFU5M5JhI2GMGpM+RoPVxrCeioikxXXJRBCZLVyx4Aji4CJUdoVuGcGp4XTSNLw9Ow 8lv+N35Vw3dm4ccsfuF54r5OeuA8/yrq2EKTDwL/PaU/FWAINYMgXyA1/ZXj/w8isS1PxZUCj DRisDmP7FUjaq1obOx7XbTNFgfnBqToYajH/ePMlUxo62bC4/Q60ZjhtLuq+lX27IiWuQMLzZ WQmbu1wzoLlhNeilhV++x6IsBLc3HdeMMBKL0U7FxT4zTomYCKI0qs3zO3pDJ2PN/eEbgDirF eFfIsB4bUpDlw3TyoIGMVwQH4t7OvaR4IlAokw== Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Kyle Evans , Richard Henderson , qemu-devel@nongnu.org, Warner Losh Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 05/10/2021 à 21:26, Paolo Bonzini a écrit : > On 27/09/21 11:52, Daniel P. Berrangé wrote: >>    bsd_user_ss.add(files('gdbstub.c')) >>    specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss) >> >> >> So without this change, we're already correctly dropping bsd_user_ss >> in its entirity, when not on BSD. >> >> With this change, we're dropping some, but not all, of bsd_user_ss >> files - gdbstub.c remains. >> >> So this change on its own doesn't make a whole lot of sense. > > Agreed; that said, the gdbstub.c files added by > >   bsd_user_ss.add(files('gdbstub.c')) >   linux_user_ss.add(files('gdbstub.c', 'thunk.c')) > > are unnecessary because there is already > >   specific_ss.add(files('cpu.c', 'disas.c', 'gdbstub.c'), capstone) > > So, with those two instances of gdbstub.c removed, both patches are > >   Acked-by: Paolo Bonzini > I can take them if a v2 is sent updated accordingly... Thanks, Laurent