From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [PATCH 1/6] ASoC: rt5651: Add IN3 Boost volume control Date: Thu, 19 Jul 2018 20:40:09 -0500 Message-ID: References: <20180718205542.12364-1-hdegoede@redhat.com> <20180718205542.12364-2-hdegoede@redhat.com> <20180719150234.GE27938@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by alsa0.perex.cz (Postfix) with ESMTP id 9E1C026733D for ; Fri, 20 Jul 2018 03:40:11 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Bard Liao , Mark Brown , Hans de Goede Cc: Liam Girdwood , Oder Chiou , "alsa-devel@alsa-project.org" , Carlo Caione List-Id: alsa-devel@alsa-project.org On 07/19/2018 08:31 PM, Bard Liao wrote: >> -----Original Message----- >> From: Mark Brown [mailto:broonie@kernel.org] >> Sent: Thursday, July 19, 2018 11:03 PM >> To: Hans de Goede >> Cc: Liam Girdwood; Bard Liao; Oder Chiou; Pierre-Louis Bossart; Carlo Caione; >> alsa-devel@alsa-project.org >> Subject: Re: [PATCH 1/6] ASoC: rt5651: Add IN3 Boost volume control >> >> On Wed, Jul 18, 2018 at 10:55:37PM +0200, Hans de Goede wrote: >> >>> + /* IN1/IN2/IN3 Control */ >>> SOC_SINGLE_TLV("IN1 Boost", RT5651_IN1_IN2, >>> RT5651_BST_SFT1, 8, 0, bst_tlv), >>> SOC_SINGLE_TLV("IN2 Boost", RT5651_IN1_IN2, >>> RT5651_BST_SFT2, 8, 0, bst_tlv), >>> + SOC_SINGLE_TLV("IN3 Boost", RT5651_IN3, >>> + RT5651_BST_SFT1, 8, 0, bst_tlv), >> These should all have Volume added to the name however that's a >> preexisting bug so not a blocker on this. > I will add "Volume" to the name for all of them. isn't this going to break userspace configs if we change the name of controls?