From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [RfC PATCH 2/4] memory: add support getting and using a dirty bitmap copy.
Date: Thu, 30 Mar 2017 17:48:50 +0200 [thread overview]
Message-ID: <f3907cf8-21bc-97eb-e8a9-2c387192f0da@redhat.com> (raw)
In-Reply-To: <1490856931-21732-3-git-send-email-kraxel@redhat.com>
On 30/03/2017 08:55, Gerd Hoffmann wrote:
> + bitmap_copy(copy->dirty + dest,
> + blocks->blocks[idx] + (offset >> BITS_PER_LEVEL),
> + num);
> + bitmap_zero(blocks->blocks[idx] + (offset >> BITS_PER_LEVEL),
> + num);
> +
This needs to access the bitmap atomically, so you'll need a new function
bool bitmap_copy_and_clear_atomic(unsigned long *dest,
unsigned long *src, long nr)
Paolo
next prev parent reply other threads:[~2017-03-30 15:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 6:55 [Qemu-devel] [RfC PATCH 0/4] make display updates thread safe Gerd Hoffmann
2017-03-30 6:55 ` [Qemu-devel] [RfC PATCH 1/4] vga: add vga_scanline_invalidated helper Gerd Hoffmann
2017-03-30 6:55 ` [Qemu-devel] [RfC PATCH 2/4] memory: add support getting and using a dirty bitmap copy Gerd Hoffmann
2017-03-30 15:48 ` Paolo Bonzini [this message]
2017-03-31 11:44 ` Paolo Bonzini
2017-03-30 6:55 ` [Qemu-devel] [RfC PATCH 3/4] vga: make display updates thread safe Gerd Hoffmann
2017-03-30 6:55 ` [Qemu-devel] [RfC PATCH 4/4] [testing] console: remove do_safe_dpy_refresh Gerd Hoffmann
2017-03-30 11:14 ` [Qemu-devel] [RfC PATCH 0/4] make display updates thread safe Mark Cave-Ayland
2017-03-30 13:41 ` Gerd Hoffmann
2017-04-03 5:26 ` Mark Cave-Ayland
2017-04-03 8:44 ` Gerd Hoffmann
2017-04-03 9:18 ` Mark Cave-Ayland
2017-04-03 11:49 ` Paolo Bonzini
2017-04-03 12:03 ` Gerd Hoffmann
2017-04-03 12:24 ` Mark Cave-Ayland
2017-04-03 12:42 ` Gerd Hoffmann
2017-04-03 15:06 ` Mark Cave-Ayland
2017-04-04 6:12 ` Gerd Hoffmann
2017-04-04 7:25 ` Mark Cave-Ayland
2017-04-03 17:02 ` Paolo Bonzini
2017-04-04 6:13 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3907cf8-21bc-97eb-e8a9-2c387192f0da@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.