Hi, I have sent a V2 patch. Thanks for your review. ------------------------------------------------------------------ 发件人:Logan Gunthorpe 发送时间:2021年6月5日(星期六) 00:21 收件人:Yang Li ; jdmason 抄 送:dave.jiang ; allenbh ; linux-ntb ; linux-kernel 主 题:Re: [PATCH 2/2] NTB: Fix an error code in ntb_msit_probe() On 2021-06-04 4:20 a.m., Yang Li wrote: > When the value of nm->isr_ctx is false, the value of ret is 0. > So, we set ret to -ENOMEM to indicate this error. > > Clean up smatch warning: > drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing error > code 'ret'. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers/ntb/test/ntb_msi_test.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/ntb/test/ntb_msi_test.c b/drivers/ntb/test/ntb_msi_test.c > index 7095ecd..5f9e0be 100644 > --- a/drivers/ntb/test/ntb_msi_test.c > +++ b/drivers/ntb/test/ntb_msi_test.c > @@ -369,8 +369,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb) > if (ret) > goto remove_dbgfs; > > - if (!nm->isr_ctx) > + if (!nm->isr_ctx) { > + return -ENOMEM; > goto remove_dbgfs; I think you made a typo here. You probably meant ret = -ENOMEM. Thanks, Logan