From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C78C432BE for ; Mon, 9 Aug 2021 13:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D23360EC0 for ; Mon, 9 Aug 2021 13:07:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235233AbhHINHc (ORCPT ); Mon, 9 Aug 2021 09:07:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234821AbhHINHb (ORCPT ); Mon, 9 Aug 2021 09:07:31 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD8DCC0613D3; Mon, 9 Aug 2021 06:07:10 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id l11so4618197plk.6; Mon, 09 Aug 2021 06:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=INt6AMamKTURCHBhwQYi/H+ih28+y9YbRQVY0oda3OQ=; b=RF+TiZwOlLjqHEQ/UxdiSntRf5kvSPsYhdWZqHM0222Rv4B1IsiCFAIZMPboFd55p+ SlSmUajD81mq/R1Bg1x6MhStb3pHCuhQrpQqW6cPlaFcq+jLfSCVB+BsvP2qXpcp+Pwa 6mWLO3grVhk5UQvuaKEgNY7MTS89++EtHKaPwrI0Vy9Is82axNX7sxlb0FdG9q9E6thB uHHoPQUntfJ2D8Y0IMXoZVduxXc0uG5zmpAKQYYnH6s2pbkcaDwnmn/hv8KaiCGE+Ru+ hAQrx/aIoMKSztedQXf1ygujFpZIOV3axKn6VdH6rM8KgqEbVcvT/hdJdcwzpGv8Qu3v 7ahw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=INt6AMamKTURCHBhwQYi/H+ih28+y9YbRQVY0oda3OQ=; b=HQ5bi9aUYuX3m1hajQhzrYm/k3JP+hRzJxAmVvmAweocl47yZQ80qciAQOdE3GvCyn 2J6YpF56lHZkZCwW7DUJpUYJuSFvtYZVN7mAWwsHbUzxgqd/RxrxRA5VT4klZwFYXFJ7 mknHYNjlVe58XI5hbh0DaVpcqTbvYwVsQnp3azj7msSvzqHKaZfgDASF1gCHKgqExVgl wjMd2c2ocNEddZNvtPZ1td23lgTLl7w4XqA+xpjQRI23nJvbFhKoGge5HVdcVFFq/QXC 3So6PdV9LR95ofHf2Jwd0wTIn/zaZyr/nBoNi1qrLai6STlTR798SubDlhsF9wVyRnmQ k28Q== X-Gm-Message-State: AOAM530a/zECYauL5ade9XJ5CgfFrITsOxLuUDIbFTqLnyxZiEctAS33 IVg+g2ZWTZluBthHT5RoJjklusNTsj7IFg== X-Google-Smtp-Source: ABdhPJwOgGjGoHMNx/ZpkPu+WJL8ZCtgR0RxuWbJfre36P6GZYLUbloyN4qP9bWbhQrfny1QAZpP7Q== X-Received: by 2002:a65:4682:: with SMTP id h2mr1116172pgr.409.1628514430397; Mon, 09 Aug 2021 06:07:10 -0700 (PDT) Received: from Likes-MacBook-Pro.local ([103.7.29.32]) by smtp.gmail.com with ESMTPSA id b8sm18546770pjo.51.2021.08.09.06.07.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 06:07:09 -0700 (PDT) Subject: Re: [PATCH v7 03/15] KVM: x86: Add Arch LBR MSRs to msrs_to_save_all list To: Yang Weijiang , Jim Mattson References: <1628235745-26566-1-git-send-email-weijiang.yang@intel.com> <1628235745-26566-4-git-send-email-weijiang.yang@intel.com> Cc: pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wei.w.wang@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Like Xu Organization: Tencent Message-ID: Date: Mon, 9 Aug 2021 21:07:01 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <1628235745-26566-4-git-send-email-weijiang.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/8/2021 3:42 pm, Yang Weijiang wrote: > Arch LBR MSR_ARCH_LBR_DEPTH and MSR_ARCH_LBR_CTL are {saved|restored} > by userspace application if they're available. > > Suggested-by: Jim Mattson > Signed-off-by: Yang Weijiang > Reviewed-by: Jim Mattson > --- > arch/x86/kvm/x86.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 4116567f3d44..4ae173ab2208 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -1327,6 +1327,7 @@ static const u32 msrs_to_save_all[] = { > MSR_ARCH_PERFMON_EVENTSEL0 + 12, MSR_ARCH_PERFMON_EVENTSEL0 + 13, > MSR_ARCH_PERFMON_EVENTSEL0 + 14, MSR_ARCH_PERFMON_EVENTSEL0 + 15, > MSR_ARCH_PERFMON_EVENTSEL0 + 16, MSR_ARCH_PERFMON_EVENTSEL0 + 17, > + MSR_ARCH_LBR_CTL, MSR_ARCH_LBR_DEPTH, Hi Jim, Do you have a particular reason for not putting the set of MSR_ARCH_LBR_{FROM, TO, INFO} into msrs_to_save_all[] for {saved|restored} by user space ? > }; > > static u32 msrs_to_save[ARRAY_SIZE(msrs_to_save_all)]; > @@ -6229,6 +6230,11 @@ static void kvm_init_msr_list(void) > min(INTEL_PMC_MAX_GENERIC, x86_pmu.num_counters_gp)) > continue; > break; > + case MSR_ARCH_LBR_DEPTH: > + case MSR_ARCH_LBR_CTL: > + if (!kvm_cpu_cap_has(X86_FEATURE_ARCH_LBR)) > + continue; > + break; > default: > break; > } >