From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1cWEZc-0004lI-H9 for mharc-grub-devel@gnu.org; Tue, 24 Jan 2017 22:48:40 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWEZa-0004jx-5L for grub-devel@gnu.org; Tue, 24 Jan 2017 22:48:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWEZV-0007rD-BJ for grub-devel@gnu.org; Tue, 24 Jan 2017 22:48:38 -0500 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:34659) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cWEZV-0007r9-3n for grub-devel@gnu.org; Tue, 24 Jan 2017 22:48:33 -0500 Received: by mail-lf0-x243.google.com with SMTP id q89so19241680lfi.1 for ; Tue, 24 Jan 2017 19:48:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=C2Yq7HmHzRR85RCwXy7Z01E5vl3r/U5+oUhRW22qAKw=; b=lBuY3Cldjk5YU4YrnY4mhVpUnYNSNFH5gorKuom8MFzJdAwvkgQ3c3ovAqaH2UeAQK CiGNQm5gL8+NlASEnk2OcXKMFqAYSDpgbKB8sLkftQ9+yAsOupBCY/sBbfZi0Nf10/gh j7v8bpC15cC72Bt/aJF5a7MYTcwJ9md4+caZMFxGpShX9SW8fcx7LbMeRzd7KxDATlde O5ynWwrqJgWq8GLGWsxqLcm0+vj8aaiViXwu3LH3A1K0M2KgxVIxRzgcIRK9xW9oO+0k YwHjmSv1kkzHgZLbBOD1thdXb3sh5j2BQEgB23UZ2AOOHquvDRjiG5jcmr0J81TsjgaD G4lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=C2Yq7HmHzRR85RCwXy7Z01E5vl3r/U5+oUhRW22qAKw=; b=UALTNNJAvJ6uqKkFsY0VtKxCn82mGvr4KIFxy5383J3XC7pIt+JfJWmFgU2Uo6XVDV EfRktCxhhGiJBGc2Z4bfykXJSHTeeyyj0vQR2F/MdFMZKWF0rl2AJfp8vJaAiKN2sUMW +Gj1tq/5xcv2WdEzWmE0hB48Fkx6JobJpb2d8rhbjOm4gdpQ6tiSYClfK+6J1KZyv/vS u9qv6gb/06KWiKAeuVfC+tNrbWfwQlY6SXYQKDl2K32pNlgbugM0XcFG6ZVg36vPiF39 +fgyydaMPbvEr8FH9uFmhzN3q7otD66WzLNDvkyew+6Nnqu12O21n209zauKM5fl9Ehi FvIA== X-Gm-Message-State: AIkVDXKuoEnHMCIjEqqxig8Jl+u/OL/cQ6KCj7mQFYWaSYweXsB0iRqLedPsyMMrKl+IhA== X-Received: by 10.25.29.68 with SMTP id d65mr10331343lfd.112.1485316111462; Tue, 24 Jan 2017 19:48:31 -0800 (PST) Received: from [192.168.1.3] (ppp109-252-90-129.pppoe.spdop.ru. [109.252.90.129]) by smtp.gmail.com with ESMTPSA id y9sm7976882ljd.41.2017.01.24.19.48.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jan 2017 19:48:30 -0800 (PST) Subject: Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon To: Matthew Garrett References: <20170124003601.24612-1-mjg59@coreos.com> <20170124003601.24612-5-mjg59@coreos.com> <411c7ef8-85a2-afd8-7446-0fd8d3d98616@gmail.com> Cc: The development of GNU GRUB From: Andrei Borzenkov Message-ID: Date: Wed, 25 Jan 2017 06:48:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::243 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2017 03:48:39 -0000 24.01.2017 23:50, Matthew Garrett пишет: > On Mon, Jan 23, 2017 at 8:02 PM, Andrei Borzenkov wrote: >> 24.01.2017 03:36, Matthew Garrett пишет: >>> Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making >>> it impossible to pass boot files with commas in them. Allow using a >> >> grub_net_open() operates on devices, not files. Please give more details >> about your problem. > > The DHCP server will return a string in the boot_file field. If you > want to indicate that this file should be obtained over http, the > easiest way to handle this is to provide a boot file in the form > (http,host)filename. Unfortunately dnsmasq uses commas to tokenise its > configuration parameters and there appears to be no way to override > that, which makes it impossible to provide a boot file in this form. > Allowing the use of an alternative character avoids this problem. > This won't work because (http,host) will never be interpreted as device in current code so you need to support this first before this patch can even be considered. Also I am not convinced that arbitrary changing syntax is good idea. You already can set $prefix when generating image. Why is it not enough?