From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F167C43219 for ; Mon, 29 Apr 2019 14:18:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5864D20673 for ; Mon, 29 Apr 2019 14:18:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728267AbfD2OR6 (ORCPT ); Mon, 29 Apr 2019 10:17:58 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7708 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728258AbfD2ORy (ORCPT ); Mon, 29 Apr 2019 10:17:54 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 3D3799B46EFC098ABCCE; Mon, 29 Apr 2019 22:17:50 +0800 (CST) Received: from [127.0.0.1] (10.177.31.96) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Mon, 29 Apr 2019 22:17:49 +0800 Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe() To: Andrew Lunn References: <20190429135650.72794-1-yuehaibing@huawei.com> <20190429135603.GI10772@lunn.ch> CC: Grygorii Strashko , Ivan Khoronzhuk , Ilias Apalodimas , , , From: YueHaibing Message-ID: Date: Mon, 29 Apr 2019 22:17:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20190429135603.GI10772@lunn.ch> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/4/29 21:56, Andrew Lunn wrote: > On Mon, Apr 29, 2019 at 01:56:50PM +0000, YueHaibing wrote: >> Change the call to PTR_ERR to access the value just tested by IS_ERR. >> >> Signed-off-by: YueHaibing > > Please could you add a Fixes: tag. > Ok, will sendv2, thanks! > Reviewed-by: Andrew Lunn > > Andrew > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: YueHaibing Date: Mon, 29 Apr 2019 14:17:48 +0000 Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe() Message-Id: List-Id: References: <20190429135650.72794-1-yuehaibing@huawei.com> <20190429135603.GI10772@lunn.ch> In-Reply-To: <20190429135603.GI10772@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Lunn Cc: Grygorii Strashko , Ivan Khoronzhuk , Ilias Apalodimas , linux-omap@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On 2019/4/29 21:56, Andrew Lunn wrote: > On Mon, Apr 29, 2019 at 01:56:50PM +0000, YueHaibing wrote: >> Change the call to PTR_ERR to access the value just tested by IS_ERR. >> >> Signed-off-by: YueHaibing > > Please could you add a Fixes: tag. > Ok, will sendv2, thanks! > Reviewed-by: Andrew Lunn > > Andrew > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: YueHaibing Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe() Date: Mon, 29 Apr 2019 22:17:48 +0800 Message-ID: References: <20190429135650.72794-1-yuehaibing@huawei.com> <20190429135603.GI10772@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190429135603.GI10772@lunn.ch> Sender: netdev-owner@vger.kernel.org To: Andrew Lunn Cc: Grygorii Strashko , Ivan Khoronzhuk , Ilias Apalodimas , linux-omap@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-omap@vger.kernel.org On 2019/4/29 21:56, Andrew Lunn wrote: > On Mon, Apr 29, 2019 at 01:56:50PM +0000, YueHaibing wrote: >> Change the call to PTR_ERR to access the value just tested by IS_ERR. >> >> Signed-off-by: YueHaibing > > Please could you add a Fixes: tag. > Ok, will sendv2, thanks! > Reviewed-by: Andrew Lunn > > Andrew > > . >