From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/microcode/AMD: check microcode file sanity before loading it
Date: Sat, 10 Mar 2018 14:26:31 +0100 [thread overview]
Message-ID: <f3b93016-758c-e033-9e08-fcca650b00e4@maciej.szmigiero.name> (raw)
In-Reply-To: <20180310131202.GB8261@pd.tnic>
On 10.03.2018 14:12, Borislav Petkov wrote:
> On Sat, Mar 10, 2018 at 01:26:00PM +0100, Maciej S. Szmigiero wrote:
>> Without them, it is easy to crash the driver when just playing with
>> microcode files
>
> You're not supposed to play with the microcode files. If you do and
> something breaks, you get to keep the pieces.
>
> If the official microcode files have a problem, then I'm all ears.
> Anything else contrived which doesn't actually happen unless someone
> manipulates them is not an issue the microcode loader should protect
> against.
>
So, shall we remove data consistency checks of various root-only
syscalls then? :)
Maciej
next prev parent reply other threads:[~2018-03-10 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 0:34 [PATCH] x86/microcode/AMD: check microcode file sanity before loading it Maciej S. Szmigiero
2018-03-10 9:18 ` Borislav Petkov
2018-03-10 12:26 ` Maciej S. Szmigiero
2018-03-10 13:12 ` Borislav Petkov
2018-03-10 13:26 ` Maciej S. Szmigiero [this message]
2018-03-10 16:16 ` Maciej S. Szmigiero
2018-03-10 16:46 ` Borislav Petkov
2018-03-10 17:26 ` Maciej S. Szmigiero
2018-03-11 9:59 ` Ingo Molnar
2018-03-11 13:25 ` Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3b93016-758c-e033-9e08-fcca650b00e4@maciej.szmigiero.name \
--to=mail@maciej.szmigiero.name \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.