From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anand Rawat <anand.rawat@intel.com>
Subject: Re: [PATCH v7 8/8] build: meson changes to build on
 windows
Date: Mon, 1 Apr 2019 20:47:56 -0700
Message-ID: <f3c894b2-a03f-3aea-1bec-f5d7140fcd97@intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <20190328232451.16988-1-anand.rawat@intel.com>
 <20190328232451.16988-9-anand.rawat@intel.com> <1874669.yI0RQQHDzX@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com,
 jeffrey.b.shaw@intel.com, bruce.richardson@intel.com,
 harini.ramakrishnan@microsoft.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id CDF845323
 for <dev@dpdk.org>; Tue,  2 Apr 2019 05:47:57 +0200 (CEST)
In-Reply-To: <1874669.yI0RQQHDzX@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/1/2019 4:25 PM, Thomas Monjalon wrote:
> 29/03/2019 00:24, Anand Rawat:
>> Added meson workarounds to build helloworld on windows.
>> Windows currently only supports kvargs and eal libraries.
>> This change restricts the build flow to supported libraries
>> only.
> [...]
>> --- a/app/meson.build
>> +++ b/app/meson.build
>> @@ -1,5 +1,9 @@
>>   # SPDX-License-Identifier: BSD-3-Clause
>> -# Copyright(c) 2017 Intel Corporation
>> +# Copyright(c) 2017-2019 Intel Corporation
>> +
>> +if host_machine.system() == 'windows'
>> +	subdir_done()
>> +endif
> 
> Not sure this change deserves a copyright update :)

I am not sure either, basic principle that I am following
is if any file is touched with some code/logic the license
should be updated. Do correct me if I am wrong. I can make
the changes accordingly in the future releases.

> 
>> --- a/examples/meson.build
>> +++ b/examples/meson.build
>> -	deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']
> 
> Please keep this line intact.
> 
>> +	if host_machine.system() != 'windows'
>> +		deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']
>> +	else
>> +		deps = ['eal'] # only supported lib on windows currently
>> +	endif
> 
> You could override deps for Windows only.
> 

Will be updated in v8

-- 
Anand Rawat