From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [RFC v2 bpf-next 5/9] net/ipv6: Add fib6_lookup
Date: Tue, 1 May 2018 12:25:24 -0600
Message-ID: <f3cbb565-6275-f1c6-e215-f4723ac965bd@gmail.com>
References: <20180429180752.15428-1-dsahern@gmail.com>
 <20180429180752.15428-6-dsahern@gmail.com> <m3wownckdr.fsf@luffy.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: netdev@vger.kernel.org, borkmann@iogearbox.net, ast@kernel.org,
        davem@davemloft.net, shm@cumulusnetworks.com,
        roopa@cumulusnetworks.com, brouer@redhat.com, toke@toke.dk,
        john.fastabend@gmail.com
To: Vincent Bernat <bernat@luffy.cx>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f195.google.com ([209.85.192.195]:43291 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756413AbeEASZ2 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 1 May 2018 14:25:28 -0400
Received: by mail-pf0-f195.google.com with SMTP id j11so9652923pff.10
        for <netdev@vger.kernel.org>; Tue, 01 May 2018 11:25:28 -0700 (PDT)
In-Reply-To: <m3wownckdr.fsf@luffy.cx>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 5/1/18 12:15 PM, Vincent Bernat wrote:
>  ❦ 29 avril 2018 11:07 -0700, David Ahern <dsahern@gmail.com> :
> 
>> +struct fib6_info *fib6_lookup(struct net *net, int oif, struct flowi6 *fl6,
>> +			      int flags)
> 
> Maybe an EXPORT_SYMBOL_GPL? There is one for __fib_lookup (fib_lookup is
> an inline function).
> 

There needs to be an in-tree user relying on it. My intention is to
convert rt6_lookup to fib6_lookup; as I recall all of those just want
the egress device and do not need a dst based response. That might
provide the in-tree user - depending on how the conversion is done.

And I presume you are asking for your benchmark modules. I can send you
my diffs and results.