From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 2/2] gpio: stm32f7: Fix SPL code size
Date: Tue, 31 Mar 2020 04:51:42 +0200 [thread overview]
Message-ID: <f3e23915-c6ae-7c4d-7c5a-f725f726b5d4@denx.de> (raw)
In-Reply-To: <1546595706-31360-3-git-send-email-patrice.chotard@st.com>
On 1/4/19 10:55 AM, Patrice Chotard wrote:
Hi,
> @@ -215,7 +220,9 @@ U_BOOT_DRIVER(gpio_stm32) = {
> .id = UCLASS_GPIO,
> .of_match = stm32_gpio_ids,
> .probe = gpio_stm32_probe,
> +#ifndef CONFIG_SPL_BUILD
> .ops = &gpio_stm32_ops,
> +#endif
> .flags = DM_UC_FLAG_SEQ_ALIAS,
> .priv_auto_alloc_size = sizeof(struct stm32_gpio_priv),
> };
The U-Boot DM GPIO uclass code assumes the .ops is always non-NULL.
Hence, this patch breaks all GPIO access (actually crashes SPL) on STM32
in SPL.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2020-03-31 2:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 9:55 [U-Boot] [PATCH v1 0/2] stm32f7 gpio driver fixes Patrice Chotard
2019-01-04 9:55 ` [U-Boot] [PATCH v1 1/2] gpio: stm32f7: Fix gpio bank hole management Patrice Chotard
2019-01-10 2:31 ` [U-Boot] [U-Boot, v1, " Tom Rini
2019-01-04 9:55 ` [U-Boot] [PATCH v1 2/2] gpio: stm32f7: Fix SPL code size Patrice Chotard
2019-01-10 2:31 ` [U-Boot] [U-Boot,v1,2/2] " Tom Rini
2020-03-31 2:51 ` Marek Vasut [this message]
2020-03-31 8:12 ` [U-Boot] [PATCH v1 2/2] " Patrice CHOTARD
2020-03-31 11:22 ` Marek Vasut
2020-03-31 14:10 ` Patrice CHOTARD
2020-03-31 16:07 ` Marek Vasut
2020-03-31 16:08 ` Simon Glass
2020-03-31 16:29 ` Patrick DELAUNAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3e23915-c6ae-7c4d-7c5a-f725f726b5d4@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.