From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754416AbeAQQhm (ORCPT <rfc822;w@1wt.eu>);
        Wed, 17 Jan 2018 11:37:42 -0500
Received: from mail-wr0-f179.google.com ([209.85.128.179]:45538 "EHLO
        mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754117AbeAQQhh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 17 Jan 2018 11:37:37 -0500
X-Google-Smtp-Source: ACJfBosV12dKgwc7SNClKmOY6ivB1Kr7IslCFoRvfMfyB5rtzsMVX8i/PH+q5ETZABC08Kh5yOvtmQ==
Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state
To: Emil Velikov <emil.l.velikov@gmail.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>, Jingoo Han <jingoohan1@gmail.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Lee Jones <lee.jones@linaro.org>
References: <20180117140159.27611-1-daniel.vetter@ffwll.ch>
 <20180117140159.27611-2-daniel.vetter@ffwll.ch>
 <CACvgo53UTbyAMi+Cp-Oye+7QuSJqeBdZiSyEuTKGQPSf8UdeLw@mail.gmail.com>
From: Daniel Thompson <daniel.thompson@linaro.org>
Message-ID: <f3e2e046-9a26-39ad-d08f-3715722d7cd9@linaro.org>
Date: Wed, 17 Jan 2018 16:37:33 +0000
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <CACvgo53UTbyAMi+Cp-Oye+7QuSJqeBdZiSyEuTKGQPSf8UdeLw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 17/01/18 14:36, Emil Velikov wrote:
> On 17 January 2018 at 14:01, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>> Nothing in the entire tree ever sets this, which means this is dead
>> code. Remove it.
>>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Cc: Daniel Thompson <daniel.thompson@linaro.org>
>> Cc: Jingoo Han <jingoohan1@gmail.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>> ---
>>   drivers/video/backlight/generic_bl.c | 5 -----
> 
> Fly-by comment, while waiting for coffee to kick-in.
> I think this patch should be after pandora/others have stopped abusing
> BL_CORE_DRIVER1.

You sure?

I can't see why the use or disuse of BL_CORE_DRIVER1 in this driver 
should influence another independent driver.


Daniel.